e17744faf0
This commit upgrades TypeScript from 5.4 to 5.5 and enables the
`noImplicitAny` option for stricter type checking. It refactors code to
comply with `noImplicitAny` and adapts to new TypeScript features and
limitations.
Key changes:
- Migrate from TypeScript 5.4 to 5.5
- Enable `noImplicitAny` for stricter type checking
- Refactor code to comply with new TypeScript features and limitations
Other supporting changes:
- Refactor progress bar handling for type safety
- Drop 'I' prefix from interfaces to align with new code convention
- Update TypeScript target from `ES2017` and `ES2018`.
This allows named capturing groups. Otherwise, new TypeScript compiler
does not compile the project and shows the following error:
```
...
TimestampedFilenameGenerator.spec.ts:105:23 - error TS1503: Named capturing groups are only available when targeting 'ES2018' or later
const pattern = /^(?<timestamp>\d{4}-\d{2}-\d{2}_\d{2}-\d{2}-\d{2})-(?<scriptName>[^.]+?)(?:\.(?<extension>[^.]+))?$/;// timestamp-scriptName.extension
...
```
- Refactor usage of `electron-progressbar` for type safety and
less complexity.
75 lines
2.6 KiB
TypeScript
75 lines
2.6 KiB
TypeScript
import {
|
|
describe, beforeEach, afterEach, expect,
|
|
} from 'vitest';
|
|
import { VITE_ENVIRONMENT_KEYS } from '@/infrastructure/EnvironmentVariables/Vite/ViteEnvironmentKeys';
|
|
import type { PropertyKeys } from '@/TypeHelpers';
|
|
import type { IEnvironmentVariables } from '@/infrastructure/EnvironmentVariables/IEnvironmentVariables';
|
|
import { ViteEnvironmentVariables } from '@/infrastructure/EnvironmentVariables/Vite/ViteEnvironmentVariables';
|
|
|
|
describe('ViteEnvironmentVariables', () => {
|
|
describe('reads values from import.meta.env', () => {
|
|
let originalMetaEnv: ImportMetaEnv;
|
|
beforeEach(() => {
|
|
originalMetaEnv = { ...import.meta.env };
|
|
});
|
|
afterEach(() => {
|
|
Object.assign(import.meta.env, originalMetaEnv);
|
|
});
|
|
|
|
interface EnvironmentVariableTestScenario<T> {
|
|
readonly getActualValue: (sut: IEnvironmentVariables) => T;
|
|
readonly environmentVariable: typeof VITE_ENVIRONMENT_KEYS[
|
|
keyof typeof VITE_ENVIRONMENT_KEYS];
|
|
readonly expected: T;
|
|
}
|
|
const testCases: {
|
|
readonly [K in PropertyKeys<IEnvironmentVariables>]:
|
|
EnvironmentVariableTestScenario<string | boolean>;
|
|
} = {
|
|
name: {
|
|
environmentVariable: VITE_ENVIRONMENT_KEYS.NAME,
|
|
expected: 'expected-name',
|
|
getActualValue: (sut) => sut.name,
|
|
},
|
|
version: {
|
|
environmentVariable: VITE_ENVIRONMENT_KEYS.VERSION,
|
|
expected: 'expected-version',
|
|
getActualValue: (sut) => sut.version,
|
|
},
|
|
repositoryUrl: {
|
|
environmentVariable: VITE_ENVIRONMENT_KEYS.REPOSITORY_URL,
|
|
expected: 'expected-slogan',
|
|
getActualValue: (sut) => sut.repositoryUrl,
|
|
},
|
|
slogan: {
|
|
environmentVariable: VITE_ENVIRONMENT_KEYS.SLOGAN,
|
|
expected: 'expected-repositoryUrl',
|
|
getActualValue: (sut) => sut.slogan,
|
|
},
|
|
homepageUrl: {
|
|
environmentVariable: VITE_ENVIRONMENT_KEYS.HOMEPAGE_URL,
|
|
expected: 'expected-homepageUrl',
|
|
getActualValue: (sut) => sut.homepageUrl,
|
|
},
|
|
isNonProduction: {
|
|
environmentVariable: VITE_ENVIRONMENT_KEYS.DEV,
|
|
expected: false,
|
|
getActualValue: (sut) => sut.isNonProduction,
|
|
},
|
|
};
|
|
Object.values(testCases).forEach(({ environmentVariable, expected, getActualValue }) => {
|
|
it(`should correctly get the value of ${environmentVariable}`, () => {
|
|
// arrange
|
|
import.meta.env[environmentVariable] = expected;
|
|
|
|
// act
|
|
const sut = new ViteEnvironmentVariables();
|
|
const actualValue = getActualValue(sut);
|
|
|
|
// assert
|
|
expect(actualValue).toBe(expected);
|
|
});
|
|
});
|
|
});
|
|
});
|