This commit improves the handling of paths with spaces or special characters during script execution in the desktop application. Key improvements: - Paths are now quoted for macOS/Linux, addressing issues with whitespace or single quotes. - Windows paths are enclosed in double quotes to handle special characters. Other supporting changes: - Add more documentation for terminal execution commands. - Refactor terminal script file execution into a dedicated file for improved separation of concerns. - Refactor naming of `RuntimeEnvironment` to align with naming conventions (no interface with I prefix) and for clarity. - Refactor `TemporaryFileCodeRunner` to simplify it by removing the `os` parameter and handling OS-specific logic within the filename generator instead. - Refactor `fileName` to `filename` for consistency.
204 lines
6.6 KiB
TypeScript
204 lines
6.6 KiB
TypeScript
// eslint-disable-next-line max-classes-per-file
|
|
import { describe, it, expect } from 'vitest';
|
|
import { BrowserOsDetector } from '@/infrastructure/RuntimeEnvironment/BrowserOs/BrowserOsDetector';
|
|
import { OperatingSystem } from '@/domain/OperatingSystem';
|
|
import { HostRuntimeEnvironment } from '@/infrastructure/RuntimeEnvironment/HostRuntimeEnvironment';
|
|
import { itEachAbsentObjectValue } from '@tests/unit/shared/TestCases/AbsentTests';
|
|
import { BrowserOsDetectorStub } from '@tests/unit/shared/Stubs/BrowserOsDetectorStub';
|
|
import { IEnvironmentVariables } from '@/infrastructure/EnvironmentVariables/IEnvironmentVariables';
|
|
import { EnvironmentVariablesStub } from '@tests/unit/shared/Stubs/EnvironmentVariablesStub';
|
|
import { expectExists } from '@tests/shared/Assertions/ExpectExists';
|
|
|
|
describe('HostRuntimeEnvironment', () => {
|
|
describe('ctor', () => {
|
|
describe('throws if window is absent', () => {
|
|
itEachAbsentObjectValue((absentValue) => {
|
|
// arrange
|
|
const expectedError = 'missing window';
|
|
const absentWindow = absentValue;
|
|
// act
|
|
const act = () => createEnvironment({
|
|
window: absentWindow as never,
|
|
});
|
|
// assert
|
|
expect(act).to.throw(expectedError);
|
|
});
|
|
});
|
|
it('uses browser OS detector with current touch support', () => {
|
|
// arrange
|
|
const expectedTouchSupport = true;
|
|
const osDetector = new BrowserOsDetectorStub();
|
|
// act
|
|
createEnvironment({
|
|
window: { os: undefined, navigator: { userAgent: 'Forcing touch detection' } } as Partial<Window>,
|
|
isTouchSupported: expectedTouchSupport,
|
|
browserOsDetector: osDetector,
|
|
});
|
|
// assert
|
|
const actualCall = osDetector.callHistory.find((c) => c.methodName === 'detect');
|
|
expectExists(actualCall);
|
|
const [{ isTouchSupported: actualTouchSupport }] = actualCall.args;
|
|
expect(actualTouchSupport).to.equal(expectedTouchSupport);
|
|
});
|
|
});
|
|
describe('isDesktop', () => {
|
|
it('returns true when window property isDesktop is true', () => {
|
|
// arrange
|
|
const desktopWindow = {
|
|
isDesktop: true,
|
|
};
|
|
// act
|
|
const sut = createEnvironment({
|
|
window: desktopWindow,
|
|
});
|
|
// assert
|
|
expect(sut.isDesktop).to.equal(true);
|
|
});
|
|
it('returns false when window property isDesktop is false', () => {
|
|
// arrange
|
|
const expectedValue = false;
|
|
const browserWindow = {
|
|
isDesktop: false,
|
|
};
|
|
// act
|
|
const sut = createEnvironment({
|
|
window: browserWindow,
|
|
});
|
|
// assert
|
|
expect(sut.isDesktop).to.equal(expectedValue);
|
|
});
|
|
});
|
|
describe('os', () => {
|
|
it('returns undefined if user agent is missing', () => {
|
|
// arrange
|
|
const expected = undefined;
|
|
const browserDetectorMock: BrowserOsDetector = {
|
|
detect: () => {
|
|
throw new Error('should not reach here');
|
|
},
|
|
};
|
|
const sut = createEnvironment({
|
|
browserOsDetector: browserDetectorMock,
|
|
});
|
|
// act
|
|
const actual = sut.os;
|
|
// assert
|
|
expect(actual).to.equal(expected);
|
|
});
|
|
it('gets browser os from BrowserOsDetector', () => {
|
|
// arrange
|
|
const givenUserAgent = 'testUserAgent';
|
|
const expected = OperatingSystem.macOS;
|
|
const windowWithUserAgent = {
|
|
navigator: {
|
|
userAgent: givenUserAgent,
|
|
},
|
|
};
|
|
const browserDetectorMock: BrowserOsDetector = {
|
|
detect: (environment) => {
|
|
if (environment.userAgent !== givenUserAgent) {
|
|
throw new Error('Unexpected user agent');
|
|
}
|
|
return expected;
|
|
},
|
|
};
|
|
// act
|
|
const sut = createEnvironment({
|
|
window: windowWithUserAgent as Partial<Window>,
|
|
browserOsDetector: browserDetectorMock,
|
|
});
|
|
const actual = sut.os;
|
|
// assert
|
|
expect(actual).to.equal(expected);
|
|
});
|
|
describe('desktop os', () => {
|
|
describe('returns from window property `os`', () => {
|
|
const testValues = [
|
|
OperatingSystem.macOS,
|
|
OperatingSystem.Windows,
|
|
OperatingSystem.Linux,
|
|
];
|
|
testValues.forEach((testValue) => {
|
|
it(`given ${OperatingSystem[testValue]}`, () => {
|
|
// arrange
|
|
const expectedOs = testValue;
|
|
const desktopWindowWithOs = {
|
|
isDesktop: true,
|
|
os: expectedOs,
|
|
};
|
|
// act
|
|
const sut = createEnvironment({
|
|
window: desktopWindowWithOs,
|
|
});
|
|
// assert
|
|
const actualOs = sut.os;
|
|
expect(actualOs).to.equal(expectedOs);
|
|
});
|
|
});
|
|
});
|
|
describe('returns undefined when window property `os` is absent', () => {
|
|
itEachAbsentObjectValue((absentValue) => {
|
|
// arrange
|
|
const expectedValue = undefined;
|
|
const windowWithAbsentOs = {
|
|
os: absentValue as never,
|
|
};
|
|
// act
|
|
const sut = createEnvironment({
|
|
window: windowWithAbsentOs,
|
|
});
|
|
// assert
|
|
expect(sut.os).to.equal(expectedValue);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
describe('isNonProduction', () => {
|
|
[true, false].forEach((value) => {
|
|
it(`sets ${value} from environment variables`, () => {
|
|
// arrange
|
|
const expectedValue = value;
|
|
const environment = new EnvironmentVariablesStub()
|
|
.withIsNonProduction(expectedValue);
|
|
// act
|
|
const sut = createEnvironment({
|
|
environmentVariables: environment,
|
|
});
|
|
// assert
|
|
const actualValue = sut.isNonProduction;
|
|
expect(actualValue).to.equal(expectedValue);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
interface EnvironmentOptions {
|
|
readonly window?: Partial<Window>;
|
|
readonly browserOsDetector?: BrowserOsDetector;
|
|
readonly environmentVariables?: IEnvironmentVariables;
|
|
readonly isTouchSupported?: boolean;
|
|
}
|
|
|
|
function createEnvironment(options: Partial<EnvironmentOptions> = {}): TestableRuntimeEnvironment {
|
|
const defaultOptions: Required<EnvironmentOptions> = {
|
|
window: {},
|
|
browserOsDetector: new BrowserOsDetectorStub(),
|
|
environmentVariables: new EnvironmentVariablesStub(),
|
|
isTouchSupported: false,
|
|
};
|
|
|
|
return new TestableRuntimeEnvironment({ ...defaultOptions, ...options });
|
|
}
|
|
|
|
class TestableRuntimeEnvironment extends HostRuntimeEnvironment {
|
|
/* Using a separate object instead of `ConstructorParameter<..>` */
|
|
public constructor(options: Required<EnvironmentOptions>) {
|
|
super(
|
|
options.window,
|
|
options.environmentVariables,
|
|
options.browserOsDetector,
|
|
() => options.isTouchSupported,
|
|
);
|
|
}
|
|
}
|