- Migrate from "Vue 2.X" to "Vue 3.X"
- Migrate from "Vue Test Utils v1" to "Vue Test Utils v2"
Changes in detail:
- Change `inserted` to `mounted`.
- Change `::v-deep` to `:deep`.
- Change to Vue 3.0 `v-modal` syntax.
- Remove old Vue 2.0 transition name, keep the ones for Vue 3.0.
- Use new global mounting API `createApp`.
- Change `destroy` to `unmount`.
- Bootstrapping:
- Move `provide`s for global dependencies to a bootsrapper from
`App.vue`.
- Remove `productionTip` setting (not in Vue 3).
- Change `IVueBootstrapper` for simplicity and Vue 3 compatible API.
- Add missing tests.
- Remove `.text` access on `VNode` as it's now internal API of Vue.
- Import `CSSProperties` from `vue` instead of `jsx` package.
- Shims:
- Remove unused `shims-tsx.d.ts`.
- Remove `shims-vue.d.ts` that's missing in quickstart template.
- Unit tests:
- Remove old typing workaround for mounting components.
- Rename `propsData` to `props`.
- Remove unneeded `any` cast workarounds.
- Move stubs and `provide`s under `global` object.
Other changes:
- Add `dmg-license` dependency explicitly due to failing electron builds
on macOS (electron-userland/electron-builder#6520,
electron-userland/electron-builder#6489). This was a side-effect of
updating dependencies for this commit.
217 lines
6.5 KiB
TypeScript
217 lines
6.5 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { shallowMount } from '@vue/test-utils';
|
|
import { nextTick } from 'vue';
|
|
import ModalContainer from '@/presentation/components/Shared/Modal/ModalContainer.vue';
|
|
|
|
const DOM_MODAL_CONTAINER_SELECTOR = '.modal-container';
|
|
const COMPONENT_MODAL_OVERLAY_NAME = 'ModalOverlay';
|
|
const COMPONENT_MODAL_CONTENT_NAME = 'ModalContent';
|
|
|
|
describe('ModalContainer.vue', () => {
|
|
describe('rendering based on model prop', () => {
|
|
it('does not render when model prop is absent or false', () => {
|
|
// arrange
|
|
const wrapper = mountComponent({ modelValue: false });
|
|
|
|
// act
|
|
const modalContainer = wrapper.find(DOM_MODAL_CONTAINER_SELECTOR);
|
|
|
|
// assert
|
|
expect(modalContainer.exists()).to.equal(false);
|
|
});
|
|
|
|
it('renders modal container when model prop is true', () => {
|
|
// arrange
|
|
const wrapper = mountComponent({ modelValue: true });
|
|
|
|
// act
|
|
const modalContainer = wrapper.find(DOM_MODAL_CONTAINER_SELECTOR);
|
|
|
|
// assert
|
|
expect(modalContainer.exists()).to.equal(true);
|
|
});
|
|
});
|
|
|
|
describe('modal open/close', () => {
|
|
it('renders the model when prop changes from false to true', async () => {
|
|
// arrange
|
|
const wrapper = mountComponent({ modelValue: false });
|
|
|
|
// act
|
|
await wrapper.setProps({ modelValue: true });
|
|
|
|
// assert
|
|
expect(wrapper.vm.isRendered).to.equal(true);
|
|
});
|
|
|
|
it('opens the model when prop changes from false to true', async () => {
|
|
// arrange
|
|
const wrapper = mountComponent({ modelValue: false });
|
|
|
|
// act
|
|
await wrapper.setProps({ modelValue: true });
|
|
await nextTick();
|
|
|
|
// assert
|
|
expect(wrapper.vm.isOpen).to.equal(true);
|
|
});
|
|
|
|
it('closes when model prop changes from true to false', async () => {
|
|
// arrange
|
|
const wrapper = mountComponent({ modelValue: true });
|
|
|
|
// act
|
|
await wrapper.setProps({ modelValue: false });
|
|
|
|
// assert
|
|
expect(wrapper.vm.isOpen).to.equal(false);
|
|
// isRendered will not be true directly due to transition
|
|
});
|
|
|
|
it('closes on pressing ESC key', async () => {
|
|
// arrange
|
|
const { triggerKeyUp, restore } = createWindowEventSpies();
|
|
const wrapper = mountComponent({ modelValue: true });
|
|
|
|
// act
|
|
const escapeEvent = new KeyboardEvent('keyup', { key: 'Escape' });
|
|
triggerKeyUp(escapeEvent);
|
|
await wrapper.vm.$nextTick();
|
|
|
|
// assert
|
|
expect(wrapper.emitted('update:modelValue')).to.deep.equal([[false]]);
|
|
restore();
|
|
});
|
|
|
|
it('emit false value after overlay and content transitions out and model prop is true', async () => {
|
|
// arrange
|
|
const wrapper = mountComponent({ modelValue: true });
|
|
const overlayMock = wrapper.findComponent({ name: COMPONENT_MODAL_OVERLAY_NAME });
|
|
const contentMock = wrapper.findComponent({ name: COMPONENT_MODAL_CONTENT_NAME });
|
|
|
|
// act
|
|
overlayMock.vm.$emit('transitionedOut');
|
|
contentMock.vm.$emit('transitionedOut');
|
|
await wrapper.vm.$nextTick();
|
|
|
|
// assert
|
|
expect(wrapper.emitted('update:modelValue')).to.deep.equal([[false]]);
|
|
});
|
|
});
|
|
|
|
it('renders provided slot content', () => {
|
|
// arrange
|
|
const expectedText = 'Slot content';
|
|
const slotContentClass = 'slot-content';
|
|
|
|
// act
|
|
const wrapper = mountComponent({
|
|
modelValue: true,
|
|
slotHtml: `<div class="${slotContentClass}">${expectedText}</div>`,
|
|
});
|
|
|
|
// assert
|
|
const slotWrapper = wrapper.find(`.${slotContentClass}`);
|
|
const slotText = slotWrapper.text();
|
|
expect(slotText).to.equal(expectedText);
|
|
});
|
|
|
|
describe('closeOnOutsideClick', () => {
|
|
it('does not close on overlay click if prop is false', async () => {
|
|
// arrange
|
|
const wrapper = mountComponent({ modelValue: true, closeOnOutsideClick: false });
|
|
|
|
// act
|
|
const overlayMock = wrapper.findComponent({ name: COMPONENT_MODAL_OVERLAY_NAME });
|
|
overlayMock.vm.$emit('click');
|
|
await wrapper.vm.$nextTick();
|
|
|
|
// assert
|
|
expect(wrapper.emitted('update:modelValue')).to.equal(undefined);
|
|
});
|
|
|
|
it('closes on overlay click if prop is true', async () => {
|
|
// arrange
|
|
const wrapper = mountComponent({ modelValue: true, closeOnOutsideClick: true });
|
|
|
|
// act
|
|
const overlayMock = wrapper.findComponent({ name: COMPONENT_MODAL_OVERLAY_NAME });
|
|
overlayMock.vm.$emit('click');
|
|
await wrapper.vm.$nextTick();
|
|
|
|
// assert
|
|
expect(wrapper.emitted('update:modelValue')).to.deep.equal([[false]]);
|
|
});
|
|
});
|
|
});
|
|
|
|
function mountComponent(options: {
|
|
readonly modelValue: boolean,
|
|
readonly closeOnOutsideClick?: boolean,
|
|
readonly slotHtml?: string,
|
|
readonly attachToDocument?: boolean,
|
|
}) {
|
|
return shallowMount(ModalContainer, {
|
|
props: {
|
|
modelValue: options.modelValue,
|
|
...(options.closeOnOutsideClick !== undefined ? {
|
|
closeOnOutsideClick: options.closeOnOutsideClick,
|
|
} : {}),
|
|
},
|
|
slots: options.slotHtml !== undefined ? { default: options.slotHtml } : undefined,
|
|
global: {
|
|
stubs: {
|
|
[COMPONENT_MODAL_OVERLAY_NAME]: {
|
|
name: COMPONENT_MODAL_OVERLAY_NAME,
|
|
template: '<div />',
|
|
},
|
|
[COMPONENT_MODAL_CONTENT_NAME]: {
|
|
name: COMPONENT_MODAL_CONTENT_NAME,
|
|
template: '<slot />',
|
|
},
|
|
},
|
|
},
|
|
});
|
|
}
|
|
|
|
function createWindowEventSpies() {
|
|
const originalAddEventListener = window.addEventListener;
|
|
const originalRemoveEventListener = window.removeEventListener;
|
|
|
|
let savedListener: EventListenerOrEventListenerObject | null = null;
|
|
|
|
window.addEventListener = (
|
|
type: string,
|
|
listener: EventListenerOrEventListenerObject,
|
|
options?: boolean | AddEventListenerOptions,
|
|
): void => {
|
|
if (type === 'keyup' && typeof listener === 'function') {
|
|
savedListener = listener;
|
|
}
|
|
originalAddEventListener.call(window, type, listener, options);
|
|
};
|
|
|
|
window.removeEventListener = (
|
|
type: string,
|
|
listener: EventListenerOrEventListenerObject,
|
|
options?: boolean | EventListenerOptions,
|
|
): void => {
|
|
if (type === 'keyup' && typeof listener === 'function') {
|
|
savedListener = null;
|
|
}
|
|
originalRemoveEventListener.call(window, type, listener, options);
|
|
};
|
|
|
|
return {
|
|
triggerKeyUp: (event: KeyboardEvent) => {
|
|
if (savedListener) {
|
|
(savedListener as EventListener)(event);
|
|
}
|
|
},
|
|
restore: () => {
|
|
window.addEventListener = originalAddEventListener;
|
|
window.removeEventListener = originalRemoveEventListener;
|
|
},
|
|
};
|
|
}
|