cb42f11b97
This commit introduces a batched debounce mechanism for managing user
selection state changes. It effectively reduces unnecessary processing
during rapid script checking, preventing multiple triggers for code
compilation and UI rendering.
Key improvements include:
- Enhanced performance, especially noticeable when selecting large
categories. This update resolves minor UI freezes experienced when
selecting categories with numerous scripts.
- Correction of a bug where the code area only highlighted the last
selected script when multiple scripts were chosen.
Other changes include:
- Timing functions:
- Create a `Timing` folder for `throttle` and the new
`batchedDebounce` functions.
- Move these functions to the application layer from the presentation
layer, reflecting their application-wide use.
- Refactor existing code for improved clarity, naming consistency, and
adherence to new naming conventions.
- Add missing unit tests.
- `UserSelection`:
- State modifications in `UserSelection` now utilize a singular object
inspired by the CQRS pattern, enabling batch updates and flexible
change configurations, thereby simplifying change management.
- Remove the `I` prefix from related interfaces to align with new coding
standards.
- Refactor related code for better testability in isolation with
dependency injection.
- Repository:
- Move repository abstractions to the application layer.
- Improve repository abstraction to combine `ReadonlyRepository` and
`MutableRepository` interfaces.
- E2E testing:
- Introduce E2E tests to validate the correct batch selection
behavior.
- Add a specialized data attribute in `TheCodeArea.vue` for improved
testability.
- Reorganize shared Cypress functions for a more idiomatic Cypress
approach.
- Improve test documentation with related information.
- `SelectedScript`:
- Create an abstraction for simplified testability.
- Introduce `SelectedScriptStub` in tests as a substitute for the
actual object.
57 lines
1.3 KiB
TypeScript
57 lines
1.3 KiB
TypeScript
import { BaseEntity } from '@/infrastructure/Entity/BaseEntity';
|
|
import { IScript } from '@/domain/IScript';
|
|
import { RecommendationLevel } from '@/domain/RecommendationLevel';
|
|
import { IScriptCode } from '@/domain/IScriptCode';
|
|
import { SelectedScriptStub } from './SelectedScriptStub';
|
|
|
|
export class ScriptStub extends BaseEntity<string> implements IScript {
|
|
public name = `name${this.id}`;
|
|
|
|
public code: IScriptCode = {
|
|
execute: `REM execute-code (${this.id})`,
|
|
revert: `REM revert-code (${this.id})`,
|
|
};
|
|
|
|
public readonly docs = new Array<string>();
|
|
|
|
public level? = RecommendationLevel.Standard;
|
|
|
|
constructor(public readonly id: string) {
|
|
super(id);
|
|
}
|
|
|
|
public canRevert(): boolean {
|
|
return Boolean(this.code.revert);
|
|
}
|
|
|
|
public withLevel(value: RecommendationLevel | undefined): this {
|
|
this.level = value;
|
|
return this;
|
|
}
|
|
|
|
public withCode(value: string): this {
|
|
this.code = {
|
|
execute: value,
|
|
revert: this.code.revert,
|
|
};
|
|
return this;
|
|
}
|
|
|
|
public withName(name: string): this {
|
|
this.name = name;
|
|
return this;
|
|
}
|
|
|
|
public withRevertCode(revertCode?: string): this {
|
|
this.code = {
|
|
execute: this.code.execute,
|
|
revert: revertCode,
|
|
};
|
|
return this;
|
|
}
|
|
|
|
public toSelectedScript(): SelectedScriptStub {
|
|
return new SelectedScriptStub(this);
|
|
}
|
|
}
|