Files

undergroundwires eb096d07e2 Fix memory leaks via auto-unsubscribing and DI

This commit simplifies event handling, providing a unified and robust
way to handle event lifecycling. This way, it fixes events not being
unsubscribed when state is changed.

Introduce a new function in `EventSubscriptionCollection` to remove
existing events and adding new events. This provides an easier to use
API, which leads to code that's easier to understand. It also prevents
potential bugs that may occur due to forgetting to call both functions.
It fixes `TheScriptsMenu` not unregistering events on state change.
Other improvements include:
  - Include a getter to get total amount of registered subcriptions.
    This helps in unit testing.
  - Have nullish checks to prevent potential errors further down the
    execution.
  - Use array instead of rest parameters to increase readability and
    simplify tests.

Ensure `SliderHandler` stops resizes on unmount, unsubscribing from all
events and resetting state to default.

Update `injectionKeys` to do imports as types to avoid circular
dependencies. Simplify importing `injectionKeys` to enable and strict
typings for iterating injection keys.

Add tests covering new behavior.

2023-09-01 18:14:25 +02:00

8.3 KiB

Raw Blame History

Presentation layer

The presentation layer handles UI concerns using Vue as JavaScript framework and Electron to provide desktop functionality.

It reflects the application state and allows user interactions to modify it. Components manage their own local UI state.

The presentation layer uses an event-driven architecture for bidirectional reactivity between the application state and UI. State change events flow bottom-up to trigger UI updates, while user events flow top-down through components, some ultimately modifying the application state.

📖 Refer to architecture.md (Layered Application) to read more about the layered architecture.

Structure

/src/ presentation/: Contains Vue and Electron code.
- bootstrapping/: Registers Vue components and plugins.
- components/: Contains Vue components and helpers.
  - Shared/: Contains shared Vue components and helpers.
    - Hooks: Hooks used by components through dependency injection.
- /public/: Contains static assets.
- assets/: Contains assets processed by Vite.
  - fonts/: Contains fonts.
  - styles/: Contains shared styles.
    - components/: Contains styles coupled to Vue components.
    - vendors-extensions/: Contains styles for third-party components.
    - main.scss: Main Sass file, imported by other components as single entrypoint.
- main.ts: Starts Vue app.
- electron/: Contains Electron code.
  - /main/ index.ts: Main entry for Electron, managing application windows and lifecycle events.
  - /preload/ index.ts: Script executed before the renderer, securing Node.js features for renderer use.
/vite.config.ts: Contains Vite configurations for building web application.
/electron.vite.config.ts: Contains Vite configurations for building desktop applications.
/postcss.config.cjs: Contains PostCSS configurations for Vite.

Visual design best-practices

Add visual clues for clickable items. It should be as clear as possible that they're interactable at first look without hovering. They should also have different visual state when hovering/touching on them that indicates that they are being clicked, which helps with accessibility.

Application data

Components (should) use UseApplication to reach the application domain to avoid parsing and compiling the application again.

Application.ts is an immutable domain model that represents application state. It includes:

available scripts, collections as defined in collection files,
package information as defined in package.json.

You can read more about how application layer provides application data to he presentation in application.md | Application data.

Application state

This project uses a singleton instance of the application state, making it available to all Vue components.

The decision to not use third-party state management libraries like vuex or pinia was made to promote code independence and enhance portability.

Stateful components can mutate and/or react to state changes (e.g., user selection, search queries) in the ApplicationContext. Vue components import CollectionState.ts to access both the application context and the state.

UseCollectionState.ts provides several functionalities including:

Singleton State Instance: It creates a singleton instance of the state, which is shared across the presentation layer. The singleton instance ensures that there's a single source of truth for the application's state.
State Change Callback and Lifecycle Management: It offers a mechanism to register callbacks, which will be invoked when the state initializes or mutates. It ensures that components unsubscribe from state events when they are no longer in use or when ApplicationContext switches the active collection.
State Access and Modification: It provides functions to read and mutate for accessing and modifying the state, encapsulating the details of these operations.
Event Subscription Lifecycle Management: Includes an events member that simplifies state subscription lifecycle events. This ensures that components unsubscribe from state events when they are no longer in use, or when ApplicationContext switches the active collection.

📖 Refer to architecture.md | Application State for an overview of event handling and application.md | Application State for an in-depth understanding of state management in the application layer.

Dependency injections

The presentation layer uses Vue's native dependency injection system to increase testability and decouple components.

To add a new dependency:

Define its symbol: Define an associated symbol for every dependency in injectionSymbols.ts. Symbols are grouped into:
- Singletons: Shared across components, instantiated once.
- Transients: Factories yielding a new instance on every access.
Provide the dependency: Modify the provideDependencies function to include the new dependency. App.vue calls this function within its setup() hook to register the dependencies.
Inject the dependency: Use Vue's inject method alongside the defined symbol to incorporate the dependency into components.
- For singletons, invoke the factory method: inject(symbolKey)().
- For transients, directly inject: inject(symbolKey).

Shared UI components

Shared UI components promote consistency and simplifies the creation of the front-end.

In order to maintain portability and easy maintainability, the preference is towards using homegrown components over third-party ones or comprehensive UI frameworks like Quasar.

Shared components include:

ModalDialog.vue is utilized for rendering modal windows.
TooltipWrapper.vue acts as a wrapper for rendering tooltips.

Desktop builds

Desktop builds uses electron-vite to bundle the code, and electron-builder to build and publish the packages.

Sass naming convention

Use lowercase for variables/functions/mixins, e.g.:
- Variable: $variable: value;
- Function: @function function() {}
- Mixin: @mixin mixin() {}
Use - for a phrase/compound word, e.g.:
- Variable: $some-variable: value;
- Function: @function some-function() {}
- Mixin: @mixin some-mixin() {}
Grouping and name variables from generic to specific, e.g.:
- ✅ $border-blue, $border-blue-light, $border-blue-lightest, $border-red
- ❌ $blue-border, $light-blue-border, $lightest-blue-border, $red-border

8.3 KiB Raw Blame History