This commit unifies the concepts of executables having same ID structure. It paves the way for more complex ID structure and using IDs in collection files as part of new ID solution (#262). Using string IDs also leads to more expressive test code. This commit also refactors the rest of the code to adopt to the changes. This commit: - Separate concerns from entities for data access (in repositories) and executables. Executables use `Identifiable` meanwhile repositories use `RepositoryEntity`. - Refactor unnecessary generic parameters for enttities and ids, enforcing string gtype everwyhere. - Changes numeric IDs to string IDs for categories to unify the retrieval and construction for executables, using pseudo-ids (their names) just like scripts. - Remove `BaseEntity` for simplicity. - Simplify usage and construction of executable objects. Move factories responsible for creation of category/scripts to domain layer. Do not longer export `CollectionCategorY` and `CollectionScript`. - Use named typed for string IDs for better differentation of different ID contexts in code.
112 lines
4.3 KiB
TypeScript
112 lines
4.3 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { Application } from '@/domain/Application';
|
|
import { OperatingSystem } from '@/domain/OperatingSystem';
|
|
import { CategoryCollectionStub } from '@tests/unit/shared/Stubs/CategoryCollectionStub';
|
|
import { ProjectDetailsStub } from '@tests/unit/shared/Stubs/ProjectDetailsStub';
|
|
import type { ICategoryCollection } from '@/domain/Collection/ICategoryCollection';
|
|
import { getAbsentCollectionTestCases } from '@tests/unit/shared/TestCases/AbsentTests';
|
|
|
|
describe('Application', () => {
|
|
describe('getCollection', () => {
|
|
it('throws if not found', () => {
|
|
// arrange
|
|
const missingOs = OperatingSystem.Android;
|
|
const expectedError = `Operating system "${OperatingSystem[missingOs]}" is not defined in application`;
|
|
const projectDetails = new ProjectDetailsStub();
|
|
const collections = [new CategoryCollectionStub().withOs(OperatingSystem.Windows)];
|
|
// act
|
|
const sut = new Application(projectDetails, collections);
|
|
const act = () => sut.getCollection(missingOs);
|
|
// assert
|
|
expect(act).to.throw(expectedError);
|
|
});
|
|
it('returns expected when multiple collections exist', () => {
|
|
// arrange
|
|
const os = OperatingSystem.Windows;
|
|
const expected = new CategoryCollectionStub().withOs(os);
|
|
const projectDetails = new ProjectDetailsStub();
|
|
const collections = [expected, new CategoryCollectionStub().withOs(OperatingSystem.Android)];
|
|
// act
|
|
const sut = new Application(projectDetails, collections);
|
|
const actual = sut.getCollection(os);
|
|
// assert
|
|
expect(actual).to.equals(expected);
|
|
});
|
|
});
|
|
describe('ctor', () => {
|
|
describe('projectDetails', () => {
|
|
it('sets as expected', () => {
|
|
// arrange
|
|
const expectedProjectDetails = new ProjectDetailsStub();
|
|
const collections = [new CategoryCollectionStub()];
|
|
// act
|
|
const sut = new Application(expectedProjectDetails, collections);
|
|
// assert
|
|
expect(sut.projectDetails).to.equal(expectedProjectDetails);
|
|
});
|
|
});
|
|
describe('collections', () => {
|
|
describe('throws on invalid value', () => {
|
|
// arrange
|
|
const testCases: readonly {
|
|
readonly name: string,
|
|
readonly expectedError: string,
|
|
readonly value: readonly ICategoryCollection[],
|
|
}[] = [
|
|
...getAbsentCollectionTestCases<ICategoryCollection>(
|
|
{
|
|
excludeUndefined: true,
|
|
excludeNull: true,
|
|
},
|
|
).map((testCase) => ({
|
|
name: `empty collection: ${testCase.valueName}`,
|
|
expectedError: 'missing collections',
|
|
value: testCase.absentValue,
|
|
})),
|
|
{
|
|
name: 'two collections with same OS',
|
|
expectedError: 'multiple collections with same os: windows',
|
|
value: [
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Windows),
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Windows),
|
|
new CategoryCollectionStub().withOs(OperatingSystem.BlackBerry10),
|
|
],
|
|
},
|
|
];
|
|
for (const testCase of testCases) {
|
|
it(testCase.name, () => {
|
|
const projectDetails = new ProjectDetailsStub();
|
|
const collections = testCase.value;
|
|
// act
|
|
const act = () => new Application(projectDetails, collections);
|
|
// assert
|
|
expect(act).to.throw(testCase.expectedError);
|
|
});
|
|
}
|
|
});
|
|
it('sets as expected', () => {
|
|
// arrange
|
|
const projectDetails = new ProjectDetailsStub();
|
|
const expected = [new CategoryCollectionStub()];
|
|
// act
|
|
const sut = new Application(projectDetails, expected);
|
|
// assert
|
|
expect(sut.collections).to.equal(expected);
|
|
});
|
|
});
|
|
});
|
|
describe('getSupportedOsList', () => {
|
|
it('returns expected', () => {
|
|
// arrange
|
|
const expected = [OperatingSystem.Windows, OperatingSystem.macOS];
|
|
const projectDetails = new ProjectDetailsStub();
|
|
const collections = expected.map((os) => new CategoryCollectionStub().withOs(os));
|
|
// act
|
|
const sut = new Application(projectDetails, collections);
|
|
const actual = sut.getSupportedOsList();
|
|
// assert
|
|
expect(actual).to.deep.equal(expected);
|
|
});
|
|
});
|
|
});
|