Files
privacy.sexy/tests/unit/domain/ProjectInformation.spec.ts
undergroundwires 949fac1a7c Refactor to enforce strictNullChecks
This commit applies `strictNullChecks` to the entire codebase to improve
maintainability and type safety. Key changes include:

- Remove some explicit null-checks where unnecessary.
- Add necessary null-checks.
- Refactor static factory functions for a more functional approach.
- Improve some test names and contexts for better debugging.
- Add unit tests for any additional logic introduced.
- Refactor `createPositionFromRegexFullMatch` to its own function as the
  logic is reused.
- Prefer `find` prefix on functions that may return `undefined` and
  `get` prefix for those that always return a value.
2023-11-12 22:54:00 +01:00

222 lines
8.0 KiB
TypeScript

import { describe, it, expect } from 'vitest';
import { ProjectInformation } from '@/domain/ProjectInformation';
import { OperatingSystem } from '@/domain/OperatingSystem';
import { EnumRangeTestRunner } from '@tests/unit/application/Common/EnumRangeTestRunner';
import { VersionStub } from '@tests/unit/shared/Stubs/VersionStub';
import { Version } from '@/domain/Version';
import { PropertyKeys } from '@/TypeHelpers';
describe('ProjectInformation', () => {
describe('retrieval of property values', () => {
interface IInformationParsingTestCase {
readonly description?: string;
readonly expectedValue: string;
readonly buildWithExpectedValue: (
builder: ProjectInformationBuilder,
expected: string,
) => ProjectInformationBuilder;
readonly getActualValue: (sut: ProjectInformation) => string;
}
const propertyTestCases: {
readonly [K in PropertyKeys<ProjectInformation>]: readonly IInformationParsingTestCase[];
} = {
name: [{
expectedValue: 'expected-app-name',
buildWithExpectedValue: (builder, expected) => builder
.withName(expected),
getActualValue: (sut) => sut.name,
}],
version: [{
expectedValue: '0.11.3',
buildWithExpectedValue: (builder, expected) => builder
.withVersion(new VersionStub(expected)),
getActualValue: (sut) => sut.version.toString(),
}],
slogan: [{
expectedValue: 'expected-slogan',
buildWithExpectedValue: (builder, expected) => builder
.withSlogan(expected),
getActualValue: (sut) => sut.slogan,
}],
repositoryUrl: [{
description: 'without `.git` suffix',
expectedValue: 'expected-repository-url',
buildWithExpectedValue: (builder, expected) => builder
.withRepositoryUrl(expected),
getActualValue: (sut) => sut.repositoryUrl,
}, {
description: 'with `.git` suffix',
expectedValue: 'expected-repository-url',
buildWithExpectedValue: (builder, expected) => builder
.withRepositoryUrl(expected),
getActualValue: (sut) => sut.repositoryUrl,
}],
repositoryWebUrl: [{
description: 'without `.git` suffix',
expectedValue: 'expected-repository-url',
buildWithExpectedValue: (builder, expected) => builder
.withRepositoryUrl(expected),
getActualValue: (sut) => sut.repositoryWebUrl,
}, {
description: 'with `.git` suffix',
expectedValue: 'expected-repository-url',
buildWithExpectedValue: (builder, expected) => builder
.withRepositoryUrl(`${expected}.git`),
getActualValue: (sut) => sut.repositoryWebUrl,
}],
homepage: [{
expectedValue: 'expected-homepage',
buildWithExpectedValue: (builder, expected) => builder
.withHomepage(expected),
getActualValue: (sut) => sut.homepage,
}],
feedbackUrl: [{
description: 'without `.git` suffix',
expectedValue: 'https://github.com/undergroundwires/privacy.sexy/issues',
buildWithExpectedValue: (builder) => builder
.withRepositoryUrl('https://github.com/undergroundwires/privacy.sexy'),
getActualValue: (sut) => sut.feedbackUrl,
}, {
description: 'with `.git` suffix',
expectedValue: 'https://github.com/undergroundwires/privacy.sexy/issues',
buildWithExpectedValue: (builder) => builder
.withRepositoryUrl('https://github.com/undergroundwires/privacy.sexy.git'),
getActualValue: (sut) => sut.feedbackUrl,
}],
releaseUrl: [{
description: 'without `.git` suffix',
expectedValue: 'https://github.com/undergroundwires/privacy.sexy/releases/tag/0.7.2',
buildWithExpectedValue: (builder) => builder
.withRepositoryUrl('https://github.com/undergroundwires/privacy.sexy')
.withVersion(new VersionStub('0.7.2')),
getActualValue: (sut) => sut.releaseUrl,
}, {
description: 'with `.git` suffix',
expectedValue: 'https://github.com/undergroundwires/privacy.sexy/releases/tag/0.7.2',
buildWithExpectedValue: (builder) => builder
.withRepositoryUrl('https://github.com/undergroundwires/privacy.sexy.git')
.withVersion(new VersionStub('0.7.2')),
getActualValue: (sut) => sut.releaseUrl,
}],
};
Object.entries(propertyTestCases).forEach(([propertyName, testList]) => {
testList.forEach(({
description, buildWithExpectedValue, expectedValue, getActualValue,
}) => {
it(`${propertyName}${description ? ` (${description})` : ''}`, () => {
// arrange
const builder = new ProjectInformationBuilder();
const sut = buildWithExpectedValue(builder, expectedValue).build();
// act
const actual = getActualValue(sut);
// assert
expect(actual).to.equal(expectedValue);
});
});
});
});
describe('correct retrieval of download URL per operating system', () => {
const testCases: ReadonlyArray<{
readonly os: OperatingSystem,
readonly expected: string,
readonly repositoryUrl: string,
readonly version: string,
}> = [
{
os: OperatingSystem.macOS,
expected: 'https://github.com/undergroundwires/privacy.sexy/releases/download/0.7.2/privacy.sexy-0.7.2.dmg',
repositoryUrl: 'https://github.com/undergroundwires/privacy.sexy.git',
version: '0.7.2',
},
{
os: OperatingSystem.Linux,
expected: 'https://github.com/undergroundwires/privacy.sexy/releases/download/0.7.2/privacy.sexy-0.7.2.AppImage',
repositoryUrl: 'https://github.com/undergroundwires/privacy.sexy.git',
version: '0.7.2',
},
{
os: OperatingSystem.Windows,
expected: 'https://github.com/undergroundwires/privacy.sexy/releases/download/0.7.2/privacy.sexy-Setup-0.7.2.exe',
repositoryUrl: 'https://github.com/undergroundwires/privacy.sexy.git',
version: '0.7.2',
},
];
for (const testCase of testCases) {
it(`should return the expected download URL for ${OperatingSystem[testCase.os]}`, () => {
// arrange
const {
expected, version, repositoryUrl, os,
} = testCase;
const sut = new ProjectInformationBuilder()
.withVersion(new VersionStub(version))
.withRepositoryUrl(repositoryUrl)
.build();
// act
const actual = sut.getDownloadUrl(os);
// assert
expect(actual).to.equal(expected);
});
}
describe('should throw an error when provided with an invalid operating system', () => {
// arrange
const sut = new ProjectInformationBuilder()
.build();
// act
const act = (os: OperatingSystem) => sut.getDownloadUrl(os);
// assert
new EnumRangeTestRunner(act)
.testOutOfRangeThrows()
.testInvalidValueThrows(OperatingSystem.KaiOS, `Unsupported os: ${OperatingSystem[OperatingSystem.KaiOS]}`);
});
});
});
class ProjectInformationBuilder {
private name = 'default-name';
private version: Version = new VersionStub();
private repositoryUrl = 'default-repository-url';
private homepage = 'default-homepage';
private slogan = 'default-slogan';
public withName(name: string): ProjectInformationBuilder {
this.name = name;
return this;
}
public withVersion(version: VersionStub): ProjectInformationBuilder {
this.version = version;
return this;
}
public withSlogan(slogan: string): ProjectInformationBuilder {
this.slogan = slogan;
return this;
}
public withRepositoryUrl(repositoryUrl: string): ProjectInformationBuilder {
this.repositoryUrl = repositoryUrl;
return this;
}
public withHomepage(homepage: string): ProjectInformationBuilder {
this.homepage = homepage;
return this;
}
public build(): ProjectInformation {
return new ProjectInformation(
this.name,
this.version,
this.slogan,
this.repositoryUrl,
this.homepage,
);
}
}