This commit introduces native operating system file dialogs in the desktop application replacing the existing web-based dialogs. It lays the foundation for future enhancements such as: - Providing error messages when saving or executing files, addressing #264. - Creating system restore points, addressing #50. Documentation updates: - Update `desktop-vs-web-features.md` with added functionality. - Update `README.md` with security feature highlights. - Update home page documentation to emphasize security features. Other supporting changes include: - Integrate IPC communication channels for secure Electron dialog API interactions. - Refactor `IpcRegistration` for more type-safety and simplicity. - Introduce a Vue hook to encapsulate dialog functionality. - Improve errors during IPC registration for easier troubleshooting. - Move `ClientLoggerFactory` for consistency in hooks organization and remove `LoggerFactory` interface for simplicity. - Add tests for the save file dialog in the browser context. - Add `Blob` polyfill in tests to compensate for the missing `blob.text()` function in `jsdom` (see jsdom/jsdom#2555). Improve environment detection logic: - Treat test environment as browser environments to correctly activate features based on the environment. This resolves issues where the environment is misidentified as desktop, but Electron preloader APIs are missing. - Rename `isDesktop` environment identification variable to `isRunningAsDesktopApplication` for better clarity and to avoid confusion with desktop environments in web/browser/test environments. - Simplify `BrowserRuntimeEnvironment` to consistently detect non-desktop application environments. - Improve environment detection for Electron main process (electron/electron#2288).
119 lines
4.1 KiB
TypeScript
119 lines
4.1 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { ApiFacadeFactory, IpcConsumerProxyCreator, provideWindowVariables } from '@/presentation/electron/preload/ContextBridging/RendererApiProvider';
|
|
import { OperatingSystem } from '@/domain/OperatingSystem';
|
|
import { Logger } from '@/application/Common/Log/Logger';
|
|
import { LoggerStub } from '@tests/unit/shared/Stubs/LoggerStub';
|
|
import { PropertyKeys } from '@/TypeHelpers';
|
|
import { WindowVariables } from '@/infrastructure/WindowVariables/WindowVariables';
|
|
import { IpcChannelDefinitions } from '@/presentation/electron/shared/IpcBridging/IpcChannelDefinitions';
|
|
import { IpcChannel } from '@/presentation/electron/shared/IpcBridging/IpcChannel';
|
|
|
|
describe('RendererApiProvider', () => {
|
|
describe('provideWindowVariables', () => {
|
|
interface WindowVariableTestCase {
|
|
readonly description: string;
|
|
setupContext(context: RendererApiProviderTestContext): RendererApiProviderTestContext;
|
|
readonly expectedValue: unknown;
|
|
}
|
|
const testScenarios: Record<PropertyKeys<Required<WindowVariables>>, WindowVariableTestCase> = {
|
|
isRunningAsDesktopApplication: {
|
|
description: 'returns true',
|
|
setupContext: (context) => context,
|
|
expectedValue: true,
|
|
},
|
|
codeRunner: expectIpcConsumer(IpcChannelDefinitions.CodeRunner),
|
|
os: (() => {
|
|
const operatingSystem = OperatingSystem.WindowsPhone;
|
|
return {
|
|
description: 'returns expected',
|
|
setupContext: (context) => context.withOs(operatingSystem),
|
|
expectedValue: operatingSystem,
|
|
};
|
|
})(),
|
|
log: expectFacade({
|
|
instance: new LoggerStub(),
|
|
setupContext: (c, logger) => c.withLogger(logger),
|
|
}),
|
|
dialog: expectIpcConsumer(IpcChannelDefinitions.Dialog),
|
|
};
|
|
Object.entries(testScenarios).forEach((
|
|
[property, { description, setupContext, expectedValue }],
|
|
) => {
|
|
it(`${property}: ${description}`, () => {
|
|
// arrange
|
|
const testContext = setupContext(new RendererApiProviderTestContext());
|
|
// act
|
|
const variables = testContext.provideWindowVariables();
|
|
// assert
|
|
const actualValue = variables[property];
|
|
expect(actualValue).to.equal(expectedValue);
|
|
});
|
|
});
|
|
function expectIpcConsumer<T>(expectedDefinition: IpcChannel<T>): WindowVariableTestCase {
|
|
const ipcConsumerCreator: IpcConsumerProxyCreator = (definition) => definition as never;
|
|
return {
|
|
description: 'creates correct IPC consumer',
|
|
setupContext: (context) => context
|
|
.withIpcConsumerCreator(ipcConsumerCreator),
|
|
expectedValue: expectedDefinition,
|
|
};
|
|
}
|
|
function expectFacade<T>(options: {
|
|
readonly instance: T;
|
|
setupContext: (
|
|
context: RendererApiProviderTestContext,
|
|
instance: T,
|
|
) => RendererApiProviderTestContext;
|
|
}): WindowVariableTestCase {
|
|
const createFacadeMock: ApiFacadeFactory = (obj) => obj;
|
|
return {
|
|
description: 'creates correct facade',
|
|
setupContext: (context) => options.setupContext(
|
|
context.withApiFacadeCreator(createFacadeMock),
|
|
options.instance,
|
|
),
|
|
expectedValue: options.instance,
|
|
};
|
|
}
|
|
});
|
|
});
|
|
|
|
class RendererApiProviderTestContext {
|
|
private os: OperatingSystem = OperatingSystem.Android;
|
|
|
|
private log: Logger = new LoggerStub();
|
|
|
|
private apiFacadeCreator: ApiFacadeFactory = (obj) => obj;
|
|
|
|
private ipcConsumerCreator: IpcConsumerProxyCreator = () => { return {} as never; };
|
|
|
|
public withOs(os: OperatingSystem): this {
|
|
this.os = os;
|
|
return this;
|
|
}
|
|
|
|
public withLogger(log: Logger): this {
|
|
this.log = log;
|
|
return this;
|
|
}
|
|
|
|
public withApiFacadeCreator(apiFacadeCreator: ApiFacadeFactory): this {
|
|
this.apiFacadeCreator = apiFacadeCreator;
|
|
return this;
|
|
}
|
|
|
|
public withIpcConsumerCreator(ipcConsumerCreator: IpcConsumerProxyCreator): this {
|
|
this.ipcConsumerCreator = ipcConsumerCreator;
|
|
return this;
|
|
}
|
|
|
|
public provideWindowVariables() {
|
|
return provideWindowVariables(
|
|
() => this.log,
|
|
() => this.os,
|
|
this.apiFacadeCreator,
|
|
this.ipcConsumerCreator,
|
|
);
|
|
}
|
|
}
|