e17744faf0
This commit upgrades TypeScript from 5.4 to 5.5 and enables the
`noImplicitAny` option for stricter type checking. It refactors code to
comply with `noImplicitAny` and adapts to new TypeScript features and
limitations.
Key changes:
- Migrate from TypeScript 5.4 to 5.5
- Enable `noImplicitAny` for stricter type checking
- Refactor code to comply with new TypeScript features and limitations
Other supporting changes:
- Refactor progress bar handling for type safety
- Drop 'I' prefix from interfaces to align with new code convention
- Update TypeScript target from `ES2017` and `ES2018`.
This allows named capturing groups. Otherwise, new TypeScript compiler
does not compile the project and shows the following error:
```
...
TimestampedFilenameGenerator.spec.ts:105:23 - error TS1503: Named capturing groups are only available when targeting 'ES2018' or later
const pattern = /^(?<timestamp>\d{4}-\d{2}-\d{2}_\d{2}-\d{2}-\d{2})-(?<scriptName>[^.]+?)(?:\.(?<extension>[^.]+))?$/;// timestamp-scriptName.extension
...
```
- Refactor usage of `electron-progressbar` for type safety and
less complexity.
58 lines
2.1 KiB
TypeScript
58 lines
2.1 KiB
TypeScript
import type { PropertyKeys } from '@/TypeHelpers';
|
|
import type { FactoryFunction, FactoryValidator } from '@/infrastructure/RuntimeSanity/Common/FactoryValidator';
|
|
import type { SanityCheckOptions } from '@/infrastructure/RuntimeSanity/Common/SanityCheckOptions';
|
|
import { SanityCheckOptionsStub } from '@tests/unit/shared/Stubs/SanityCheckOptionsStub';
|
|
|
|
interface TestOptions<T> {
|
|
readonly createValidator: (factory?: FactoryFunction<T>) => FactoryValidator<T>;
|
|
readonly enablingOptionProperty: PropertyKeys<SanityCheckOptions>;
|
|
readonly factoryFunctionStub: FactoryFunction<T>;
|
|
readonly expectedValidatorName: string;
|
|
}
|
|
|
|
export function runFactoryValidatorTests<T>(
|
|
testOptions: TestOptions<T>,
|
|
) {
|
|
describe('shouldValidate', () => {
|
|
it('returns true when option is true', () => {
|
|
// arrange
|
|
const expectedValue = true;
|
|
const options: SanityCheckOptions = {
|
|
...new SanityCheckOptionsStub(),
|
|
[testOptions.enablingOptionProperty]: true,
|
|
};
|
|
const validatorUnderTest = testOptions.createValidator(testOptions.factoryFunctionStub);
|
|
// act
|
|
const actualValue = validatorUnderTest.shouldValidate(options);
|
|
// assert
|
|
expect(actualValue).to.equal(expectedValue);
|
|
});
|
|
|
|
it('returns false when option is false', () => {
|
|
// arrange
|
|
const expectedValue = false;
|
|
const options: SanityCheckOptions = {
|
|
...new SanityCheckOptionsStub(),
|
|
[testOptions.enablingOptionProperty]: false,
|
|
};
|
|
const validatorUnderTest = testOptions.createValidator(testOptions.factoryFunctionStub);
|
|
// act
|
|
const actualValue = validatorUnderTest.shouldValidate(options);
|
|
// assert
|
|
expect(actualValue).to.equal(expectedValue);
|
|
});
|
|
});
|
|
|
|
describe('name', () => {
|
|
it('returns as expected', () => {
|
|
// arrange
|
|
const expectedName = testOptions.expectedValidatorName;
|
|
// act
|
|
const validatorUnderTest = testOptions.createValidator(testOptions.factoryFunctionStub);
|
|
// assert
|
|
const actualName = validatorUnderTest.name;
|
|
expect(actualName).to.equal(expectedName);
|
|
});
|
|
});
|
|
}
|