e09db0f1bd
This commit introduces system-native error dialogs on desktop application for code save or execution failures, addressing user confusion described in issue #264. This commit adds informative feedback when script execution or saving fails. Changes: - Implement support for system-native error dialogs. - Refactor `CodeRunner` and `Dialog` interfaces and their implementations to improve error handling and provide better type safety. - Introduce structured error handling, allowing UI to display detailed error messages. - Replace error throwing with an error object interface for controlled handling. This ensures that errors are propagated to the renderer process without being limited by Electron's error object serialization limitations as detailed in electron/electron#24427. - Add logging for dialog actions to aid in troubleshooting. - Rename `fileName` to `defaultFilename` in `saveFile` functions to clarify its purpose. - Centralize message assertion in `LoggerStub` for consistency. - Introduce `expectTrue` in tests for clearer boolean assertions. - Standardize `filename` usage across the codebase. - Enhance existing test names and organization for clarity. - Update related documentation.
43 lines
1.6 KiB
TypeScript
43 lines
1.6 KiB
TypeScript
import fileSaver from 'file-saver';
|
|
import { FileType, SaveFileOutcome } from '@/presentation/common/Dialog';
|
|
import { BrowserSaveFileDialog } from './BrowserSaveFileDialog';
|
|
|
|
export type SaveAsFunction = (data: Blob, filename?: string) => void;
|
|
|
|
export type WindowOpenFunction = (url: string, target: string, features: string) => void;
|
|
|
|
export class FileSaverDialog implements BrowserSaveFileDialog {
|
|
constructor(
|
|
private readonly fileSaverSaveAs: SaveAsFunction = fileSaver.saveAs,
|
|
private readonly windowOpen: WindowOpenFunction = window.open.bind(window),
|
|
) { }
|
|
|
|
public saveFile(
|
|
fileContents: string,
|
|
defaultFilename: string,
|
|
fileType: FileType,
|
|
): SaveFileOutcome {
|
|
const mimeType = MimeTypes[fileType];
|
|
this.saveBlob(fileContents, mimeType, defaultFilename);
|
|
return {
|
|
success: true, // Exceptions are handled internally
|
|
};
|
|
}
|
|
|
|
private saveBlob(file: BlobPart, mimeType: string, defaultFilename: string): void {
|
|
try {
|
|
const blob = new Blob([file], { type: mimeType });
|
|
this.fileSaverSaveAs(blob, defaultFilename);
|
|
} catch (e) {
|
|
this.windowOpen(`data:${mimeType},${encodeURIComponent(file.toString())}`, '_blank', '');
|
|
}
|
|
}
|
|
}
|
|
|
|
const MimeTypes: Record<FileType, string> = {
|
|
// Some browsers (including firefox + IE) require right mime type
|
|
// otherwise they ignore extension and save the file as text.
|
|
[FileType.BatchFile]: 'application/bat', // https://en.wikipedia.org/wiki/Batch_file
|
|
[FileType.ShellScript]: 'text/x-shellscript', // https://de.wikipedia.org/wiki/Shellskript#MIME-Typ
|
|
} as const;
|