This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
47 lines
1.3 KiB
TypeScript
47 lines
1.3 KiB
TypeScript
import { it, expect } from 'vitest';
|
|
import { EnumType } from '@/application/Common/Enum';
|
|
|
|
export class EnumRangeTestRunner<TEnumValue extends EnumType> {
|
|
constructor(private readonly runner: (value: TEnumValue) => void) {
|
|
}
|
|
|
|
public testOutOfRangeThrows(errorMessageBuilder?: (outOfRangeValue: TEnumValue) => string) {
|
|
it('throws when value is out of range', () => {
|
|
// arrange
|
|
const value = Number.MAX_SAFE_INTEGER as TEnumValue;
|
|
const expectedError = errorMessageBuilder
|
|
? errorMessageBuilder(value)
|
|
: `enum value "${value}" is out of range`;
|
|
// act
|
|
const act = () => this.runner(value);
|
|
// assert
|
|
expect(act).to.throw(expectedError);
|
|
});
|
|
return this;
|
|
}
|
|
|
|
public testInvalidValueThrows(invalidValue: TEnumValue, expectedError: string) {
|
|
it(`throws: \`${expectedError}\``, () => {
|
|
// arrange
|
|
const value = invalidValue;
|
|
// act
|
|
const act = () => this.runner(value);
|
|
// assert
|
|
expect(act).to.throw(expectedError);
|
|
});
|
|
return this;
|
|
}
|
|
|
|
public testValidValueDoesNotThrow(validValue: TEnumValue) {
|
|
it('does not throw with valid value', () => {
|
|
// arrange
|
|
const value = validValue;
|
|
// act
|
|
const act = () => this.runner(value);
|
|
// assert
|
|
expect(act).to.not.throw();
|
|
});
|
|
return this;
|
|
}
|
|
}
|