c84a1bb74c
This commit fixes an issue seen on certain Windows environments (Windows 10 22H2 and 11 23H2 Pro Azure VMs) where scripts were being deleted during execution due to temporary directory usage. To resolve this, scripts are now stored in a persistent directory, enhancing reliability for long-running scripts and improving auditability along with troubleshooting. Key changes: - Move script execution logic to the `main` process from `preloader` to utilize Electron's `app.getPath`. - Improve runtime environment detection for non-browser environments to allow its usage in Electron main process. - Introduce a secure module to expose IPC channels from the main process to the renderer via the preloader process. Supporting refactorings include: - Simplify `CodeRunner` interface by removing the `tempScriptFolderName` parameter. - Rename `NodeSystemOperations` to `NodeElectronSystemOperations` as it now wraps electron APIs too, and convert it to class for simplicity. - Rename `TemporaryFileCodeRunner` to `ScriptFileCodeRunner` to reflect its new functinoality. - Rename `SystemOperations` folder to `System` for simplicity. - Rename `HostRuntimeEnvironment` to `BrowserRuntimeEnvironment` for clarity. - Refactor main Electron process configuration to align with latest Electron documentation/recommendations. - Refactor unit tests `BrowserRuntimeEnvironment` to simplify singleton workaround. - Use alias imports like `electron/main` and `electron/common` for better clarity.
48 lines
1.6 KiB
TypeScript
48 lines
1.6 KiB
TypeScript
import { OperatingSystem } from '@/domain/OperatingSystem';
|
|
import { RuntimeEnvironment } from '@/infrastructure/RuntimeEnvironment/RuntimeEnvironment';
|
|
import { CurrentEnvironment } from '@/infrastructure/RuntimeEnvironment/RuntimeEnvironmentFactory';
|
|
import { FilenameGenerator } from './FilenameGenerator';
|
|
|
|
/**
|
|
* Generates a timestamped filename specific to the given operating system.
|
|
*
|
|
* The filename includes:
|
|
* - A timestamp for uniqueness and easier auditability.
|
|
* - File extension based on the operating system.
|
|
*/
|
|
export class OsTimestampedFilenameGenerator implements FilenameGenerator {
|
|
private readonly currentOs?: OperatingSystem;
|
|
|
|
constructor(
|
|
environment: RuntimeEnvironment = CurrentEnvironment,
|
|
) {
|
|
this.currentOs = environment.os;
|
|
}
|
|
|
|
public generateFilename(
|
|
date = new Date(),
|
|
): string {
|
|
const baseFileName = `run-${createTimeStampForFile(date)}`;
|
|
const extension = this.currentOs === undefined ? undefined : FileExtensions[this.currentOs];
|
|
return extension ? `${baseFileName}.${extension}` : baseFileName;
|
|
}
|
|
}
|
|
|
|
const FileExtensions: Partial<Record<OperatingSystem, string>> = {
|
|
// '.bat' for Windows batch files; required for executability.
|
|
[OperatingSystem.Windows]: 'bat',
|
|
|
|
// '.sh' for Unix-like systems; enhances recognition as a shell script
|
|
[OperatingSystem.macOS]: 'sh',
|
|
[OperatingSystem.Linux]: 'sh',
|
|
};
|
|
|
|
/** Generates a timestamp for the filename in 'YYYY-MM-DD_HH-MM-SS' format. */
|
|
function createTimeStampForFile(date: Date): string {
|
|
return date
|
|
.toISOString()
|
|
.replace(/T/, '_')
|
|
.replace(/:/g, '-')
|
|
.replace(/\..+/, '');
|
|
}
|