e8199932b4
Rework code validation to be bound to a context and not context-independent. It means that the generated code is validated based on different phases during the compilation. This is done by moving validation from `ScriptCode` constructor to a different callable function. It removes duplicate detection for function calls once a call is fully compiled, but still checks for duplicates inside each function body that has inline code. This allows for having duplicates in final scripts (thus relaxing the duplicate detection), e.g., when multiple calls to the same function is made. It fixes non-duplicates (when using common syntax) being misrepresented as duplicate lines. It improves the output of errors, such as printing valid lines, to give more context. This improvement also fixes empty line validation not showing the right empty lines in the error output. Empty line validation shows tabs and whitespaces more clearly. Finally, it adds more tests including tests for existing logic, such as singleton factories.
52 lines
1.9 KiB
TypeScript
52 lines
1.9 KiB
TypeScript
import { NoEmptyLines } from '@/application/Parser/Script/Validation/Rules/NoEmptyLines';
|
|
import { testCodeValidationRule } from './CodeValidationRuleTestRunner';
|
|
|
|
describe('NoEmptyLines', () => {
|
|
describe('analyze', () => {
|
|
testCodeValidationRule([
|
|
{
|
|
testName: 'no results when code is valid',
|
|
codeLines: ['non-empty-line1', 'none-empty-line2'],
|
|
expected: [],
|
|
sut: new NoEmptyLines(),
|
|
},
|
|
{
|
|
testName: 'shows error for empty line',
|
|
codeLines: ['first line', '', 'third line'],
|
|
expected: [{ index: 2, error: 'Empty line' }],
|
|
sut: new NoEmptyLines(),
|
|
},
|
|
{
|
|
testName: 'shows error for multiple empty lines',
|
|
codeLines: ['first line', '', 'third line', ''],
|
|
expected: [2, 4].map((index) => ({ index, error: 'Empty line' })),
|
|
sut: new NoEmptyLines(),
|
|
},
|
|
{
|
|
testName: 'shows error for undefined and null lines',
|
|
codeLines: ['first line', undefined, 'third line', null],
|
|
expected: [2, 4].map((index) => ({ index, error: 'Empty line' })),
|
|
sut: new NoEmptyLines(),
|
|
},
|
|
{
|
|
testName: 'shows error for whitespace-only lines',
|
|
codeLines: ['first line', ' ', 'third line'],
|
|
expected: [{ index: 2, error: 'Empty line: "{whitespace}{whitespace}"' }],
|
|
sut: new NoEmptyLines(),
|
|
},
|
|
{
|
|
testName: 'shows error for tab-only lines',
|
|
codeLines: ['first line', '\t\t', 'third line'],
|
|
expected: [{ index: 2, error: 'Empty line: "{tab}{tab}"' }],
|
|
sut: new NoEmptyLines(),
|
|
},
|
|
{
|
|
testName: 'shows error for lines that consists of whitespace and tabs',
|
|
codeLines: ['first line', '\t \t', 'third line', ' \t '],
|
|
expected: [{ index: 2, error: 'Empty line: "{tab}{whitespace}{tab}"' }, { index: 4, error: 'Empty line: "{whitespace}{tab}{whitespace}"' }],
|
|
sut: new NoEmptyLines(),
|
|
},
|
|
]);
|
|
});
|
|
});
|