949fac1a7c
This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
58 lines
2.2 KiB
TypeScript
58 lines
2.2 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { ExpressionEvaluationContext, IExpressionEvaluationContext } from '@/application/Parser/Script/Compiler/Expressions/Expression/ExpressionEvaluationContext';
|
|
import { IReadOnlyFunctionCallArgumentCollection } from '@/application/Parser/Script/Compiler/Function/Call/Argument/IFunctionCallArgumentCollection';
|
|
import { IPipelineCompiler } from '@/application/Parser/Script/Compiler/Expressions/Pipes/IPipelineCompiler';
|
|
import { FunctionCallArgumentCollectionStub } from '@tests/unit/shared/Stubs/FunctionCallArgumentCollectionStub';
|
|
import { PipelineCompilerStub } from '@tests/unit/shared/Stubs/PipelineCompilerStub';
|
|
|
|
describe('ExpressionEvaluationContext', () => {
|
|
describe('ctor', () => {
|
|
describe('args', () => {
|
|
it('sets as expected', () => {
|
|
// arrange
|
|
const expected = new FunctionCallArgumentCollectionStub()
|
|
.withArgument('expectedParameter', 'expectedValue');
|
|
const builder = new ExpressionEvaluationContextBuilder()
|
|
.withArgs(expected);
|
|
// act
|
|
const sut = builder.build();
|
|
// assert
|
|
const actual = sut.args;
|
|
expect(actual).to.equal(expected);
|
|
});
|
|
});
|
|
describe('pipelineCompiler', () => {
|
|
it('sets as expected', () => {
|
|
// arrange
|
|
const expected = new PipelineCompilerStub();
|
|
const builder = new ExpressionEvaluationContextBuilder()
|
|
.withPipelineCompiler(expected);
|
|
// act
|
|
const sut = builder.build();
|
|
// assert
|
|
expect(sut.pipelineCompiler).to.equal(expected);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
class ExpressionEvaluationContextBuilder {
|
|
private args: IReadOnlyFunctionCallArgumentCollection = new FunctionCallArgumentCollectionStub();
|
|
|
|
private pipelineCompiler: IPipelineCompiler = new PipelineCompilerStub();
|
|
|
|
public withArgs(args: IReadOnlyFunctionCallArgumentCollection) {
|
|
this.args = args;
|
|
return this;
|
|
}
|
|
|
|
public withPipelineCompiler(pipelineCompiler: IPipelineCompiler) {
|
|
this.pipelineCompiler = pipelineCompiler;
|
|
return this;
|
|
}
|
|
|
|
public build(): IExpressionEvaluationContext {
|
|
return new ExpressionEvaluationContext(this.args, this.pipelineCompiler);
|
|
}
|
|
}
|