949fac1a7c
This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
56 lines
2.0 KiB
TypeScript
56 lines
2.0 KiB
TypeScript
import {
|
|
describe,
|
|
} from 'vitest';
|
|
import { itIsSingleton } from '@tests/unit/shared/TestCases/SingletonTests';
|
|
import { EnvironmentVariablesFactory, EnvironmentVariablesValidator } from '@/infrastructure/EnvironmentVariables/EnvironmentVariablesFactory';
|
|
import { ViteEnvironmentVariables } from '@/infrastructure/EnvironmentVariables/Vite/ViteEnvironmentVariables';
|
|
import { IEnvironmentVariables } from '@/infrastructure/EnvironmentVariables/IEnvironmentVariables';
|
|
import { expectExists } from '@tests/shared/Assertions/ExpectExists';
|
|
|
|
describe('EnvironmentVariablesFactory', () => {
|
|
describe('instance', () => {
|
|
itIsSingleton({
|
|
getter: () => EnvironmentVariablesFactory.Current.instance,
|
|
expectedType: ViteEnvironmentVariables,
|
|
});
|
|
});
|
|
it('creates the correct type', () => {
|
|
// arrange
|
|
const sut = new TestableEnvironmentVariablesFactory();
|
|
// act
|
|
const metadata = sut.instance;
|
|
// assert
|
|
expect(metadata).to.be.instanceOf(ViteEnvironmentVariables);
|
|
});
|
|
it('validates its instance', () => {
|
|
// arrange
|
|
let validatedInstance: IEnvironmentVariables | undefined;
|
|
const validatorMock = (instanceToValidate: IEnvironmentVariables) => {
|
|
validatedInstance = instanceToValidate;
|
|
};
|
|
// act
|
|
const sut = new TestableEnvironmentVariablesFactory(validatorMock);
|
|
const actualInstance = sut.instance;
|
|
// assert
|
|
expectExists(validatedInstance);
|
|
expect(actualInstance).to.equal(validatedInstance);
|
|
});
|
|
it('throws error if validator fails', () => {
|
|
// arrange
|
|
const expectedError = 'validator failed';
|
|
const failingValidator = () => {
|
|
throw new Error(expectedError);
|
|
};
|
|
// act
|
|
const act = () => new TestableEnvironmentVariablesFactory(failingValidator);
|
|
// assert
|
|
expect(act).to.throw(expectedError);
|
|
});
|
|
});
|
|
|
|
class TestableEnvironmentVariablesFactory extends EnvironmentVariablesFactory {
|
|
public constructor(validator: EnvironmentVariablesValidator = () => { /* NO OP */ }) {
|
|
super(validator);
|
|
}
|
|
}
|