This commit resolves the issue with the `:active` pseudo-class not
activating in mobile Safari on iOS devices. It introduces a workaround
specifically for mobile Safari on iOS/iPadOS to enable the `:active`
pseudo-class. This ensures a consistent and responsive user interface
in response to touch states on mobile Safari.
Other supporting changes:
- Introduce new test utility functions such as `createWindowEventSpies`
and `formatAssertionMessage` to improve code reusability and
maintainability.
- Improve browser detection:
- Add detection for iPadOS and Windows 10 Mobile.
- Add touch support detection to correctly determine iPadOS vs macOS.
- Fix misidentification of some Windows 10 Mobile platforms as Windows
Phone.
- Improve test coverage and refactor tests.
237 lines
9.5 KiB
TypeScript
237 lines
9.5 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { ExpressionPosition } from '@/application/Parser/Script/Compiler/Expressions/Expression/ExpressionPosition';
|
|
import { ExpressionEvaluator, Expression } from '@/application/Parser/Script/Compiler/Expressions/Expression/Expression';
|
|
import { IReadOnlyFunctionCallArgumentCollection } from '@/application/Parser/Script/Compiler/Function/Call/Argument/IFunctionCallArgumentCollection';
|
|
import { FunctionCallArgumentCollectionStub } from '@tests/unit/shared/Stubs/FunctionCallArgumentCollectionStub';
|
|
import { FunctionParameterCollectionStub } from '@tests/unit/shared/Stubs/FunctionParameterCollectionStub';
|
|
import { FunctionCallArgumentStub } from '@tests/unit/shared/Stubs/FunctionCallArgumentStub';
|
|
import { ExpressionEvaluationContextStub } from '@tests/unit/shared/Stubs/ExpressionEvaluationContextStub';
|
|
import { IPipelineCompiler } from '@/application/Parser/Script/Compiler/Expressions/Pipes/IPipelineCompiler';
|
|
import { PipelineCompilerStub } from '@tests/unit/shared/Stubs/PipelineCompilerStub';
|
|
import { IReadOnlyFunctionParameterCollection } from '@/application/Parser/Script/Compiler/Function/Parameter/IFunctionParameterCollection';
|
|
import { itEachAbsentObjectValue } from '@tests/unit/shared/TestCases/AbsentTests';
|
|
import { IExpressionEvaluationContext } from '@/application/Parser/Script/Compiler/Expressions/Expression/ExpressionEvaluationContext';
|
|
import { expectExists } from '@tests/shared/Assertions/ExpectExists';
|
|
import { formatAssertionMessage } from '@tests/shared/FormatAssertionMessage';
|
|
|
|
describe('Expression', () => {
|
|
describe('ctor', () => {
|
|
describe('position', () => {
|
|
it('sets as expected', () => {
|
|
// arrange
|
|
const expected = new ExpressionPosition(0, 5);
|
|
// act
|
|
const actual = new ExpressionBuilder()
|
|
.withPosition(expected)
|
|
.build();
|
|
// assert
|
|
expect(actual.position).to.equal(expected);
|
|
});
|
|
});
|
|
describe('parameters', () => {
|
|
describe('defaults to empty array if absent', () => {
|
|
itEachAbsentObjectValue((absentValue) => {
|
|
// arrange
|
|
const parameters = absentValue;
|
|
// act
|
|
const actual = new ExpressionBuilder()
|
|
.withParameters(parameters)
|
|
.build();
|
|
// assert
|
|
expect(actual.parameters);
|
|
expect(actual.parameters.all);
|
|
expect(actual.parameters.all.length).to.equal(0);
|
|
}, { excludeNull: true });
|
|
});
|
|
it('sets as expected', () => {
|
|
// arrange
|
|
const expected = new FunctionParameterCollectionStub()
|
|
.withParameterName('firstParameterName')
|
|
.withParameterName('secondParameterName');
|
|
// act
|
|
const actual = new ExpressionBuilder()
|
|
.withParameters(expected)
|
|
.build();
|
|
// assert
|
|
expect(actual.parameters).to.deep.equal(expected);
|
|
});
|
|
});
|
|
});
|
|
describe('evaluate', () => {
|
|
describe('throws with invalid arguments', () => {
|
|
const testCases: readonly {
|
|
name: string,
|
|
context: IExpressionEvaluationContext,
|
|
expectedError: string,
|
|
sutBuilder?: (builder: ExpressionBuilder) => ExpressionBuilder,
|
|
}[] = [
|
|
{
|
|
name: 'throws when some of the required args are not provided',
|
|
sutBuilder: (i: ExpressionBuilder) => i.withParameterNames(['a', 'b', 'c'], false),
|
|
context: new ExpressionEvaluationContextStub()
|
|
.withArgs(new FunctionCallArgumentCollectionStub().withArgument('b', 'provided')),
|
|
expectedError: 'argument values are provided for required parameters: "a", "c"',
|
|
},
|
|
{
|
|
name: 'throws when none of the required args are not provided',
|
|
sutBuilder: (i: ExpressionBuilder) => i.withParameterNames(['a', 'b'], false),
|
|
context: new ExpressionEvaluationContextStub()
|
|
.withArgs(new FunctionCallArgumentCollectionStub().withArgument('c', 'unrelated')),
|
|
expectedError: 'argument values are provided for required parameters: "a", "b"',
|
|
},
|
|
];
|
|
for (const testCase of testCases) {
|
|
it(testCase.name, () => {
|
|
// arrange
|
|
const sutBuilder = new ExpressionBuilder();
|
|
if (testCase.sutBuilder) {
|
|
testCase.sutBuilder(sutBuilder);
|
|
}
|
|
const sut = sutBuilder.build();
|
|
// act
|
|
const act = () => sut.evaluate(testCase.context);
|
|
// assert
|
|
expect(act).to.throw(testCase.expectedError);
|
|
});
|
|
}
|
|
});
|
|
it('returns result from evaluator', () => {
|
|
// arrange
|
|
const evaluatorMock: ExpressionEvaluator = (c) => `"${c
|
|
.args
|
|
.getAllParameterNames()
|
|
.map((name) => context.args.getArgument(name))
|
|
.map((arg) => `${arg.parameterName}': '${arg.argumentValue}'`)
|
|
.join('", "')}"`;
|
|
const givenArguments = new FunctionCallArgumentCollectionStub()
|
|
.withArgument('parameter1', 'value1')
|
|
.withArgument('parameter2', 'value2');
|
|
const expectedParameterNames = givenArguments.getAllParameterNames();
|
|
const context = new ExpressionEvaluationContextStub()
|
|
.withArgs(givenArguments);
|
|
const expected = evaluatorMock(context);
|
|
const sut = new ExpressionBuilder()
|
|
.withEvaluator(evaluatorMock)
|
|
.withParameterNames(expectedParameterNames)
|
|
.build();
|
|
// arrange
|
|
const actual = sut.evaluate(context);
|
|
// assert
|
|
expect(expected).to.equal(actual, formatAssertionMessage([
|
|
`Given arguments: ${JSON.stringify(givenArguments)}`,
|
|
`Expected parameter names: ${JSON.stringify(expectedParameterNames)}`,
|
|
]));
|
|
});
|
|
it('sends pipeline compiler as it is', () => {
|
|
// arrange
|
|
const expected = new PipelineCompilerStub();
|
|
const context = new ExpressionEvaluationContextStub()
|
|
.withPipelineCompiler(expected);
|
|
let actual: IPipelineCompiler | undefined;
|
|
const evaluatorMock: ExpressionEvaluator = (c) => {
|
|
actual = c.pipelineCompiler;
|
|
return '';
|
|
};
|
|
const sut = new ExpressionBuilder()
|
|
.withEvaluator(evaluatorMock)
|
|
.build();
|
|
// arrange
|
|
sut.evaluate(context);
|
|
// assert
|
|
expectExists(actual);
|
|
expect(expected).to.equal(actual);
|
|
});
|
|
describe('filters unused parameters', () => {
|
|
// arrange
|
|
const testCases = [
|
|
{
|
|
name: 'with a provided argument',
|
|
expressionParameters: new FunctionParameterCollectionStub()
|
|
.withParameterName('parameterToHave', false),
|
|
arguments: new FunctionCallArgumentCollectionStub()
|
|
.withArgument('parameterToHave', 'value-to-have')
|
|
.withArgument('parameterToIgnore', 'value-to-ignore'),
|
|
expectedArguments: [
|
|
new FunctionCallArgumentStub()
|
|
.withParameterName('parameterToHave').withArgumentValue('value-to-have'),
|
|
],
|
|
},
|
|
{
|
|
name: 'without a provided argument',
|
|
expressionParameters: new FunctionParameterCollectionStub()
|
|
.withParameterName('parameterToHave', false)
|
|
.withParameterName('parameterToIgnore', true),
|
|
arguments: new FunctionCallArgumentCollectionStub()
|
|
.withArgument('parameterToHave', 'value-to-have'),
|
|
expectedArguments: [
|
|
new FunctionCallArgumentStub()
|
|
.withParameterName('parameterToHave').withArgumentValue('value-to-have'),
|
|
],
|
|
},
|
|
];
|
|
for (const testCase of testCases) {
|
|
it(testCase.name, () => {
|
|
let actual: IReadOnlyFunctionCallArgumentCollection | undefined;
|
|
const evaluatorMock: ExpressionEvaluator = (c) => {
|
|
actual = c.args;
|
|
return '';
|
|
};
|
|
const context = new ExpressionEvaluationContextStub()
|
|
.withArgs(testCase.arguments);
|
|
const sut = new ExpressionBuilder()
|
|
.withEvaluator(evaluatorMock)
|
|
.withParameters(testCase.expressionParameters)
|
|
.build();
|
|
// act
|
|
sut.evaluate(context);
|
|
// assert
|
|
expectExists(actual);
|
|
const collection = actual;
|
|
const actualArguments = collection.getAllParameterNames()
|
|
.map((name) => collection.getArgument(name));
|
|
expect(actualArguments).to.deep.equal(testCase.expectedArguments);
|
|
});
|
|
}
|
|
});
|
|
});
|
|
});
|
|
|
|
class ExpressionBuilder {
|
|
private position: ExpressionPosition = new ExpressionPosition(0, 5);
|
|
|
|
private parameters?: IReadOnlyFunctionParameterCollection = new FunctionParameterCollectionStub();
|
|
|
|
public withPosition(position: ExpressionPosition) {
|
|
this.position = position;
|
|
return this;
|
|
}
|
|
|
|
public withEvaluator(evaluator: ExpressionEvaluator) {
|
|
this.evaluator = evaluator;
|
|
return this;
|
|
}
|
|
|
|
public withParameters(parameters: IReadOnlyFunctionParameterCollection | undefined) {
|
|
this.parameters = parameters;
|
|
return this;
|
|
}
|
|
|
|
public withParameterName(parameterName: string, isOptional = true) {
|
|
const collection = new FunctionParameterCollectionStub()
|
|
.withParameterName(parameterName, isOptional);
|
|
return this.withParameters(collection);
|
|
}
|
|
|
|
public withParameterNames(parameterNames: string[], isOptional = true) {
|
|
const collection = new FunctionParameterCollectionStub()
|
|
.withParameterNames(parameterNames, isOptional);
|
|
return this.withParameters(collection);
|
|
}
|
|
|
|
public build() {
|
|
return new Expression(this.position, this.evaluator, this.parameters);
|
|
}
|
|
|
|
private evaluator: ExpressionEvaluator = () => `[${ExpressionBuilder.name}] evaluated-expression`;
|
|
}
|