This commit unifies executable ID structure across categories and scripts, paving the way for more complex ID solutions for #262. It also refactors related code to adapt to the changes. Key changes: - Change numeric IDs to string IDs for categories - Use named types for string IDs to improve code clarity - Add unit tests to verify ID uniqueness Other supporting changes: - Separate concerns in entities for data access and executables by using separate abstractions (`Identifiable` and `RepositoryEntity`) - Simplify usage and construction of entities. - Remove `BaseEntity` for simplicity. - Move creation of categories/scripts to domain layer - Refactor CategoryCollection for better validation logic isolation - Rename some categories to keep the names (used as pseudo-IDs) unique on Windows.
41 lines
1.5 KiB
TypeScript
41 lines
1.5 KiB
TypeScript
import type { ProjectDetails } from '@/domain/Project/ProjectDetails';
|
|
import type { ICategoryCollection } from '@/domain/Collection/ICategoryCollection';
|
|
import { getEnumValues } from '@/application/Common/Enum';
|
|
import type { CollectionData } from '@/application/collections/';
|
|
import { OperatingSystem } from '@/domain/OperatingSystem';
|
|
import type { CategoryCollectionParser } from '@/application/Parser/CategoryCollectionParser';
|
|
import { CategoryCollectionStub } from './CategoryCollectionStub';
|
|
|
|
export class CategoryCollectionParserStub {
|
|
public readonly arguments = new Array<{
|
|
data: CollectionData,
|
|
projectDetails: ProjectDetails,
|
|
}>();
|
|
|
|
private readonly returnValues = new Map<CollectionData, ICategoryCollection>();
|
|
|
|
public withReturnValue(
|
|
data: CollectionData,
|
|
collection: ICategoryCollection,
|
|
): this {
|
|
this.returnValues.set(data, collection);
|
|
return this;
|
|
}
|
|
|
|
public getStub(): CategoryCollectionParser {
|
|
return (data: CollectionData, projectDetails: ProjectDetails): ICategoryCollection => {
|
|
this.arguments.push({ data, projectDetails });
|
|
const foundReturnValue = this.returnValues.get(data);
|
|
if (foundReturnValue) {
|
|
return foundReturnValue;
|
|
}
|
|
// Get next OS with a unique OS so mock does not result in an invalid app due to duplicated OS
|
|
// collections.
|
|
const currentRun = this.arguments.length - 1;
|
|
const nextOs = getEnumValues(OperatingSystem)[currentRun];
|
|
return new CategoryCollectionStub()
|
|
.withOs(nextOs);
|
|
};
|
|
}
|
|
}
|