8ccaec7af6
This commit fixes the bug where the "Copy" button does not copy when
clicked on download instructions modal (on Linux and macOS).
This commit also introduces several improvements to the UI components
related to copy action and their interaction with the clipboard feature.
It adds more tests to avoid regression of the bugs and improves
maintainability, testability and adherence to Vue's reactive principles.
Changes include:
- Fix non-responsive copy button in the download instructions modal by
triggering a `click` event in `AppIcon.vue`.
- Improve `TheCodeButtons.vue`:
- Remove redundant `getCurrentCode` function.
- Separate components for each button for better separation of
concerns and higher testability.
- Use the `gap` property in the flexbox layout, replacing the less
explicit sibling combinator approach.
- Add `useClipboard` compositional hook for more idiomatic Vue approach
to interacting with the clipboard.
- Add `useCurrentCode` compositional hook to handle current code state
more effectively with unified logic.
- Abstract clipboard operations to an interface to isolate
responsibilities.
- Switch clipboard implementation to the `navigator.clipboard` API,
moving away from the deprecated `document.execCommand`.
- Move clipboard logic to the presentation layer to conform to
separation of concerns and domain-driven design principles.
- Improve `IconButton.vue` component to increase reusability with
consistent sizing.
83 lines
1.8 KiB
Vue
83 lines
1.8 KiB
Vue
<template>
|
|
<span class="code-wrapper">
|
|
<span class="dollar">$</span>
|
|
<code ref="codeElement"><slot /></code>
|
|
<TooltipWrapper>
|
|
<AppIcon
|
|
class="copy-button"
|
|
icon="copy"
|
|
@click="copyCode"
|
|
/>
|
|
<template v-slot:tooltip>
|
|
Copy
|
|
</template>
|
|
</TooltipWrapper>
|
|
</span>
|
|
</template>
|
|
|
|
<script lang="ts">
|
|
import { defineComponent, shallowRef, inject } from 'vue';
|
|
import TooltipWrapper from '@/presentation/components/Shared/TooltipWrapper.vue';
|
|
import AppIcon from '@/presentation/components/Shared/Icon/AppIcon.vue';
|
|
import { InjectionKeys } from '@/presentation/injectionSymbols';
|
|
|
|
export default defineComponent({
|
|
components: {
|
|
TooltipWrapper,
|
|
AppIcon,
|
|
},
|
|
setup() {
|
|
const { copyText } = inject(InjectionKeys.useClipboard)();
|
|
|
|
const codeElement = shallowRef<HTMLElement | undefined>();
|
|
|
|
async function copyCode() {
|
|
const element = codeElement.value;
|
|
if (!element) {
|
|
throw new Error('Code element could not be found.');
|
|
}
|
|
const code = element.textContent;
|
|
if (!code) {
|
|
throw new Error('Code element does not contain any text.');
|
|
}
|
|
await copyText(code);
|
|
}
|
|
|
|
return {
|
|
copyCode,
|
|
codeElement,
|
|
};
|
|
},
|
|
});
|
|
</script>
|
|
|
|
<style scoped lang="scss">
|
|
@use "@/presentation/assets/styles/main" as *;
|
|
|
|
.code-wrapper {
|
|
display:flex;
|
|
white-space: nowrap;
|
|
justify-content: space-between;
|
|
font-family: $font-normal;
|
|
background-color: $color-primary-darker;
|
|
color: $color-on-primary;
|
|
align-items: center;
|
|
padding: 0.2rem;
|
|
.dollar {
|
|
margin-right: 0.5rem;
|
|
font-size: 0.8rem;
|
|
user-select: none;
|
|
}
|
|
.copy-button {
|
|
margin-left: 1rem;
|
|
@include clickable;
|
|
@include hover-or-touch {
|
|
color: $color-primary;
|
|
}
|
|
}
|
|
code {
|
|
font-size: 1rem;
|
|
}
|
|
}
|
|
</style>
|