949fac1a7c
This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
69 lines
2.3 KiB
TypeScript
69 lines
2.3 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { ParsedFunctionCall } from '@/application/Parser/Script/Compiler/Function/Call/ParsedFunctionCall';
|
|
import { IReadOnlyFunctionCallArgumentCollection } from '@/application/Parser/Script/Compiler/Function/Call/Argument/IFunctionCallArgumentCollection';
|
|
import { FunctionCallArgumentCollectionStub } from '@tests/unit/shared/Stubs/FunctionCallArgumentCollectionStub';
|
|
import { itEachAbsentStringValue } from '@tests/unit/shared/TestCases/AbsentTests';
|
|
|
|
describe('ParsedFunctionCall', () => {
|
|
describe('ctor', () => {
|
|
describe('args', () => {
|
|
it('sets args as expected', () => {
|
|
// arrange
|
|
const expected = new FunctionCallArgumentCollectionStub()
|
|
.withArgument('testParameter', 'testValue');
|
|
// act
|
|
const sut = new FunctionCallBuilder()
|
|
.withArgs(expected)
|
|
.build();
|
|
// assert
|
|
expect(sut.args).to.deep.equal(expected);
|
|
});
|
|
});
|
|
describe('functionName', () => {
|
|
describe('throws when function name is missing', () => {
|
|
itEachAbsentStringValue((absentValue) => {
|
|
// arrange
|
|
const expectedError = 'missing function name in function call';
|
|
const functionName = absentValue;
|
|
// act
|
|
const act = () => new FunctionCallBuilder()
|
|
.withFunctionName(functionName)
|
|
.build();
|
|
// assert
|
|
expect(act).to.throw(expectedError);
|
|
}, { excludeNull: true, excludeUndefined: true });
|
|
});
|
|
it('sets function name as expected', () => {
|
|
// arrange
|
|
const expected = 'expectedFunctionName';
|
|
// act
|
|
const sut = new FunctionCallBuilder()
|
|
.withFunctionName(expected)
|
|
.build();
|
|
// assert
|
|
expect(sut.functionName).to.equal(expected);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
class FunctionCallBuilder {
|
|
private functionName = 'functionName';
|
|
|
|
private args: IReadOnlyFunctionCallArgumentCollection = new FunctionCallArgumentCollectionStub();
|
|
|
|
public withFunctionName(functionName: string) {
|
|
this.functionName = functionName;
|
|
return this;
|
|
}
|
|
|
|
public withArgs(args: IReadOnlyFunctionCallArgumentCollection) {
|
|
this.args = args;
|
|
return this;
|
|
}
|
|
|
|
public build() {
|
|
return new ParsedFunctionCall(this.functionName, this.args);
|
|
}
|
|
}
|