This commit improves the dependency injection mechanism by introducing a custom `injectKey` function. Key improvements are: - Enforced type consistency during dependency registration and instantiation. - Simplified injection process, abstracting away the complexity with a uniform API, regardless of the dependency's lifetime. - Eliminated the possibility of `undefined` returns during dependency injection, promoting fail-fast behavior. - Removed the necessity for type casting to `symbol` for injection keys in unit tests by using existing types. - Consalidated imports, combining keys and injection functions in one `import` statement.
104 lines
4.4 KiB
TypeScript
104 lines
4.4 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { OperatingSystem } from '@/domain/OperatingSystem';
|
|
import { ICategoryCollection } from '@/domain/ICategoryCollection';
|
|
import { buildContext } from '@/application/Context/ApplicationContextFactory';
|
|
import { IApplicationFactory } from '@/application/IApplicationFactory';
|
|
import { IApplication } from '@/domain/IApplication';
|
|
import { RuntimeEnvironmentStub } from '@tests/unit/shared/Stubs/RuntimeEnvironmentStub';
|
|
import { ApplicationStub } from '@tests/unit/shared/Stubs/ApplicationStub';
|
|
import { CategoryCollectionStub } from '@tests/unit/shared/Stubs/CategoryCollectionStub';
|
|
import { expectThrowsAsync } from '@tests/shared/Assertions/ExpectThrowsAsync';
|
|
|
|
describe('ApplicationContextFactory', () => {
|
|
describe('buildContext', () => {
|
|
describe('factory', () => {
|
|
it('sets application from factory', async () => {
|
|
// arrange
|
|
const expected = new ApplicationStub().withCollection(
|
|
new CategoryCollectionStub().withOs(OperatingSystem.macOS),
|
|
);
|
|
const factoryMock = mockFactoryWithApp(expected);
|
|
// act
|
|
const context = await buildContext(factoryMock);
|
|
// assert
|
|
expect(expected).to.equal(context.app);
|
|
});
|
|
it('throws when null', async () => {
|
|
// arrange
|
|
const expectedError = 'missing factory';
|
|
const factory = null;
|
|
// act
|
|
const act = async () => { await buildContext(factory); };
|
|
// assert
|
|
expectThrowsAsync(act, expectedError);
|
|
});
|
|
});
|
|
describe('environment', () => {
|
|
describe('sets initial OS as expected', () => {
|
|
it('returns currentOs if it is supported', async () => {
|
|
// arrange
|
|
const expected = OperatingSystem.Windows;
|
|
const environment = new RuntimeEnvironmentStub().withOs(expected);
|
|
const collection = new CategoryCollectionStub().withOs(expected);
|
|
const factoryMock = mockFactoryWithCollection(collection);
|
|
// act
|
|
const context = await buildContext(factoryMock, environment);
|
|
// assert
|
|
const actual = context.state.os;
|
|
expect(expected).to.equal(actual);
|
|
});
|
|
it('fallbacks to other os if OS in environment is not supported', async () => {
|
|
// arrange
|
|
const expected = OperatingSystem.Windows;
|
|
const currentOs = OperatingSystem.macOS;
|
|
const environment = new RuntimeEnvironmentStub().withOs(currentOs);
|
|
const collection = new CategoryCollectionStub().withOs(expected);
|
|
const factoryMock = mockFactoryWithCollection(collection);
|
|
// act
|
|
const context = await buildContext(factoryMock, environment);
|
|
// assert
|
|
const actual = context.state.os;
|
|
expect(expected).to.equal(actual);
|
|
});
|
|
it('fallbacks to most supported os if current os is not supported', async () => {
|
|
// arrange
|
|
const expectedOs = OperatingSystem.Android;
|
|
const allCollections = [
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Linux).withTotalScripts(3),
|
|
new CategoryCollectionStub().withOs(expectedOs).withTotalScripts(5),
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Windows).withTotalScripts(4),
|
|
];
|
|
const environment = new RuntimeEnvironmentStub().withOs(OperatingSystem.macOS);
|
|
const app = new ApplicationStub().withCollections(...allCollections);
|
|
const factoryMock = mockFactoryWithApp(app);
|
|
// act
|
|
const context = await buildContext(factoryMock, environment);
|
|
// assert
|
|
const actual = context.state.os;
|
|
expect(expectedOs).to.equal(actual, `Expected: ${OperatingSystem[expectedOs]}, actual: ${OperatingSystem[actual]}`);
|
|
});
|
|
});
|
|
it('throws when null', async () => {
|
|
// arrange
|
|
const expectedError = 'missing environment';
|
|
const factory = mockFactoryWithApp(undefined);
|
|
const environment = null;
|
|
// act
|
|
const act = async () => { await buildContext(factory, environment); };
|
|
// assert
|
|
expectThrowsAsync(act, expectedError);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
function mockFactoryWithCollection(result: ICategoryCollection): IApplicationFactory {
|
|
return mockFactoryWithApp(new ApplicationStub().withCollection(result));
|
|
}
|
|
|
|
function mockFactoryWithApp(app: IApplication): IApplicationFactory {
|
|
return {
|
|
getApp: () => Promise.resolve(app),
|
|
};
|
|
}
|