949fac1a7c
This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
92 lines
3.0 KiB
TypeScript
92 lines
3.0 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { CodeSubstituter } from '@/application/Parser/ScriptingDefinition/CodeSubstituter';
|
|
import { IExpressionsCompiler } from '@/application/Parser/Script/Compiler/Expressions/IExpressionsCompiler';
|
|
import { ProjectInformationStub } from '@tests/unit/shared/Stubs/ProjectInformationStub';
|
|
import { ExpressionsCompilerStub } from '@tests/unit/shared/Stubs/ExpressionsCompilerStub';
|
|
import { itEachAbsentStringValue } from '@tests/unit/shared/TestCases/AbsentTests';
|
|
|
|
describe('CodeSubstituter', () => {
|
|
describe('throws if code is empty', () => {
|
|
itEachAbsentStringValue((emptyCode) => {
|
|
// arrange
|
|
const expectedError = 'missing code';
|
|
const code = emptyCode;
|
|
const info = new ProjectInformationStub();
|
|
const sut = new CodeSubstituterBuilder().build();
|
|
// act
|
|
const act = () => sut.substitute(code, info);
|
|
// assert
|
|
expect(act).to.throw(expectedError);
|
|
}, { excludeNull: true, excludeUndefined: true });
|
|
});
|
|
describe('substitutes parameters as expected values', () => {
|
|
// arrange
|
|
const info = new ProjectInformationStub();
|
|
const date = new Date();
|
|
const testCases: Array<{ parameter: string, argument: string }> = [
|
|
{
|
|
parameter: 'homepage',
|
|
argument: info.homepage,
|
|
},
|
|
{
|
|
parameter: 'version',
|
|
argument: info.version.toString(),
|
|
},
|
|
{
|
|
parameter: 'date',
|
|
argument: date.toUTCString(),
|
|
},
|
|
];
|
|
for (const testCase of testCases) {
|
|
it(`substitutes ${testCase.parameter} as expected`, () => {
|
|
const compilerStub = new ExpressionsCompilerStub();
|
|
const sut = new CodeSubstituterBuilder()
|
|
.withCompiler(compilerStub)
|
|
.withDate(date)
|
|
.build();
|
|
// act
|
|
sut.substitute('non empty code', info);
|
|
// assert
|
|
expect(compilerStub.callHistory).to.have.lengthOf(1);
|
|
const parameters = compilerStub.callHistory[0].args[1];
|
|
expect(parameters.hasArgument(testCase.parameter));
|
|
const { argumentValue } = parameters.getArgument(testCase.parameter);
|
|
expect(argumentValue).to.equal(testCase.argument);
|
|
});
|
|
}
|
|
});
|
|
it('returns code as it is', () => {
|
|
// arrange
|
|
const expected = 'expected-code';
|
|
const compilerStub = new ExpressionsCompilerStub();
|
|
const sut = new CodeSubstituterBuilder()
|
|
.withCompiler(compilerStub)
|
|
.build();
|
|
// act
|
|
sut.substitute(expected, new ProjectInformationStub());
|
|
// assert
|
|
expect(compilerStub.callHistory).to.have.lengthOf(1);
|
|
expect(compilerStub.callHistory[0].args[0]).to.equal(expected);
|
|
});
|
|
});
|
|
|
|
class CodeSubstituterBuilder {
|
|
private compiler: IExpressionsCompiler = new ExpressionsCompilerStub();
|
|
|
|
private date = new Date();
|
|
|
|
public withCompiler(compiler: IExpressionsCompiler) {
|
|
this.compiler = compiler;
|
|
return this;
|
|
}
|
|
|
|
public withDate(date: Date) {
|
|
this.date = date;
|
|
return this;
|
|
}
|
|
|
|
public build() {
|
|
return new CodeSubstituter(this.compiler, this.date);
|
|
}
|
|
}
|