This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
227 lines
8.9 KiB
TypeScript
227 lines
8.9 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import type { CollectionData } from '@/application/collections/';
|
|
import { parseProjectInformation } from '@/application/Parser/ProjectInformationParser';
|
|
import { CategoryCollectionParserType, parseApplication } from '@/application/Parser/ApplicationParser';
|
|
import { IAppMetadata } from '@/infrastructure/EnvironmentVariables/IAppMetadata';
|
|
import WindowsData from '@/application/collections/windows.yaml';
|
|
import MacOsData from '@/application/collections/macos.yaml';
|
|
import LinuxData from '@/application/collections/linux.yaml';
|
|
import { OperatingSystem } from '@/domain/OperatingSystem';
|
|
import { CategoryCollectionStub } from '@tests/unit/shared/Stubs/CategoryCollectionStub';
|
|
import { CollectionDataStub } from '@tests/unit/shared/Stubs/CollectionDataStub';
|
|
import { getAbsentCollectionTestCases } from '@tests/unit/shared/TestCases/AbsentTests';
|
|
import { AppMetadataStub } from '@tests/unit/shared/Stubs/AppMetadataStub';
|
|
import { EnvironmentVariablesFactory } from '@/infrastructure/EnvironmentVariables/EnvironmentVariablesFactory';
|
|
import { CategoryCollectionParserStub } from '@tests/unit/shared/Stubs/CategoryCollectionParserStub';
|
|
import { ProjectInformationParserStub } from '@tests/unit/shared/Stubs/ProjectInformationParserStub';
|
|
import { ProjectInformationStub } from '@tests/unit/shared/Stubs/ProjectInformationStub';
|
|
|
|
describe('ApplicationParser', () => {
|
|
describe('parseApplication', () => {
|
|
describe('categoryParser', () => {
|
|
it('returns result from the parser', () => {
|
|
// arrange
|
|
const os = OperatingSystem.macOS;
|
|
const data = new CollectionDataStub();
|
|
const expected = new CategoryCollectionStub()
|
|
.withOs(os);
|
|
const parser = new CategoryCollectionParserStub()
|
|
.withReturnValue(data, expected)
|
|
.getStub();
|
|
const sut = new ApplicationParserBuilder()
|
|
.withCategoryCollectionParser(parser)
|
|
.withCollectionsData([data]);
|
|
// act
|
|
const app = sut.parseApplication();
|
|
// assert
|
|
const actual = app.getCollection(os);
|
|
expect(expected).to.equal(actual);
|
|
});
|
|
});
|
|
describe('project information', () => {
|
|
it('informationParser is used to create application info', () => {
|
|
// arrange
|
|
const expectedInformation = new ProjectInformationStub();
|
|
const informationParserStub = new ProjectInformationParserStub()
|
|
.withReturnValue(expectedInformation);
|
|
const sut = new ApplicationParserBuilder()
|
|
.withProjectInformationParser(informationParserStub.getStub());
|
|
// act
|
|
const app = sut.parseApplication();
|
|
// assert
|
|
const actualInformation = app.info;
|
|
expect(expectedInformation).to.deep.equal(actualInformation);
|
|
});
|
|
it('informationParser is used to parse collection info', () => {
|
|
// arrange
|
|
const expectedInformation = new ProjectInformationStub();
|
|
const informationParserStub = new ProjectInformationParserStub()
|
|
.withReturnValue(expectedInformation);
|
|
const collectionParserStub = new CategoryCollectionParserStub();
|
|
const sut = new ApplicationParserBuilder()
|
|
.withProjectInformationParser(informationParserStub.getStub())
|
|
.withCategoryCollectionParser(collectionParserStub.getStub());
|
|
// act
|
|
sut.parseApplication();
|
|
// assert
|
|
expect(collectionParserStub.arguments).to.have.length.above(0);
|
|
const actuallyUsedInfos = collectionParserStub.arguments.map((arg) => arg.info);
|
|
expect(actuallyUsedInfos.every((info) => info === expectedInformation));
|
|
});
|
|
});
|
|
describe('metadata', () => {
|
|
it('used to parse expected metadata', () => {
|
|
// arrange
|
|
const expectedMetadata = new AppMetadataStub();
|
|
const infoParserStub = new ProjectInformationParserStub();
|
|
// act
|
|
new ApplicationParserBuilder()
|
|
.withMetadata(expectedMetadata)
|
|
.withProjectInformationParser(infoParserStub.getStub())
|
|
.parseApplication();
|
|
// assert
|
|
expect(infoParserStub.arguments).to.have.lengthOf(1);
|
|
expect(infoParserStub.arguments[0]).to.equal(expectedMetadata);
|
|
});
|
|
it('defaults to metadata from factory', () => {
|
|
// arrange
|
|
const expectedMetadata: IAppMetadata = EnvironmentVariablesFactory.Current.instance;
|
|
const infoParserStub = new ProjectInformationParserStub();
|
|
// act
|
|
new ApplicationParserBuilder()
|
|
.withMetadata(undefined) // force using default
|
|
.withProjectInformationParser(infoParserStub.getStub())
|
|
.parseApplication();
|
|
// assert
|
|
expect(infoParserStub.arguments).to.have.lengthOf(1);
|
|
expect(infoParserStub.arguments[0]).to.equal(expectedMetadata);
|
|
});
|
|
});
|
|
describe('collectionsData', () => {
|
|
describe('set as expected', () => {
|
|
// arrange
|
|
const testCases = [
|
|
{
|
|
name: 'single collection',
|
|
input: [new CollectionDataStub()],
|
|
output: [new CategoryCollectionStub().withOs(OperatingSystem.macOS)],
|
|
},
|
|
{
|
|
name: 'multiple collections',
|
|
input: [
|
|
new CollectionDataStub().withOs('windows'),
|
|
new CollectionDataStub().withOs('macos'),
|
|
],
|
|
output: [
|
|
new CategoryCollectionStub().withOs(OperatingSystem.macOS),
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Windows),
|
|
],
|
|
},
|
|
];
|
|
// act
|
|
for (const testCase of testCases) {
|
|
it(testCase.name, () => {
|
|
let categoryParserStub = new CategoryCollectionParserStub();
|
|
for (let i = 0; i < testCase.input.length; i++) {
|
|
categoryParserStub = categoryParserStub
|
|
.withReturnValue(testCase.input[i], testCase.output[i]);
|
|
}
|
|
const sut = new ApplicationParserBuilder()
|
|
.withCategoryCollectionParser(categoryParserStub.getStub())
|
|
.withCollectionsData(testCase.input);
|
|
// act
|
|
const app = sut.parseApplication();
|
|
// assert
|
|
expect(app.collections).to.deep.equal(testCase.output);
|
|
});
|
|
}
|
|
});
|
|
it('defaults to expected data', () => {
|
|
// arrange
|
|
const expected = [WindowsData, MacOsData, LinuxData];
|
|
const categoryParserStub = new CategoryCollectionParserStub();
|
|
const sut = new ApplicationParserBuilder()
|
|
.withCollectionsData(undefined)
|
|
.withCategoryCollectionParser(categoryParserStub.getStub());
|
|
// act
|
|
sut.parseApplication();
|
|
// assert
|
|
const actual = categoryParserStub.arguments.map((args) => args.data);
|
|
expect(actual).to.deep.equal(expected);
|
|
});
|
|
describe('throws when data is invalid', () => {
|
|
// arrange
|
|
const testCases = [
|
|
...getAbsentCollectionTestCases<CollectionData>(
|
|
{
|
|
excludeUndefined: true,
|
|
excludeNull: true,
|
|
},
|
|
).map((testCase) => ({
|
|
name: `given absent collection "${testCase.valueName}"`,
|
|
value: testCase.absentValue,
|
|
expectedError: 'missing collections',
|
|
})),
|
|
];
|
|
for (const testCase of testCases) {
|
|
it(testCase.name, () => {
|
|
const sut = new ApplicationParserBuilder()
|
|
.withCollectionsData(testCase.value);
|
|
// act
|
|
const act = () => sut.parseApplication();
|
|
// assert
|
|
expect(act).to.throw(testCase.expectedError);
|
|
});
|
|
}
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
class ApplicationParserBuilder {
|
|
private categoryCollectionParser
|
|
: CategoryCollectionParserType = new CategoryCollectionParserStub().getStub();
|
|
|
|
private projectInformationParser
|
|
: typeof parseProjectInformation = new ProjectInformationParserStub().getStub();
|
|
|
|
private metadata: IAppMetadata | undefined = new AppMetadataStub();
|
|
|
|
private collectionsData: CollectionData[] | undefined = [new CollectionDataStub()];
|
|
|
|
public withCategoryCollectionParser(
|
|
categoryCollectionParser: CategoryCollectionParserType,
|
|
): this {
|
|
this.categoryCollectionParser = categoryCollectionParser;
|
|
return this;
|
|
}
|
|
|
|
public withProjectInformationParser(
|
|
projectInformationParser: typeof parseProjectInformation,
|
|
): this {
|
|
this.projectInformationParser = projectInformationParser;
|
|
return this;
|
|
}
|
|
|
|
public withMetadata(
|
|
metadata: IAppMetadata | undefined,
|
|
): this {
|
|
this.metadata = metadata;
|
|
return this;
|
|
}
|
|
|
|
public withCollectionsData(collectionsData: CollectionData[] | undefined): this {
|
|
this.collectionsData = collectionsData;
|
|
return this;
|
|
}
|
|
|
|
public parseApplication(): ReturnType<typeof parseApplication> {
|
|
return parseApplication(
|
|
this.categoryCollectionParser,
|
|
this.projectInformationParser,
|
|
this.metadata,
|
|
this.collectionsData,
|
|
);
|
|
}
|
|
}
|