949fac1a7c
This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
36 lines
1.3 KiB
TypeScript
36 lines
1.3 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { FunctionParameterCollection } from '@/application/Parser/Script/Compiler/Function/Parameter/FunctionParameterCollection';
|
|
import { FunctionParameterStub } from '@tests/unit/shared/Stubs/FunctionParameterStub';
|
|
|
|
describe('FunctionParameterCollection', () => {
|
|
it('all returns added parameters as expected', () => {
|
|
// arrange
|
|
const expected = [
|
|
new FunctionParameterStub().withName('1'),
|
|
new FunctionParameterStub().withName('2').withOptionality(true),
|
|
new FunctionParameterStub().withName('3').withOptionality(false),
|
|
];
|
|
const sut = new FunctionParameterCollection();
|
|
for (const parameter of expected) {
|
|
sut.addParameter(parameter);
|
|
}
|
|
// act
|
|
const actual = sut.all;
|
|
// assert
|
|
expect(expected).to.deep.equal(actual);
|
|
});
|
|
it('throws when function parameters have same names', () => {
|
|
// arrange
|
|
const parameterName = 'duplicate-parameter';
|
|
const expectedError = `duplicate parameter name: "${parameterName}"`;
|
|
const sut = new FunctionParameterCollection();
|
|
sut.addParameter(new FunctionParameterStub().withName(parameterName));
|
|
// act
|
|
const act = () => sut.addParameter(
|
|
new FunctionParameterStub().withName(parameterName),
|
|
);
|
|
// assert
|
|
expect(act).to.throw(expectedError);
|
|
});
|
|
});
|