949fac1a7c
This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
49 lines
1.4 KiB
TypeScript
49 lines
1.4 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { ApplicationFactory, ApplicationGetterType } from '@/application/ApplicationFactory';
|
|
import { ApplicationStub } from '@tests/unit/shared/Stubs/ApplicationStub';
|
|
|
|
describe('ApplicationFactory', () => {
|
|
describe('getApp', () => {
|
|
it('returns result from the getter', async () => {
|
|
// arrange
|
|
const expected = new ApplicationStub();
|
|
const getter: ApplicationGetterType = () => expected;
|
|
const sut = new SystemUnderTest(getter);
|
|
// act
|
|
const actual = await Promise.all([
|
|
sut.getApp(),
|
|
sut.getApp(),
|
|
sut.getApp(),
|
|
sut.getApp(),
|
|
]);
|
|
// assert
|
|
expect(actual.every((value) => value === expected));
|
|
});
|
|
it('only executes getter once', async () => {
|
|
// arrange
|
|
let totalExecution = 0;
|
|
const expected = new ApplicationStub();
|
|
const getter: ApplicationGetterType = () => {
|
|
totalExecution++;
|
|
return expected;
|
|
};
|
|
const sut = new SystemUnderTest(getter);
|
|
// act
|
|
await Promise.all([
|
|
sut.getApp(),
|
|
sut.getApp(),
|
|
sut.getApp(),
|
|
sut.getApp(),
|
|
]);
|
|
// assert
|
|
expect(totalExecution).to.equal(1);
|
|
});
|
|
});
|
|
});
|
|
|
|
class SystemUnderTest extends ApplicationFactory {
|
|
public constructor(costlyGetter: ApplicationGetterType) {
|
|
super(costlyGetter);
|
|
}
|
|
}
|