This commit introduces 'Revert: None - Selected' toggle, enabling users to revert all reversible scripts with a single action, improving user safety and control over script effects. This feature addresses user-reported concerns about the ease of reverting script changes. This feature should enhance the user experience by streamlining the revert process along with providing essential information about script reversibility. Key changes: - Add buttons to revert all selected scripts or setting all selected scripts to non-revert state. - Add tooltips with detailed explanations about consequences of modifying revert states, includinginformation about irreversible script changes. Supporting changes: - Align items on top menu vertically for better visual consistency. - Rename `SelectionType` to `RecommendationStatusType` for more clarity. - Rename `IReverter` to `Reverter` to move away from `I` prefix convention. - The `.script` CSS class was duplicated in `TheScriptsView.vue` and `TheScriptsArea.vue`, leading to style collisions in the development environment. The class has been renamed to component-specific classes to avoid such issues in the future.
169 lines
6.4 KiB
TypeScript
169 lines
6.4 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import {
|
|
SelectionCheckContext, SelectionMutationContext,
|
|
getCurrentRecommendationStatus, setCurrentRecommendationStatus,
|
|
} from '@/presentation/components/Scripts/Menu/Recommendation/RecommendationStatusHandler';
|
|
import { RecommendationLevel } from '@/domain/RecommendationLevel';
|
|
import { ICategoryCollectionState } from '@/application/Context/State/ICategoryCollectionState';
|
|
import { EnumRangeTestRunner } from '@tests/unit/application/Common/EnumRangeTestRunner';
|
|
import { ScriptSelection } from '@/application/Context/State/Selection/Script/ScriptSelection';
|
|
import { MethodCall } from '@tests/unit/shared/Stubs/StubWithObservableMethodCalls';
|
|
import { expectExists } from '@tests/shared/Assertions/ExpectExists';
|
|
import { scrambledEqual } from '@/application/Common/Array';
|
|
import { IScript } from '@/domain/IScript';
|
|
import { RecommendationStatusType } from '@/presentation/components/Scripts/Menu/Recommendation/RecommendationStatusType';
|
|
import { RecommendationStatusTestScenario } from './RecommendationStatusTestScenario';
|
|
|
|
describe('RecommendationStatusHandler', () => {
|
|
describe('setCurrentRecommendationStatus', () => {
|
|
describe('throws with invalid type', () => {
|
|
// arrange
|
|
const scenario = new RecommendationStatusTestScenario();
|
|
const { stateStub } = scenario.generateState([]);
|
|
// act
|
|
const act = (type: RecommendationStatusType) => setCurrentRecommendationStatus(
|
|
type,
|
|
createMutationContext(stateStub),
|
|
);
|
|
// assert
|
|
new EnumRangeTestRunner(act)
|
|
.testInvalidValueThrows(RecommendationStatusType.Custom, 'Cannot select custom type.')
|
|
.testOutOfRangeThrows((value) => `Cannot handle the type: ${RecommendationStatusType[value]}`);
|
|
});
|
|
describe('select types as expected', () => {
|
|
// arrange
|
|
const scenario = new RecommendationStatusTestScenario();
|
|
const testScenarios: ReadonlyArray<{
|
|
readonly givenType: RecommendationStatusType;
|
|
readonly expectedCall: MethodCall<ScriptSelection>;
|
|
}> = [
|
|
{
|
|
givenType: RecommendationStatusType.None,
|
|
expectedCall: {
|
|
methodName: 'deselectAll',
|
|
args: [],
|
|
},
|
|
},
|
|
{
|
|
givenType: RecommendationStatusType.Standard,
|
|
expectedCall: {
|
|
methodName: 'selectOnly',
|
|
args: [
|
|
scenario.allStandard.map((s) => s.script),
|
|
],
|
|
},
|
|
},
|
|
{
|
|
givenType: RecommendationStatusType.Strict,
|
|
expectedCall: {
|
|
methodName: 'selectOnly',
|
|
args: [[
|
|
...scenario.allStandard.map((s) => s.script),
|
|
...scenario.allStrict.map((s) => s.script),
|
|
]],
|
|
},
|
|
},
|
|
{
|
|
givenType: RecommendationStatusType.All,
|
|
expectedCall: {
|
|
methodName: 'selectAll',
|
|
args: [],
|
|
},
|
|
},
|
|
];
|
|
testScenarios.forEach(({
|
|
givenType, expectedCall,
|
|
}) => {
|
|
it(`${RecommendationStatusType[givenType]} modifies as expected`, () => {
|
|
const { stateStub, scriptsStub } = scenario.generateState();
|
|
// act
|
|
setCurrentRecommendationStatus(givenType, createMutationContext(stateStub));
|
|
// assert
|
|
const call = scriptsStub.callHistory.find(
|
|
(c) => c.methodName === expectedCall.methodName,
|
|
);
|
|
expectExists(call);
|
|
if (expectedCall.args.length > 0) { /** {@link ScriptSelection.selectOnly}. */
|
|
expect(scrambledEqual(
|
|
call.args[0] as IScript[],
|
|
expectedCall.args[0] as IScript[],
|
|
)).to.equal(true);
|
|
}
|
|
});
|
|
});
|
|
});
|
|
});
|
|
describe('getCurrentRecommendationStatus', () => {
|
|
// arrange
|
|
const scenario = new RecommendationStatusTestScenario();
|
|
const testCases = [{
|
|
name: 'when nothing is selected',
|
|
selection: [],
|
|
expected: RecommendationStatusType.None,
|
|
}, {
|
|
name: 'when some standard scripts are selected',
|
|
selection: scenario.someStandard,
|
|
expected: RecommendationStatusType.Custom,
|
|
}, {
|
|
name: 'when all standard scripts are selected',
|
|
selection: scenario.allStandard,
|
|
expected: RecommendationStatusType.Standard,
|
|
}, {
|
|
name: 'when all standard and some strict scripts are selected',
|
|
selection: [...scenario.allStandard, ...scenario.someStrict],
|
|
expected: RecommendationStatusType.Custom,
|
|
}, {
|
|
name: 'when all standard and strict scripts are selected',
|
|
selection: [...scenario.allStandard, ...scenario.allStrict],
|
|
expected: RecommendationStatusType.Strict,
|
|
}, {
|
|
name: 'when strict scripts are selected but not standard',
|
|
selection: scenario.allStrict,
|
|
expected: RecommendationStatusType.Custom,
|
|
}, {
|
|
name: 'when all standard and strict, and some unrecommended are selected',
|
|
selection: [...scenario.allStandard, ...scenario.allStrict, ...scenario.someUnrecommended],
|
|
expected: RecommendationStatusType.Custom,
|
|
}, {
|
|
name: 'when all scripts are selected',
|
|
selection: scenario.all,
|
|
expected: RecommendationStatusType.All,
|
|
}];
|
|
for (const testCase of testCases) {
|
|
it(testCase.name, () => {
|
|
const { stateStub } = scenario.generateState(testCase.selection);
|
|
// act
|
|
const actual = getCurrentRecommendationStatus(createCheckContext(stateStub));
|
|
// assert
|
|
expect(actual).to.deep.equal(
|
|
testCase.expected,
|
|
`Actual: "${RecommendationStatusType[actual]}", expected: "${RecommendationStatusType[testCase.expected]}"`
|
|
+ `\nSelection: ${printSelection()}`,
|
|
);
|
|
function printSelection() {
|
|
// eslint-disable-next-line prefer-template
|
|
return `total: ${testCase.selection.length}\n`
|
|
+ 'scripts:\n'
|
|
+ testCase.selection
|
|
.map((s) => `{ id: ${s.script.id}, level: ${s.script.level === undefined ? 'unknown' : RecommendationLevel[s.script.level]} }`)
|
|
.join(' | ');
|
|
}
|
|
});
|
|
}
|
|
});
|
|
});
|
|
|
|
function createMutationContext(state: ICategoryCollectionState): SelectionMutationContext {
|
|
return {
|
|
selection: state.selection.scripts,
|
|
collection: state.collection,
|
|
};
|
|
}
|
|
|
|
function createCheckContext(state: ICategoryCollectionState): SelectionCheckContext {
|
|
return {
|
|
selection: state.selection.scripts,
|
|
collection: state.collection,
|
|
};
|
|
}
|