This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
45 lines
1.6 KiB
TypeScript
45 lines
1.6 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { ISanityCheckOptions } from '@/infrastructure/RuntimeSanity/Common/ISanityCheckOptions';
|
|
import { RuntimeSanityValidator } from '@/presentation/bootstrapping/Modules/RuntimeSanityValidator';
|
|
import { expectDoesNotThrowAsync, expectThrowsAsync } from '@tests/shared/Assertions/ExpectThrowsAsync';
|
|
|
|
describe('RuntimeSanityValidator', () => {
|
|
it('calls validator with correct options upon bootstrap', async () => {
|
|
// arrange
|
|
const expectedOptions: ISanityCheckOptions = {
|
|
validateEnvironmentVariables: true,
|
|
validateWindowVariables: true,
|
|
};
|
|
let actualOptions: ISanityCheckOptions | undefined;
|
|
const validatorMock = (options) => {
|
|
actualOptions = options;
|
|
};
|
|
const sut = new RuntimeSanityValidator(validatorMock);
|
|
// act
|
|
await sut.bootstrap();
|
|
// assert
|
|
expect(actualOptions).to.deep.equal(expectedOptions);
|
|
});
|
|
it('propagates the error if validator fails', async () => {
|
|
// arrange
|
|
const expectedMessage = 'message thrown from validator';
|
|
const validatorMock = () => {
|
|
throw new Error(expectedMessage);
|
|
};
|
|
const sut = new RuntimeSanityValidator(validatorMock);
|
|
// act
|
|
const act = async () => { await sut.bootstrap(); };
|
|
// assert
|
|
await expectThrowsAsync(act, expectedMessage);
|
|
});
|
|
it('runs successfully if validator passes', async () => {
|
|
// arrange
|
|
const validatorMock = () => { /* NOOP */ };
|
|
const sut = new RuntimeSanityValidator(validatorMock);
|
|
// act
|
|
const act = async () => { await sut.bootstrap(); };
|
|
// assert
|
|
await expectDoesNotThrowAsync(act);
|
|
});
|
|
});
|