This commit adds validation logic in compiler to check for max allowed characters per line for scripts. This allows preventing bugs caused by limitation of terminal emulators. Other supporting changes: - Rename/refactor related code for clarity and better maintainability. - Drop `I` prefix from interfaces to align with latest convention. - Refactor CodeValidator to be functional rather than object-oriented for simplicity. - Refactor syntax definition construction to be functional and be part of rule for better separation of concerns. - Refactored validation logic to use an enum-based factory pattern for improved maintainability and scalability.
32 lines
1.2 KiB
TypeScript
32 lines
1.2 KiB
TypeScript
import type { LanguageSyntax } from '@/application/Parser/Executable/Script/Validation/Analyzers/Syntax/LanguageSyntax';
|
|
import { ScriptingLanguage } from '@/domain/ScriptingLanguage';
|
|
import type { SyntaxFactory } from '@/application/Parser/Executable/Script/Validation/Analyzers/Syntax/SyntaxFactory';
|
|
import { LanguageSyntaxStub } from './LanguageSyntaxStub';
|
|
|
|
interface PredeterminedSyntax {
|
|
readonly givenLanguage: ScriptingLanguage;
|
|
readonly predeterminedSyntax: LanguageSyntax;
|
|
}
|
|
|
|
export class SyntaxFactoryStub {
|
|
private readonly predeterminedResults = new Array<PredeterminedSyntax>();
|
|
|
|
public withPredeterminedSyntax(scenario: PredeterminedSyntax): this {
|
|
this.predeterminedResults.push(scenario);
|
|
return this;
|
|
}
|
|
|
|
public get(): SyntaxFactory {
|
|
return (language): LanguageSyntax => {
|
|
const results = this.predeterminedResults.filter((r) => r.givenLanguage === language);
|
|
if (results.length === 0) {
|
|
return new LanguageSyntaxStub();
|
|
}
|
|
if (results.length > 1) {
|
|
throw new Error(`Logical error: More than single predetermined results for ${ScriptingLanguage[language]}`);
|
|
}
|
|
return results[0].predeterminedSyntax;
|
|
};
|
|
}
|
|
}
|