e9e0001ef8
Enable `contextIsolation` in Electron to securely expose a limited set of Node.js APIs to the renderer process. It: 1. Isolates renderer and main process contexts. It ensures that the powerful main process functions aren't directly accessible from renderer process(es), adding a security boundary. 2. Mitigates remote exploitation risks. By isolating contexts, potential malicious code injections in the renderer can't directly reach and compromise the main process. 3. Reduces attack surface. 4. Protect against prototype pollution: It prevents tampering of JavaScript object prototypes in one context from affecting another context, improving app reliability and security. Supporting changes include: - Extract environment and system operations classes to the infrastructure layer. This removes node dependencies from core domain and application code. - Introduce `ISystemOperations` to encapsulate OS interactions. Use it from `CodeRunner` to isolate node API usage. - Add a preloader script to inject validated environment variables into renderer context. This keeps Electron integration details encapsulated. - Add new sanity check to fail fast on issues with preloader injected variables. - Improve test coverage of runtime sanity checks and environment components. Move validation logic into separate classes for Single Responsibility. - Improve absent value test case generation.
88 lines
2.6 KiB
TypeScript
88 lines
2.6 KiB
TypeScript
import { describe, it } from 'vitest';
|
|
import { NodeDataError, INodeDataErrorContext } from '@/application/Parser/NodeValidation/NodeDataError';
|
|
import { NodeData } from '@/application/Parser/NodeValidation/NodeData';
|
|
import { getAbsentObjectTestCases, getAbsentStringTestCases, itEachAbsentTestCase } from '@tests/unit/shared/TestCases/AbsentTests';
|
|
import { expectThrowsError } from '@tests/unit/shared/Assertions/ExpectThrowsError';
|
|
|
|
export interface ITestScenario {
|
|
readonly act: () => void;
|
|
readonly expectedContext: INodeDataErrorContext;
|
|
}
|
|
|
|
export class NodeValidationTestRunner {
|
|
public testInvalidNodeName(
|
|
testBuildPredicate: (invalidName: string) => ITestScenario,
|
|
) {
|
|
describe('throws given invalid names', () => {
|
|
// arrange
|
|
const testCases = [
|
|
...getAbsentStringTestCases().map((testCase) => ({
|
|
testName: `missing name (${testCase.valueName})`,
|
|
nameValue: testCase.absentValue,
|
|
expectedMessage: 'missing name',
|
|
})),
|
|
{
|
|
testName: 'invalid type',
|
|
nameValue: 33,
|
|
expectedMessage: 'Name (33) is not a string but number.',
|
|
},
|
|
];
|
|
for (const testCase of testCases) {
|
|
it(`given "${testCase.testName}"`, () => {
|
|
const test = testBuildPredicate(testCase.nameValue as never);
|
|
expectThrowsNodeError(test, testCase.expectedMessage);
|
|
});
|
|
}
|
|
});
|
|
return this;
|
|
}
|
|
|
|
public testMissingNodeData(
|
|
testBuildPredicate: (missingNode: NodeData) => ITestScenario,
|
|
) {
|
|
describe('throws given missing node data', () => {
|
|
itEachAbsentTestCase([
|
|
...getAbsentObjectTestCases(),
|
|
{
|
|
valueName: 'empty object',
|
|
absentValue: {},
|
|
},
|
|
], (absentValue) => {
|
|
// arrange
|
|
const expectedError = 'missing node data';
|
|
// act
|
|
const test = testBuildPredicate(absentValue as NodeData);
|
|
// assert
|
|
expectThrowsNodeError(test, expectedError);
|
|
});
|
|
});
|
|
return this;
|
|
}
|
|
|
|
public runThrowingCase(
|
|
testCase: {
|
|
readonly name: string,
|
|
readonly scenario: ITestScenario,
|
|
readonly expectedMessage: string
|
|
},
|
|
) {
|
|
it(testCase.name, () => {
|
|
expectThrowsNodeError(testCase.scenario, testCase.expectedMessage);
|
|
});
|
|
return this;
|
|
}
|
|
}
|
|
|
|
export function expectThrowsNodeError(
|
|
test: ITestScenario,
|
|
expectedMessage: string,
|
|
) {
|
|
// arrange
|
|
const expected = new NodeDataError(expectedMessage, test.expectedContext);
|
|
// act
|
|
const act = () => test.act();
|
|
// assert
|
|
expectThrowsError(act, expected);
|
|
return this;
|
|
}
|