This commit unifies the concepts of executables having same ID structure. It paves the way for more complex ID structure and using IDs in collection files as part of new ID solution (#262). Using string IDs also leads to more expressive test code. This commit also refactors the rest of the code to adopt to the changes. This commit: - Separate concerns from entities for data access (in repositories) and executables. Executables use `Identifiable` meanwhile repositories use `RepositoryEntity`. - Refactor unnecessary generic parameters for enttities and ids, enforcing string gtype everwyhere. - Changes numeric IDs to string IDs for categories to unify the retrieval and construction for executables, using pseudo-ids (their names) just like scripts. - Remove `BaseEntity` for simplicity. - Simplify usage and construction of executable objects. Move factories responsible for creation of category/scripts to domain layer. Do not longer export `CollectionCategorY` and `CollectionScript`. - Use named typed for string IDs for better differentation of different ID contexts in code.
103 lines
4.8 KiB
TypeScript
103 lines
4.8 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { OperatingSystem } from '@/domain/OperatingSystem';
|
|
import type { ICategoryCollection } from '@/domain/Collection/ICategoryCollection';
|
|
import { buildContext } from '@/application/Context/ApplicationContextFactory';
|
|
import type { IApplicationFactory } from '@/application/IApplicationFactory';
|
|
import type { IApplication } from '@/domain/IApplication';
|
|
import { RuntimeEnvironmentStub } from '@tests/unit/shared/Stubs/RuntimeEnvironmentStub';
|
|
import { ApplicationStub } from '@tests/unit/shared/Stubs/ApplicationStub';
|
|
import { CategoryCollectionStub } from '@tests/unit/shared/Stubs/CategoryCollectionStub';
|
|
|
|
describe('ApplicationContextFactory', () => {
|
|
describe('buildContext', () => {
|
|
describe('factory', () => {
|
|
it('sets application from factory', async () => {
|
|
// arrange
|
|
const expected = new ApplicationStub().withCollection(
|
|
new CategoryCollectionStub().withOs(OperatingSystem.macOS),
|
|
);
|
|
const factoryMock = mockFactoryWithApp(expected);
|
|
// act
|
|
const context = await buildContext(factoryMock);
|
|
// assert
|
|
expect(expected).to.equal(context.app);
|
|
});
|
|
});
|
|
describe('environment', () => {
|
|
describe('sets initial OS as expected', () => {
|
|
it('returns current OS if it is supported', async () => {
|
|
// arrange
|
|
const expected = OperatingSystem.Windows;
|
|
const environment = new RuntimeEnvironmentStub().withOs(expected);
|
|
const collection = new CategoryCollectionStub().withOs(expected);
|
|
const factoryMock = mockFactoryWithCollection(collection);
|
|
// act
|
|
const context = await buildContext(factoryMock, environment);
|
|
// assert
|
|
const actual = context.state.os;
|
|
expect(expected).to.equal(actual);
|
|
});
|
|
it('fallbacks to other OS if OS in environment is not supported', async () => {
|
|
// arrange
|
|
const expected = OperatingSystem.Windows;
|
|
const currentOs = OperatingSystem.macOS;
|
|
const environment = new RuntimeEnvironmentStub().withOs(currentOs);
|
|
const collection = new CategoryCollectionStub().withOs(expected);
|
|
const factoryMock = mockFactoryWithCollection(collection);
|
|
// act
|
|
const context = await buildContext(factoryMock, environment);
|
|
// assert
|
|
const actual = context.state.os;
|
|
expect(expected).to.equal(actual);
|
|
});
|
|
it('fallbacks to most supported OS if current OS is not supported', async () => {
|
|
// arrange
|
|
const runtimeOs = OperatingSystem.macOS;
|
|
const expectedOs = OperatingSystem.Android;
|
|
const allCollections = [
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Linux).withTotalScripts(3),
|
|
new CategoryCollectionStub().withOs(expectedOs).withTotalScripts(5),
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Windows).withTotalScripts(4),
|
|
];
|
|
const environment = new RuntimeEnvironmentStub().withOs(runtimeOs);
|
|
const app = new ApplicationStub().withCollections(...allCollections);
|
|
const factoryMock = mockFactoryWithApp(app);
|
|
// act
|
|
const context = await buildContext(factoryMock, environment);
|
|
// assert
|
|
const actual = context.state.os;
|
|
expect(expectedOs).to.equal(actual, `Expected: ${OperatingSystem[expectedOs]}, actual: ${OperatingSystem[actual]}`);
|
|
});
|
|
it('fallbacks to most supported OS if current OS is undefined', async () => {
|
|
// arrange
|
|
const runtimeOs = OperatingSystem.macOS;
|
|
const expectedOs = OperatingSystem.Android;
|
|
const allCollections = [
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Linux).withTotalScripts(3),
|
|
new CategoryCollectionStub().withOs(expectedOs).withTotalScripts(5),
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Windows).withTotalScripts(4),
|
|
];
|
|
const environment = new RuntimeEnvironmentStub().withOs(runtimeOs);
|
|
const app = new ApplicationStub().withCollections(...allCollections);
|
|
const factoryMock = mockFactoryWithApp(app);
|
|
// act
|
|
const context = await buildContext(factoryMock, environment);
|
|
// assert
|
|
const actual = context.state.os;
|
|
expect(expectedOs).to.equal(actual, `Expected: ${OperatingSystem[expectedOs]}, actual: ${OperatingSystem[actual]}`);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
function mockFactoryWithCollection(result: ICategoryCollection): IApplicationFactory {
|
|
return mockFactoryWithApp(new ApplicationStub().withCollection(result));
|
|
}
|
|
|
|
function mockFactoryWithApp(app: IApplication): IApplicationFactory {
|
|
return {
|
|
getApp: () => Promise.resolve(app),
|
|
};
|
|
}
|