This commit introduces a custom error object to provide additional context for errors throwing during parsing and compiling operations, improving troubleshooting. By integrating error context handling, the error messages become more informative and user-friendly, providing sequence of trace with context to aid in troubleshooting. Changes include: - Introduce custom error object that extends errors with contextual information. This replaces previous usages of `AggregateError` which is not displayed well by browsers when logged. - Improve parsing functions to encapsulate error context with more details. - Increase unit test coverage and refactor the related code to be more testable.
36 lines
1.3 KiB
TypeScript
36 lines
1.3 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { FunctionParameterCollection } from '@/application/Parser/Script/Compiler/Function/Parameter/FunctionParameterCollection';
|
|
import { FunctionParameterStub } from '@tests/unit/shared/Stubs/FunctionParameterStub';
|
|
|
|
describe('FunctionParameterCollection', () => {
|
|
it('all returns added parameters as expected', () => {
|
|
// arrange
|
|
const expected = [
|
|
new FunctionParameterStub().withName('1'),
|
|
new FunctionParameterStub().withName('2').withOptional(true),
|
|
new FunctionParameterStub().withName('3').withOptional(false),
|
|
];
|
|
const sut = new FunctionParameterCollection();
|
|
for (const parameter of expected) {
|
|
sut.addParameter(parameter);
|
|
}
|
|
// act
|
|
const actual = sut.all;
|
|
// assert
|
|
expect(expected).to.deep.equal(actual);
|
|
});
|
|
it('throws when function parameters have same names', () => {
|
|
// arrange
|
|
const parameterName = 'duplicate-parameter';
|
|
const expectedError = `duplicate parameter name: "${parameterName}"`;
|
|
const sut = new FunctionParameterCollection();
|
|
sut.addParameter(new FunctionParameterStub().withName(parameterName));
|
|
// act
|
|
const act = () => sut.addParameter(
|
|
new FunctionParameterStub().withName(parameterName),
|
|
);
|
|
// assert
|
|
expect(act).to.throw(expectedError);
|
|
});
|
|
});
|