This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
103 lines
4.8 KiB
TypeScript
103 lines
4.8 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { OperatingSystem } from '@/domain/OperatingSystem';
|
|
import { ICategoryCollection } from '@/domain/ICategoryCollection';
|
|
import { buildContext } from '@/application/Context/ApplicationContextFactory';
|
|
import { IApplicationFactory } from '@/application/IApplicationFactory';
|
|
import { IApplication } from '@/domain/IApplication';
|
|
import { RuntimeEnvironmentStub } from '@tests/unit/shared/Stubs/RuntimeEnvironmentStub';
|
|
import { ApplicationStub } from '@tests/unit/shared/Stubs/ApplicationStub';
|
|
import { CategoryCollectionStub } from '@tests/unit/shared/Stubs/CategoryCollectionStub';
|
|
|
|
describe('ApplicationContextFactory', () => {
|
|
describe('buildContext', () => {
|
|
describe('factory', () => {
|
|
it('sets application from factory', async () => {
|
|
// arrange
|
|
const expected = new ApplicationStub().withCollection(
|
|
new CategoryCollectionStub().withOs(OperatingSystem.macOS),
|
|
);
|
|
const factoryMock = mockFactoryWithApp(expected);
|
|
// act
|
|
const context = await buildContext(factoryMock);
|
|
// assert
|
|
expect(expected).to.equal(context.app);
|
|
});
|
|
});
|
|
describe('environment', () => {
|
|
describe('sets initial OS as expected', () => {
|
|
it('returns current OS if it is supported', async () => {
|
|
// arrange
|
|
const expected = OperatingSystem.Windows;
|
|
const environment = new RuntimeEnvironmentStub().withOs(expected);
|
|
const collection = new CategoryCollectionStub().withOs(expected);
|
|
const factoryMock = mockFactoryWithCollection(collection);
|
|
// act
|
|
const context = await buildContext(factoryMock, environment);
|
|
// assert
|
|
const actual = context.state.os;
|
|
expect(expected).to.equal(actual);
|
|
});
|
|
it('fallbacks to other OS if OS in environment is not supported', async () => {
|
|
// arrange
|
|
const expected = OperatingSystem.Windows;
|
|
const currentOs = OperatingSystem.macOS;
|
|
const environment = new RuntimeEnvironmentStub().withOs(currentOs);
|
|
const collection = new CategoryCollectionStub().withOs(expected);
|
|
const factoryMock = mockFactoryWithCollection(collection);
|
|
// act
|
|
const context = await buildContext(factoryMock, environment);
|
|
// assert
|
|
const actual = context.state.os;
|
|
expect(expected).to.equal(actual);
|
|
});
|
|
it('fallbacks to most supported OS if current OS is not supported', async () => {
|
|
// arrange
|
|
const runtimeOs = OperatingSystem.macOS;
|
|
const expectedOs = OperatingSystem.Android;
|
|
const allCollections = [
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Linux).withTotalScripts(3),
|
|
new CategoryCollectionStub().withOs(expectedOs).withTotalScripts(5),
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Windows).withTotalScripts(4),
|
|
];
|
|
const environment = new RuntimeEnvironmentStub().withOs(runtimeOs);
|
|
const app = new ApplicationStub().withCollections(...allCollections);
|
|
const factoryMock = mockFactoryWithApp(app);
|
|
// act
|
|
const context = await buildContext(factoryMock, environment);
|
|
// assert
|
|
const actual = context.state.os;
|
|
expect(expectedOs).to.equal(actual, `Expected: ${OperatingSystem[expectedOs]}, actual: ${OperatingSystem[actual]}`);
|
|
});
|
|
it('fallbacks to most supported OS if current OS is undefined', async () => {
|
|
// arrange
|
|
const runtimeOs = OperatingSystem.macOS;
|
|
const expectedOs = OperatingSystem.Android;
|
|
const allCollections = [
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Linux).withTotalScripts(3),
|
|
new CategoryCollectionStub().withOs(expectedOs).withTotalScripts(5),
|
|
new CategoryCollectionStub().withOs(OperatingSystem.Windows).withTotalScripts(4),
|
|
];
|
|
const environment = new RuntimeEnvironmentStub().withOs(runtimeOs);
|
|
const app = new ApplicationStub().withCollections(...allCollections);
|
|
const factoryMock = mockFactoryWithApp(app);
|
|
// act
|
|
const context = await buildContext(factoryMock, environment);
|
|
// assert
|
|
const actual = context.state.os;
|
|
expect(expectedOs).to.equal(actual, `Expected: ${OperatingSystem[expectedOs]}, actual: ${OperatingSystem[actual]}`);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
function mockFactoryWithCollection(result: ICategoryCollection): IApplicationFactory {
|
|
return mockFactoryWithApp(new ApplicationStub().withCollection(result));
|
|
}
|
|
|
|
function mockFactoryWithApp(app: IApplication): IApplicationFactory {
|
|
return {
|
|
getApp: () => Promise.resolve(app),
|
|
};
|
|
}
|