5b1fbe1e2f
Major refactoring using ESLint with rules from AirBnb and Vue. Enable most of the ESLint rules and do necessary linting in the code. Also add more information for rules that are disabled to describe what they are and why they are disabled. Allow logging (`console.log`) in test files, and in development mode (e.g. when working with `npm run serve`), but disable it when environment is production (as pre-configured by Vue). Also add flag (`--mode production`) in `lint:eslint` command so production linting is executed earlier in lifecycle. Disable rules that requires a separate work. Such as ESLint rules that are broken in TypeScript: no-useless-constructor (eslint/eslint#14118) and no-shadow (eslint/eslint#13014).
49 lines
1.7 KiB
TypeScript
49 lines
1.7 KiB
TypeScript
import 'mocha';
|
|
import { expect } from 'chai';
|
|
import { FunctionParameterCollection } from '@/application/Parser/Script/Compiler/Function/Parameter/FunctionParameterCollection';
|
|
import { FunctionParameterStub } from '@tests/unit/stubs/FunctionParameterStub';
|
|
|
|
describe('FunctionParameterCollection', () => {
|
|
it('all returns added parameters as expected', () => {
|
|
// arrange
|
|
const expected = [
|
|
new FunctionParameterStub().withName('1'),
|
|
new FunctionParameterStub().withName('2').withOptionality(true),
|
|
new FunctionParameterStub().withName('3').withOptionality(false),
|
|
];
|
|
const sut = new FunctionParameterCollection();
|
|
for (const parameter of expected) {
|
|
sut.addParameter(parameter);
|
|
}
|
|
// act
|
|
const actual = sut.all;
|
|
// assert
|
|
expect(expected).to.deep.equal(actual);
|
|
});
|
|
it('throws when function parameters have same names', () => {
|
|
// arrange
|
|
const parameterName = 'duplicate-parameter';
|
|
const expectedError = `duplicate parameter name: "${parameterName}"`;
|
|
const sut = new FunctionParameterCollection();
|
|
sut.addParameter(new FunctionParameterStub().withName(parameterName));
|
|
// act
|
|
const act = () => sut.addParameter(
|
|
new FunctionParameterStub().withName(parameterName),
|
|
);
|
|
// assert
|
|
expect(act).to.throw(expectedError);
|
|
});
|
|
describe('addParameter', () => {
|
|
it('throws if parameter is undefined', () => {
|
|
// arrange
|
|
const expectedError = 'undefined parameter';
|
|
const value = undefined;
|
|
const sut = new FunctionParameterCollection();
|
|
// act
|
|
const act = () => sut.addParameter(value);
|
|
// assert
|
|
expect(act).to.throw(expectedError);
|
|
});
|
|
});
|
|
});
|