949fac1a7c
This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
62 lines
1.9 KiB
TypeScript
62 lines
1.9 KiB
TypeScript
import { describe } from 'vitest';
|
|
import { OperatingSystem } from '@/domain/OperatingSystem';
|
|
import { convertPlatformToOs } from '@/presentation/electron/preload/NodeOsMapper';
|
|
|
|
describe('NodeOsMapper', () => {
|
|
describe('convertPlatformToOs', () => {
|
|
describe('determines desktop OS', () => {
|
|
// arrange
|
|
interface IDesktopTestCase {
|
|
readonly nodePlatform: NodeJS.Platform;
|
|
readonly expectedOs: ReturnType<typeof convertPlatformToOs>;
|
|
}
|
|
const testScenarios: readonly IDesktopTestCase[] = [ // https://nodejs.org/api/process.html#process_process_platform
|
|
{
|
|
nodePlatform: 'aix',
|
|
expectedOs: undefined,
|
|
},
|
|
{
|
|
nodePlatform: 'darwin',
|
|
expectedOs: OperatingSystem.macOS,
|
|
},
|
|
{
|
|
nodePlatform: 'freebsd',
|
|
expectedOs: undefined,
|
|
},
|
|
{
|
|
nodePlatform: 'linux',
|
|
expectedOs: OperatingSystem.Linux,
|
|
},
|
|
{
|
|
nodePlatform: 'openbsd',
|
|
expectedOs: undefined,
|
|
},
|
|
{
|
|
nodePlatform: 'sunos',
|
|
expectedOs: undefined,
|
|
},
|
|
{
|
|
nodePlatform: 'win32',
|
|
expectedOs: OperatingSystem.Windows,
|
|
},
|
|
];
|
|
testScenarios.forEach(({ nodePlatform, expectedOs }) => {
|
|
it(nodePlatform, () => {
|
|
// act
|
|
const actualOs = convertPlatformToOs(nodePlatform);
|
|
// assert
|
|
expect(actualOs).to.equal(expectedOs, printMessage());
|
|
function printResult(os: ReturnType<typeof convertPlatformToOs>): string {
|
|
return os === undefined ? 'undefined' : OperatingSystem[os];
|
|
}
|
|
function printMessage(): string {
|
|
return `Expected: "${printResult(expectedOs)}"\n`
|
|
+ `Actual: "${printResult(actualOs)}"\n`
|
|
+ `Platform: "${nodePlatform}"`;
|
|
}
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|