949fac1a7c
This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
72 lines
2.9 KiB
TypeScript
72 lines
2.9 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { ISyntaxFactory } from '@/application/Parser/Script/Validation/Syntax/ISyntaxFactory';
|
|
import { ScriptingLanguage } from '@/domain/ScriptingLanguage';
|
|
import { CategoryCollectionParseContext } from '@/application/Parser/Script/CategoryCollectionParseContext';
|
|
import { ScriptCompiler } from '@/application/Parser/Script/Compiler/ScriptCompiler';
|
|
import { LanguageSyntaxStub } from '@tests/unit/shared/Stubs/LanguageSyntaxStub';
|
|
import { ScriptingDefinitionStub } from '@tests/unit/shared/Stubs/ScriptingDefinitionStub';
|
|
import type { FunctionData } from '@/application/collections/';
|
|
import { itEachAbsentCollectionValue } from '@tests/unit/shared/TestCases/AbsentTests';
|
|
import { ILanguageSyntax } from '@/application/Parser/Script/Validation/Syntax/ILanguageSyntax';
|
|
import { createFunctionDataWithCode } from '@tests/unit/shared/Stubs/FunctionDataStub';
|
|
|
|
describe('CategoryCollectionParseContext', () => {
|
|
describe('ctor', () => {
|
|
describe('functionsData', () => {
|
|
describe('can create with absent data', () => {
|
|
itEachAbsentCollectionValue<FunctionData>((absentValue) => {
|
|
// arrange
|
|
const scripting = new ScriptingDefinitionStub();
|
|
// act
|
|
const act = () => new CategoryCollectionParseContext(absentValue, scripting);
|
|
// assert
|
|
expect(act).to.not.throw();
|
|
}, { excludeNull: true });
|
|
});
|
|
});
|
|
});
|
|
describe('compiler', () => {
|
|
it('constructed as expected', () => {
|
|
// arrange
|
|
const functionsData = [createFunctionDataWithCode()];
|
|
const syntax = new LanguageSyntaxStub();
|
|
const expected = new ScriptCompiler(functionsData, syntax);
|
|
const language = ScriptingLanguage.shellscript;
|
|
const factoryMock = mockFactory(language, syntax);
|
|
const definition = new ScriptingDefinitionStub()
|
|
.withLanguage(language);
|
|
// act
|
|
const sut = new CategoryCollectionParseContext(functionsData, definition, factoryMock);
|
|
const actual = sut.compiler;
|
|
// assert
|
|
expect(actual).to.deep.equal(expected);
|
|
});
|
|
});
|
|
describe('syntax', () => {
|
|
it('set from syntax factory', () => {
|
|
// arrange
|
|
const language = ScriptingLanguage.shellscript;
|
|
const expected = new LanguageSyntaxStub();
|
|
const factoryMock = mockFactory(language, expected);
|
|
const definition = new ScriptingDefinitionStub()
|
|
.withLanguage(language);
|
|
// act
|
|
const sut = new CategoryCollectionParseContext([], definition, factoryMock);
|
|
const actual = sut.syntax;
|
|
// assert
|
|
expect(actual).to.equal(expected);
|
|
});
|
|
});
|
|
});
|
|
|
|
function mockFactory(expectedLanguage: ScriptingLanguage, result: ILanguageSyntax): ISyntaxFactory {
|
|
return {
|
|
create: (language: ScriptingLanguage) => {
|
|
if (language !== expectedLanguage) {
|
|
throw new Error('unexpected language');
|
|
}
|
|
return result;
|
|
},
|
|
};
|
|
}
|