As part of transition to Vue 3.0 and Vite (#230), this commit facilitates the shift towards building rest of the application using Vite. By doing so, it eliminates reliance on outdated Electron building system that offered limited control, blocking desktop builds (#233). Changes include: - Introduce Vite with Vue 2.0 plugin for test execution. - Remove `mocha`, `chai` and other related dependencies. - Adjust test to Vitest syntax. - Revise and update `tests.md` to document the changes. - Add `@modyfi/vite-plugin-yaml` plugin to be able to use yaml file depended logic on test files, replacing previous webpack behavior. - Fix failing tests that are revealed by Vitest due to unhandled errors and lack of assertments. - Remove the test that depends on Vue CLI populating `process.env`. - Use `jsdom` for unit test environment, adding it to dependency to `package.json` as project now depends on it and it was not specified even though `package-lock.json` included it.
93 lines
4.0 KiB
TypeScript
93 lines
4.0 KiB
TypeScript
import { describe, expect } from 'vitest';
|
|
import { itEachAbsentObjectValue } from '@tests/unit/shared/TestCases/AbsentTests';
|
|
import { NoDuplicatedLines } from '@/application/Parser/Script/Validation/Rules/NoDuplicatedLines';
|
|
import { LanguageSyntaxStub } from '@tests/unit/shared/Stubs/LanguageSyntaxStub';
|
|
import { IInvalidCodeLine } from '@/application/Parser/Script/Validation/ICodeValidationRule';
|
|
import { testCodeValidationRule } from './CodeValidationRuleTestRunner';
|
|
|
|
describe('NoDuplicatedLines', () => {
|
|
describe('ctor', () => {
|
|
describe('throws if syntax is missing', () => {
|
|
itEachAbsentObjectValue((absentValue) => {
|
|
// arrange
|
|
const expectedError = 'missing syntax';
|
|
const syntax = absentValue;
|
|
// act
|
|
const act = () => new NoDuplicatedLines(syntax);
|
|
// assert
|
|
expect(act).to.throw(expectedError);
|
|
});
|
|
});
|
|
});
|
|
describe('analyze', () => {
|
|
testCodeValidationRule([
|
|
{
|
|
testName: 'no results when code is valid',
|
|
codeLines: ['unique1', 'unique2', 'unique3', 'unique4'],
|
|
expected: [],
|
|
sut: new NoDuplicatedLines(new LanguageSyntaxStub()),
|
|
},
|
|
{
|
|
testName: 'detects single duplicated line as expected',
|
|
codeLines: ['duplicate', 'duplicate', 'unique', 'duplicate'],
|
|
expected: expectInvalidCodeLines([1, 2, 4]),
|
|
sut: new NoDuplicatedLines(new LanguageSyntaxStub()),
|
|
},
|
|
{
|
|
testName: 'detects multiple duplicated lines as expected',
|
|
codeLines: ['duplicate1', 'duplicate2', 'unique', 'duplicate1', 'unique2', 'duplicate2'],
|
|
expected: expectInvalidCodeLines([1, 4], [2, 6]),
|
|
sut: new NoDuplicatedLines(new LanguageSyntaxStub()),
|
|
},
|
|
{
|
|
testName: 'common code parts: does not detect multiple common code part usages as duplicates',
|
|
codeLines: ['good', 'good', 'bad', 'bad', 'good', 'also-good', 'also-good', 'unique'],
|
|
expected: expectInvalidCodeLines([3, 4]),
|
|
sut: new NoDuplicatedLines(new LanguageSyntaxStub()
|
|
.withCommonCodeParts('good', 'also-good')),
|
|
},
|
|
{
|
|
testName: 'common code parts: does not detect multiple common code part used in same code line as duplicates',
|
|
codeLines: ['bad', 'bad', 'good1 good2', 'good1 good2', 'good2 good1', 'good2 good1'],
|
|
expected: expectInvalidCodeLines([1, 2]),
|
|
sut: new NoDuplicatedLines(new LanguageSyntaxStub()
|
|
.withCommonCodeParts('good2', 'good1')),
|
|
},
|
|
{
|
|
testName: 'common code parts: detects when common code parts used in conjunction with unique words',
|
|
codeLines: [
|
|
'common-part1', 'common-part1', 'common-part1 common-part2', 'common-part1 unique', 'common-part1 unique',
|
|
'common-part2', 'common-part2 common-part1', 'unique common-part2', 'unique common-part2',
|
|
],
|
|
expected: expectInvalidCodeLines([4, 5], [8, 9]),
|
|
sut: new NoDuplicatedLines(new LanguageSyntaxStub()
|
|
.withCommonCodeParts('common-part1', 'common-part2')),
|
|
},
|
|
{
|
|
testName: 'comments: does not when lines start with comment',
|
|
codeLines: ['#abc', '#abc', 'abc', 'unique', 'abc', '//abc', '//abc', '//unique', '#unique'],
|
|
expected: expectInvalidCodeLines([3, 5]),
|
|
sut: new NoDuplicatedLines(new LanguageSyntaxStub()
|
|
.withCommentDelimiters('#', '//')),
|
|
},
|
|
{
|
|
testName: 'comments: does when comments come after lien start',
|
|
codeLines: ['test #comment', 'test #comment', 'test2 # comment', 'test2 # comment'],
|
|
expected: expectInvalidCodeLines([1, 2], [3, 4]),
|
|
sut: new NoDuplicatedLines(new LanguageSyntaxStub()
|
|
.withCommentDelimiters('#')),
|
|
},
|
|
]);
|
|
});
|
|
});
|
|
|
|
function expectInvalidCodeLines(
|
|
...lines: readonly ReadonlyArray<number>[]
|
|
): IInvalidCodeLine[] {
|
|
return lines.flatMap((occurrenceIndices): readonly IInvalidCodeLine[] => occurrenceIndices
|
|
.map((index): IInvalidCodeLine => ({
|
|
index,
|
|
error: `Line is duplicated at line numbers ${occurrenceIndices.join(',')}.`,
|
|
})));
|
|
}
|