949fac1a7c
This commit applies `strictNullChecks` to the entire codebase to improve maintainability and type safety. Key changes include: - Remove some explicit null-checks where unnecessary. - Add necessary null-checks. - Refactor static factory functions for a more functional approach. - Improve some test names and contexts for better debugging. - Add unit tests for any additional logic introduced. - Refactor `createPositionFromRegexFullMatch` to its own function as the logic is reused. - Prefer `find` prefix on functions that may return `undefined` and `get` prefix for those that always return a value.
113 lines
3.4 KiB
TypeScript
113 lines
3.4 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import {
|
|
getEnumNames, getEnumValues, createEnumParser, assertInRange,
|
|
} from '@/application/Common/Enum';
|
|
import { scrambledEqual } from '@/application/Common/Array';
|
|
import { getAbsentStringTestCases } from '@tests/unit/shared/TestCases/AbsentTests';
|
|
import { EnumRangeTestRunner } from './EnumRangeTestRunner';
|
|
|
|
describe('Enum', () => {
|
|
describe('createEnumParser', () => {
|
|
enum ParsableEnum { Value1, value2 }
|
|
describe('parses as expected', () => {
|
|
// arrange
|
|
const testCases = [
|
|
{
|
|
name: 'case insensitive',
|
|
value: 'vALuE1',
|
|
expected: ParsableEnum.Value1,
|
|
},
|
|
{
|
|
name: 'exact match',
|
|
value: 'value2',
|
|
expected: ParsableEnum.value2,
|
|
},
|
|
];
|
|
// act
|
|
for (const testCase of testCases) {
|
|
it(testCase.name, () => {
|
|
const parser = createEnumParser(ParsableEnum);
|
|
const actual = parser.parseEnum(testCase.value, 'non-important');
|
|
// assert
|
|
expect(actual).to.equal(testCase.expected);
|
|
});
|
|
}
|
|
});
|
|
describe('throws as expected', () => {
|
|
// arrange
|
|
const enumName = 'ParsableEnum';
|
|
const testScenarios: ReadonlyArray<{
|
|
readonly name: string;
|
|
readonly value: string;
|
|
readonly expectedError: string;
|
|
}> = [
|
|
...getAbsentStringTestCases({
|
|
excludeNull: true,
|
|
excludeUndefined: true,
|
|
}).map((test) => ({
|
|
name: test.valueName,
|
|
value: test.absentValue,
|
|
expectedError: `missing ${enumName}`,
|
|
})),
|
|
{
|
|
name: 'out of range',
|
|
value: 'value3',
|
|
expectedError: `unknown ${enumName}: "value3"`,
|
|
},
|
|
{
|
|
name: 'out of range',
|
|
value: 'value3',
|
|
expectedError: `unknown ${enumName}: "value3"`,
|
|
},
|
|
{
|
|
name: 'unexpected type',
|
|
value: 55 as never,
|
|
expectedError: `unexpected type of ${enumName}: "number"`,
|
|
},
|
|
];
|
|
// act
|
|
for (const testCase of testScenarios) {
|
|
it(testCase.name, () => {
|
|
const parser = createEnumParser(ParsableEnum);
|
|
const act = () => parser.parseEnum(testCase.value, enumName);
|
|
// assert
|
|
expect(act).to.throw(testCase.expectedError);
|
|
});
|
|
}
|
|
});
|
|
});
|
|
describe('getEnumNames', () => {
|
|
it('parses as expected', () => {
|
|
// arrange
|
|
enum TestEnum { TestValue1, testValue2, testvalue3, TESTVALUE4 }
|
|
const expected = ['TestValue1', 'testValue2', 'testvalue3', 'TESTVALUE4'];
|
|
// act
|
|
const actual = getEnumNames(TestEnum);
|
|
// assert
|
|
expect(scrambledEqual(expected, actual));
|
|
});
|
|
});
|
|
describe('getEnumValues', () => {
|
|
it('parses as expected', () => {
|
|
// arrange
|
|
enum TestEnum { Red, Green, Blue }
|
|
const expected = [TestEnum.Red, TestEnum.Green, TestEnum.Blue];
|
|
// act
|
|
const actual = getEnumValues(TestEnum);
|
|
// assert
|
|
expect(scrambledEqual(expected, actual));
|
|
});
|
|
});
|
|
describe('assertInRange', () => {
|
|
// arrange
|
|
enum TestEnum { Red, Green, Blue }
|
|
const validValue = TestEnum.Red;
|
|
// act
|
|
const act = (value: TestEnum) => assertInRange(value, TestEnum);
|
|
// assert
|
|
new EnumRangeTestRunner(act)
|
|
.testOutOfRangeThrows()
|
|
.testValidValueDoesNotThrow(validValue);
|
|
});
|
|
});
|