Improve disabling of Windows services

- Unify way of disabling Windows services using templating.
- Remove false-positive error messages.
- Use smarter logic to start/stop service.

Logic improvements include:
  - Check if service is running before stopping/starting the service.
  - Do not start the service it's not an Automatic service.
  - Do not write stderr if service cannot be stopped/started as it's not
    not the main goal of the function.
  - Check whether service is already disabled.

Add more documentation about the disabled Windows service.

Script: Disable diagnostics telemetry
 - Add missing revert script
 - Add more granular control for each service.

.editorconfig

@@ -1,7 +0,0 @@
-[*.{js,jsx,ts,tsx,vue}]
-indent_style = space
-indent_size = 2
-end_of_line = lf
-trim_trailing_whitespace = true
-insert_final_newline = true
-max_line_length = 100

.eslintrc.js

@@ -1,291 +0,0 @@
-const { rules: baseBestPracticesRules } = require('eslint-config-airbnb-base/rules/best-practices');
-const { rules: baseErrorsRules } = require('eslint-config-airbnb-base/rules/errors');
-const { rules: baseES6Rules } = require('eslint-config-airbnb-base/rules/es6');
-const { rules: baseImportsRules } = require('eslint-config-airbnb-base/rules/imports');
-const { rules: baseStyleRules } = require('eslint-config-airbnb-base/rules/style');
-const { rules: baseVariablesRules } = require('eslint-config-airbnb-base/rules/variables');
-const tsconfigJson = require('./tsconfig.json');
-
-module.exports = {
-  root: true,
-  env: {
-    node: true,
-  },
-  extends: [
-    // Vue specific rules, eslint-plugin-vue
-    // Added by Vue CLI
-    'plugin:vue/essential',
-
-    // Extends eslint-config-airbnb
-    // Added by Vue CLI
-    // Here until https://github.com/vuejs/eslint-config-airbnb/issues/23 is done
-    '@vue/airbnb',
-
-    // Extends @typescript-eslint/recommended
-    // Uses the recommended rules from the @typescript-eslint/eslint-plugin
-    // Added by Vue CLI
-    '@vue/typescript/recommended',
-  ],
-  parserOptions: {
-    ecmaVersion: 'latest',
-  },
-  rules: {
-    ...getOwnRules(),
-    ...getTurnedOffBrokenRules(),
-    ...getOpinionatedRuleOverrides(),
-    ...getTodoRules(),
-  },
-  overrides: [
-    {
-      files: [
-        '**/__tests__/*.{j,t}s?(x)',
-        '**/tests/unit/**/*.spec.{j,t}s?(x)',
-      ],
-      env: {
-        mocha: true,
-      },
-    },
-    {
-      files: ['**/*.ts?(x)', '**/*.d.ts'],
-      parserOptions: {
-        // Setting project is required for some rules such as @typescript-eslint/dot-notation,
-        // @typescript-eslint/return-await and @typescript-eslint/no-throw-literal.
-        // If this property is missing they fail due to missing parser.
-        project: ['./tsconfig.json'],
-      },
-      rules: {
-        ...getTypeScriptOverrides(),
-      },
-    },
-    {
-      files: ['**/tests/**/*.{j,t}s?(x)'],
-      rules: {
-        'no-console': 'off',
-      },
-    },
-  ],
-};
-
-function getOwnRules() {
-  return {
-    'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
-    'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
-    'linebreak-style': ['error', 'unix'], // This is also enforced in .editorconfig and .gitattributes files
-    'import/order': [ // Enforce strict import order taking account into aliases
-      'error',
-      {
-        groups: [ // Enforce more strict order than AirBnb
-          'builtin', 'external', 'internal', 'parent', 'sibling', 'index', 'object', 'type'],
-        pathGroups: [ // Fix manually configured paths being incorrectly grouped as "external"
-          ...getAliasesFromTsConfig(),
-          'js-yaml-loader!@/**',
-        ].map((pattern) => ({ pattern, group: 'internal' })),
-      },
-    ],
-  };
-}
-
-function getTodoRules() { // Should be worked on separate future commits
-  return {
-    'import/no-extraneous-dependencies': 'off',
-    // Accessibility improvements:
-    'vuejs-accessibility/form-control-has-label': 'off',
-    'vuejs-accessibility/click-events-have-key-events': 'off',
-    'vuejs-accessibility/anchor-has-content': 'off',
-    'vuejs-accessibility/accessible-emoji': 'off',
-  };
-}
-
-function getTurnedOffBrokenRules() {
-  return {
-    // Broken in TypeScript
-    'no-useless-constructor': 'off', // Cannot interpret TypeScript constructors
-    'no-shadow': 'off', // Fails with TypeScript enums
-  };
-}
-
-function getOpinionatedRuleOverrides() {
-  return {
-    // https://erkinekici.com/articles/linting-trap#no-use-before-define
-    'no-use-before-define': 'off',
-    // https://erkinekici.com/articles/linting-trap#arrow-body-style
-    'arrow-body-style': 'off',
-    // https://erkinekici.com/articles/linting-trap#no-plusplus
-    'no-plusplus': 'off',
-    // https://erkinekici.com/articles/linting-trap#no-param-reassign
-    'no-param-reassign': 'off',
-    // https://erkinekici.com/articles/linting-trap#class-methods-use-this
-    'class-methods-use-this': 'off',
-    // https://erkinekici.com/articles/linting-trap#importprefer-default-export
-    'import/prefer-default-export': 'off',
-    // https://erkinekici.com/articles/linting-trap#disallowing-for-of
-    // Original: https://github.com/airbnb/javascript/blob/d8cb404da74c302506f91e5928f30cc75109e74d/packages/eslint-config-airbnb-base/rules/style.js#L333-L351
-    'no-restricted-syntax': [
-      baseStyleRules['no-restricted-syntax'][0],
-      ...baseStyleRules['no-restricted-syntax'].slice(1).filter((rule) => rule.selector !== 'ForOfStatement'),
-    ],
-  };
-}
-
-function getTypeScriptOverrides() {
-  /*
-    Here until Vue supports AirBnb Typescript overrides (vuejs/eslint-config-airbnb#23).
-    Based on `eslint-config-airbnb-typescript`.
-      Source: https://github.com/iamturns/eslint-config-airbnb-typescript/blob/v16.1.0/lib/shared.js
-      It cannot be used directly due to compilation errors.
-  */
-  return {
-    'brace-style': 'off',
-    '@typescript-eslint/brace-style': baseStyleRules['brace-style'],
-
-    camelcase: 'off',
-    '@typescript-eslint/naming-convention': [
-      'error',
-      { selector: 'variable', format: ['camelCase', 'PascalCase', 'UPPER_CASE'] },
-      { selector: 'function', format: ['camelCase', 'PascalCase'] },
-      { selector: 'typeLike', format: ['PascalCase'] },
-    ],
-
-    'comma-dangle': 'off',
-    '@typescript-eslint/comma-dangle': [
-      baseStyleRules['comma-dangle'][0],
-      {
-        ...baseStyleRules['comma-dangle'][1],
-        enums: baseStyleRules['comma-dangle'][1].arrays,
-        generics: baseStyleRules['comma-dangle'][1].arrays,
-        tuples: baseStyleRules['comma-dangle'][1].arrays,
-      },
-    ],
-
-    'comma-spacing': 'off',
-    '@typescript-eslint/comma-spacing': baseStyleRules['comma-spacing'],
-
-    'default-param-last': 'off',
-    '@typescript-eslint/default-param-last': baseBestPracticesRules['default-param-last'],
-
-    'dot-notation': 'off',
-    '@typescript-eslint/dot-notation': baseBestPracticesRules['dot-notation'],
-
-    'func-call-spacing': 'off',
-    '@typescript-eslint/func-call-spacing': baseStyleRules['func-call-spacing'],
-
-    // ❌ Broken for some cases, but still useful.
-    // Here until Prettifier is used.
-    indent: 'off',
-    '@typescript-eslint/indent': baseStyleRules.indent,
-
-    'keyword-spacing': 'off',
-    '@typescript-eslint/keyword-spacing': baseStyleRules['keyword-spacing'],
-
-    'lines-between-class-members': 'off',
-    '@typescript-eslint/lines-between-class-members': baseStyleRules['lines-between-class-members'],
-
-    'no-array-constructor': 'off',
-    '@typescript-eslint/no-array-constructor': baseStyleRules['no-array-constructor'],
-
-    'no-dupe-class-members': 'off',
-    '@typescript-eslint/no-dupe-class-members': baseES6Rules['no-dupe-class-members'],
-
-    'no-empty-function': 'off',
-    '@typescript-eslint/no-empty-function': baseBestPracticesRules['no-empty-function'],
-
-    'no-extra-parens': 'off',
-    '@typescript-eslint/no-extra-parens': baseErrorsRules['no-extra-parens'],
-
-    'no-extra-semi': 'off',
-    '@typescript-eslint/no-extra-semi': baseErrorsRules['no-extra-semi'],
-
-    // ❌ Fails due to missing parser
-    // 'no-implied-eval': 'off',
-    // 'no-new-func': 'off',
-    // '@typescript-eslint/no-implied-eval': baseBestPracticesRules['no-implied-eval'],
-
-    'no-loss-of-precision': 'off',
-    '@typescript-eslint/no-loss-of-precision': baseErrorsRules['no-loss-of-precision'],
-
-    'no-loop-func': 'off',
-    '@typescript-eslint/no-loop-func': baseBestPracticesRules['no-loop-func'],
-
-    'no-magic-numbers': 'off',
-    '@typescript-eslint/no-magic-numbers': baseBestPracticesRules['no-magic-numbers'],
-
-    'no-redeclare': 'off',
-    '@typescript-eslint/no-redeclare': baseBestPracticesRules['no-redeclare'],
-
-    // ESLint variant does not work with TypeScript enums.
-    'no-shadow': 'off',
-    '@typescript-eslint/no-shadow': baseVariablesRules['no-shadow'],
-
-    'no-throw-literal': 'off',
-    '@typescript-eslint/no-throw-literal': baseBestPracticesRules['no-throw-literal'],
-
-    'no-unused-expressions': 'off',
-    '@typescript-eslint/no-unused-expressions': baseBestPracticesRules['no-unused-expressions'],
-
-    'no-unused-vars': 'off',
-    '@typescript-eslint/no-unused-vars': baseVariablesRules['no-unused-vars'],
-
-    // https://erkinekici.com/articles/linting-trap#no-use-before-define
-    // 'no-use-before-define': 'off',
-    // '@typescript-eslint/no-use-before-define': baseVariablesRules['no-use-before-define'],
-
-    // ESLint variant does not understand TypeScript constructors.
-    // eslint/eslint/#14118, typescript-eslint/typescript-eslint#873
-    'no-useless-constructor': 'off',
-    '@typescript-eslint/no-useless-constructor': baseES6Rules['no-useless-constructor'],
-
-    quotes: 'off',
-    '@typescript-eslint/quotes': baseStyleRules.quotes,
-
-    semi: 'off',
-    '@typescript-eslint/semi': baseStyleRules.semi,
-
-    'space-before-function-paren': 'off',
-    '@typescript-eslint/space-before-function-paren': baseStyleRules['space-before-function-paren'],
-
-    'require-await': 'off',
-    '@typescript-eslint/require-await': baseBestPracticesRules['require-await'],
-
-    'no-return-await': 'off',
-    '@typescript-eslint/return-await': baseBestPracticesRules['no-return-await'],
-
-    'space-infix-ops': 'off',
-    '@typescript-eslint/space-infix-ops': baseStyleRules['space-infix-ops'],
-
-    'object-curly-spacing': 'off',
-    '@typescript-eslint/object-curly-spacing': baseStyleRules['object-curly-spacing'],
-
-    'import/extensions': [
-      baseImportsRules['import/extensions'][0],
-      baseImportsRules['import/extensions'][1],
-      {
-        ...baseImportsRules['import/extensions'][2],
-        ts: 'never',
-        tsx: 'never',
-      },
-    ],
-
-    // Changes required is not yet implemented:
-    // 'import/no-extraneous-dependencies': [
-    //   baseImportsRules['import/no-extraneous-dependencies'][0],
-    //   {
-    //     ...baseImportsRules['import/no-extraneous-dependencies'][1],
-    //     devDependencies: baseImportsRules[
-    //       'import/no-extraneous-dependencies'
-    //     ][1].devDependencies.reduce((result, devDep) => {
-    //       const toAppend = [devDep];
-    //       const devDepWithTs = devDep.replace(/\bjs(x?)\b/g, 'ts$1');
-    //       if (devDepWithTs !== devDep) {
-    //         toAppend.push(devDepWithTs);
-    //       }
-    //       return [...result, ...toAppend];
-    //     }, []),
-    //   },
-    // ],
-  };
-}
-
-function getAliasesFromTsConfig() {
-  return Object.keys(tsconfigJson.compilerOptions.paths)
-    .map((path) => `${path}*`);
-}

.gitattributes

@@ -1,6 +0,0 @@
-# Prevent Git from auto-converting to CRLF on Windows, and convert to LF on checkin.
-#   *           : All files
-#   text=auto   : If Git decides content it text, it converts CRLF to LF on checkin.
-#   eol=lf      : forces Git to normalize line endings to LF on checkin and prevents conversion
-#                 to CRLF when the file is checked out.
-* text=auto eol=lf

.github/FUNDING.yml

@@ -1 +0,0 @@
-github: undergroundwires

.github/workflows/bump-and-release.yaml

@@ -1,4 +1,4 @@
-name: release-git
+name: Bump & release
 
 on:
   push: # Ensure a new release is created for each new tag

.github/workflows/checks.build.yaml

@@ -1,59 +0,0 @@
-name: build-checks
-
-on:
-  push:
-  pull_request:
-
-jobs:
-  build-web:
-    strategy:
-      matrix:
-        os: [ macos, ubuntu, windows ]
-        mode: [ development, test, production ]
-      fail-fast: false # Allows to see results from other combinations
-    runs-on: ${{ matrix.os }}-latest
-    steps:
-      -
-        name: Checkout
-        uses: actions/checkout@v2
-      -
-        name: Setup node
-        uses: actions/setup-node@v1
-        with:
-          node-version: 15.x
-      -
-        name: Install dependencies
-        run: npm ci
-      -
-        name: Build
-        run: npm run build -- --mode ${{ matrix.mode }}
-
-  # A new job is used due to environments/modes different from Vue CLI, https://github.com/nklayman/vue-cli-plugin-electron-builder/issues/1626
-  build-desktop:
-    strategy:
-      matrix:
-        os: [ macos, ubuntu, windows ]
-        mode: [ development, production ] # "test" is not supported https://github.com/nklayman/vue-cli-plugin-electron-builder/issues/1627
-      fail-fast: false # Allows to see results from other combinations
-    runs-on: ${{ matrix.os }}-latest
-    steps:
-      -
-        name: Checkout
-        uses: actions/checkout@v2
-      -
-        name: Setup node
-        uses: actions/setup-node@v1
-        with:
-          node-version: 15.x
-      -
-        name: Install dependencies
-        run: npm ci
-      -
-        name: Install cross-env
-        # Used to set NODE_ENV due to https://github.com/nklayman/vue-cli-plugin-electron-builder/issues/1626
-        run: npm install --global cross-env
-      -
-        name: Build
-        run: |-  
-          cross-env-shell NODE_ENV=${{ matrix.mode }}
-          npm run electron:build -- --publish never --mode ${{ matrix.mode }}

.github/workflows/deploy-desktop.yaml

@@ -1,4 +1,4 @@
-name: release-desktop
+name: Deploy desktop
 
 on:
  release:

.github/workflows/deploy-site.yaml

@@ -1,4 +1,4 @@
-name: release-site
+name: Deploy site
 
 on:
  release:

.github/workflows/quality-checks.yaml

@@ -1,4 +1,4 @@
-name: quality-checks
+name: Quality checks
 
 on: [ push, pull_request ]
 
@@ -8,13 +8,12 @@ jobs:
     strategy:
       matrix:
         lint-command:
-          - npm run lint:eslint
+          - npm run lint:vue
           - npm run lint:yaml
           - npm run lint:md
           - npm run lint:md:relative-urls
           - npm run lint:md:consistency
-        os: [ macos, ubuntu, windows ]
+      fail-fast: false # So it continues with other commands if one fails
-      fail-fast: false # Still interested to see results from other combinations
     steps:
       - name: Checkout
         uses: actions/checkout@v2

.github/workflows/security-checks.yaml

@@ -1,4 +1,4 @@
-name: security-checks
+name: Security checks
 
 on:
   push:

.github/workflows/test.yaml

@@ -1,9 +1,9 @@
-name: integration-tests
+name: Test
 
 on:
   push:
   pull_request:
-  schedule: # To get notified about problems from third party dependencies
+  schedule: # for integration tests
     - cron: '0 0 * * 0' # at 00:00 on every Sunday
 
 jobs:
@@ -25,6 +25,9 @@ jobs:
       -
         name: Install dependencies
         run: npm ci
+      -
+        name: Run unit tests
+        run: npm run test:unit
       -
         name: Run integration tests
         run: npm run test:integration

.github/workflows/tests.e2e.yaml

@@ -1,28 +0,0 @@
-name: e2e-tests
-
-on:
-  push:
-  pull_request:
-
-jobs:
-  run-tests:
-    strategy:
-      matrix:
-        os: [macos, ubuntu, windows]
-      fail-fast: false # So it still runs on other OSes if one of them fails
-    runs-on: ${{ matrix.os }}-latest
-    steps:
-      -
-        name: Checkout
-        uses: actions/checkout@v2
-      -
-        name: Setup node
-        uses: actions/setup-node@v1
-        with:
-          node-version: 15.x
-      -
-        name: Install dependencies
-        run: npm ci
-      -
-        name: Run e2e tests
-        run: npm run test:e2e -- --headless

.github/workflows/tests.unit.yaml

@@ -1,28 +0,0 @@
-name: unit-tests
-
-on:
-  push:
-  pull_request:
-
-jobs:
-  run-tests:
-    strategy:
-      matrix:
-        os: [macos, ubuntu, windows]
-      fail-fast: false # So it still runs on other OSes if one of them fails
-    runs-on: ${{ matrix.os }}-latest
-    steps:
-      -
-        name: Checkout
-        uses: actions/checkout@v2
-      -
-        name: Setup node
-        uses: actions/setup-node@v1
-        with:
-          node-version: 15.x
-      -
-        name: Install dependencies
-        run: npm ci
-      -
-        name: Run unit tests
-        run: npm run test:unit

.gitignore

@@ -1,10 +1,6 @@
 node_modules
 dist/
 .vs
-.vscode/**/*
+.vscode
-!.vscode/extensions.json
 #Electron-builder output
 /dist_electron
-# Cypress
-/tests/e2e/screenshots
-/tests/e2e/videos

.vscode/extensions.json

@@ -1,23 +0,0 @@
-{
-  "recommendations": [
-    // Common
-    "editorconfig.editorconfig",        // Applies .editorconfig to follow project style.
-    "wengerk.highlight-bad-chars",      // Highlights bad chars.
-    "wayou.vscode-todo-highlight",      // Highlights TODO.
-    "wix.vscode-import-cost",           // Shows in KB how much a require include in code.
-    // Documentation
-    "davidanson.vscode-markdownlint",   // Lints markdown.
-    // TypeScript / JavaScript
-    "dbaeumer.vscode-eslint",           // Lints JavaScript/TypeScript.
-    "pmneo.tsimporter",                 // Provides better auto-complete for TypeScripts imports.
-    // Vue
-    "jcbuisson.vue",                    // Highlights syntax.
-    "octref.vetur",                     // Adds Vetur, Vue tooling support.
-    // Scripting
-    "timonwong.shellcheck",             // Lints bash files.
-    "ms-vscode.powershell",             // Lints PowerShell files.
-    "ms-python.python",                 // Lints Python files.
-    // Distribution
-    "ms-azuretools.vscode-docker"       // Adds Docker support.
-  ]
-}

CHANGELOG.md

@@ -1,42 +1,5 @@
 # Changelog
 
-## 0.11.3 (2022-01-05)
-
-* Fix double backlashes in Windows vscode scripts | [5f091bb](https://github.com/undergroundwires/privacy.sexy/commit/5f091bb6abed878271e2321cd784f34436c677bd)
-* Fix OS desktop detection tests and edge cases | [a8358b8](https://github.com/undergroundwires/privacy.sexy/commit/a8358b8e7a93214f3d22a4488007ded5f623d845)
-* Fix clearing Windows product key showing dialog | [9b6636e](https://github.com/undergroundwires/privacy.sexy/commit/9b6636e21a922a4750dc19f4854f8ae679187926)
-* Document and unrecommend Cloud Experience Host | [9b5e0b0](https://github.com/undergroundwires/privacy.sexy/commit/9b5e0b0591fee56af52d83334a1f19180a49516f)
-* Add initial e2e testing with cypress | [ddd2e70](https://github.com/undergroundwires/privacy.sexy/commit/ddd2e704dbd361cbd219f3dfe644b983ad254095)
-* Restructure pipelines and badges | [5a2c263](https://github.com/undergroundwires/privacy.sexy/commit/5a2c263af35b8785e75ead6c43c3f17186dc15c8)
-* Fix failing of functions without revert code | [87de017](https://github.com/undergroundwires/privacy.sexy/commit/87de017afd6e08acbd2deea150c6af9c7ee778fc)
-* Fix typos in privacy modal #109 | [a1871a2](https://github.com/undergroundwires/privacy.sexy/commit/a1871a2982c9e3192193f836b97b1a6ccda5a2ab)
-* Refactor to add readonly interfaces | [c3c5b89](https://github.com/undergroundwires/privacy.sexy/commit/c3c5b897f308f613c252182a02cdd4cfa7150fa3)
-* Document and unrecommend AAD app removal #24, #54 | [455084c](https://github.com/undergroundwires/privacy.sexy/commit/455084c17b32d11d046515e8dc1447adf4bea4c3)
-* Migrate from TSLint to ESLint | [61b475f](https://github.com/undergroundwires/privacy.sexy/commit/61b475fa8de433cdada2efa7eac197683aacd956)
-* Add build checks and improve existing CI/CD checks | [17298f0](https://github.com/undergroundwires/privacy.sexy/commit/17298f0b2c51cb9becc0eb2ffe0d93d6a4c503a6)
-* Upgrade to Vue CLI 5 (and webpack 5) | [96265b7](https://github.com/undergroundwires/privacy.sexy/commit/96265b75deafb85978b16460138fb4a814c07cfe)
-* Refactor code to comply with ESLint rules | [5b1fbe1](https://github.com/undergroundwires/privacy.sexy/commit/5b1fbe1e2fb1354a5f060f8c8e3794ce756e16a7)
-* Fix mutated line endings on Windows | [bd23faa](https://github.com/undergroundwires/privacy.sexy/commit/bd23faa28f6d781581a33d5b780f4b33f7e2cd8b)
-* Refactor to improve iterations | [31f7091](https://github.com/undergroundwires/privacy.sexy/commit/31f70913a2f30baf5a9d6690f192e6a63da50114)
-* win: unrecommend and document Live ID service #100 | [d11a674](https://github.com/undergroundwires/privacy.sexy/commit/d11a674a3c4ad8f4972a870c2f0977ac53297273)
-
-[compare](https://github.com/undergroundwires/privacy.sexy/compare/0.11.2...0.11.3)
-
-## 0.11.2 (2021-12-03)
-
-* Fix Windows TrustedInstaller session errors | [20a0071](https://github.com/undergroundwires/privacy.sexy/commit/20a0071c0d3d769a8f31218abdbfc4cafa25c6ff)
-* Improve tests for `UserSelection` | [2f90cac](https://github.com/undergroundwires/privacy.sexy/commit/2f90cac52ab9e57615aeec41f9daa842bce770a5)
-* Fix disabling/enabling Defender on Windows #104 | [2e08293](https://github.com/undergroundwires/privacy.sexy/commit/2e082932c952b0849ab2b8709ff0c75293b88e95)
-* Refactor Saas naming, structure and modules | [bf83c58](https://github.com/undergroundwires/privacy.sexy/commit/bf83c58982ffa178facc6d35e50c7f1eac7ff236)
-* Fix Defender features errors in Windows #104 | [d7761ab](https://github.com/undergroundwires/privacy.sexy/commit/d7761ab30e7f1e10a2919c196804d67511d6163a)
-* Fix unintendedly inlined Windows scripts | [f2d9881](https://github.com/undergroundwires/privacy.sexy/commit/f2d988138257ff184884e4adc83c39e3bc247e9b)
-* Fix Defender error due to non-english Windows #104 | [7c02ffb](https://github.com/undergroundwires/privacy.sexy/commit/7c02ffb6c95382b94f0b05e6f259cc418ec91c93)
-* Improve and unify disabling of Windows services | [70cdf38](https://github.com/undergroundwires/privacy.sexy/commit/70cdf3865a0de3214fc9e26fbdada4b0cb413c46)
-* Improve Windows defender docs and errors #104 | [d2518b1](https://github.com/undergroundwires/privacy.sexy/commit/d2518b11a7774ec58b9b46a691e2f013855bf0f9)
-* Unrecommend and complete Windows Push Notif. #101 | [c65209e](https://github.com/undergroundwires/privacy.sexy/commit/c65209e6a99230f15ace8955e8d5a6f3333d146b)
-
-[compare](https://github.com/undergroundwires/privacy.sexy/compare/0.11.1...0.11.2)
-
 ## 0.11.1 (2021-11-04)
 
 * Update dependencies | [64631a4](https://github.com/undergroundwires/privacy.sexy/commit/64631a4552fad7f7b06286aba8d3ca2d731f9342)

CONTRIBUTING.md

@@ -1,51 +1,34 @@
 # Contributing
 
-Love your input! Contributing to this project should be as easy and transparent as possible, whether it's:
+- Love your input! Contributing to this project should be as easy and transparent as possible, whether it's:
-
+  - Reporting a bug
-- reporting a bug,
+  - Discussing the current state of the code
-- discussing the current state of the code,
+  - Submitting a fix
-- submitting a fix,
+  - Proposing new features
-- proposing new features,
+  - Becoming a maintainer
-- or becoming a maintainer.
-
-As a small open source project with small community, it can sometimes take a long time to address the issues so please be patient.
 
 ## Pull request process
 
-Your pull requests are actively welcomed. We collaborate using [GitHub flow](https://docs.github.com/en/get-started/quickstart/github-flow).
+- [GitHub flow](https://guides.github.com/introduction/flow/index.html) with [GitOps](./img/architecture/gitops.png) is used
-
+- Your pull requests are actively welcomed.
-The steps:
+- The steps:
-
+  1. Fork the repo and create your branch from master.
-1. Fork the repo and create your branch from master.
+  2. If you've added code that should be tested, add tests.
-2. If you've added code that requires testing, add tests. See [tests.md](./docs/tests.md).
+  3. If you've changed APIs, update the documentation.
-3. If you've done a major change, update the documentation. See [docs/](./docs/).
+  4. Ensure the test suite passes.
-4. Ensure the test suite passes. See [development.md | Testing](./docs/development.md#testing) for commands.
+  5. Make sure your code lints.
-5. Make sure your code lints.See [development.md | Linting](./docs/development.md#linting) for commands.
+  6. Issue that pull request!
-6. Issue that pull request!
+- 🙏 DO
-
+  - Document your changes in the pull request
-**🙏 DO:**
+- ❗ DON'T
-
+  - Do not update the versions, current version is only [set by the maintainer](./img/architecture/gitops.png) and updated automatically by [bump-everywhere](https://github.com/undergroundwires/bump-everywhere)
-- Document why (what you're trying to solve) rather than what in the pull request.
-
-**❗ DON'T:**
-
-- Do not update the versions, current version is [set by the maintainer](./docs/ci-cd.md#gitops) and updated automatically by [bump-everywhere](https://github.com/undergroundwires/bump-everywhere).
-
-Automated pipelines will run to control your PR and they will publish your code once the maintainer merges your PR.
-
-📖 You can read more in [ci-cd.md](./docs/ci-cd.md).
-
-## Extend scripts
-
-Here's quick information for you who want to add more scripts.
-
-You have two alternatives:
-
-1. [Create an issue](https://github.com/undergroundwires/privacy.sexy/issues/new/choose) and ask for someone else to add the script for you.
-2. Or send a PR yourself. This would make it faster to get your code into the project. You need to add scripts to related OS in [collections](src/application/collections/) folder. Then you'd sent a pull request, see [pull request process](#pull-request-process).
-   - 📖 If you're unsure about the syntax, check [collection-files.md](docs/collection-files.md).
-   - 📖 If you wish to use templates, use [templating.md](./docs/templating.md).
 
 ## License
 
-By contributing, you agree that your [GNU General Public License v3.0](./LICENSE) will be the license for your contributions.
+By contributing, you agree that your contributions will be licensed under its [GNU General Public License v3.0](./LICENSE).
+
+## Read more
+
+- See [tests](./docs/tests.md) for testing
+- See [extend script](./README.md#extend-scripts) for quick steps to extend scripts
+- See [architecture overview](./README.md#architecture-overview) to deep dive into privacy.sexy codebase

README.md

@@ -2,140 +2,87 @@
 
 > Enforce privacy & security best-practices on Windows and macOS, because privacy is sexy 🍑🍆
 
-<!-- markdownlint-disable MD033 -->
+[![contributions welcome](https://img.shields.io/badge/contributions-welcome-brightgreen.svg?style=flat)](./CONTRIBUTING.md)
-<p align="center">
+[![Language grade: JavaScript](https://img.shields.io/lgtm/grade/javascript/g/undergroundwires/privacy.sexy.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/undergroundwires/privacy.sexy/context:javascript)
-  <a href="https://undergroundwires.dev/donate?project=privacy.sexy">
+[![Maintainability](https://api.codeclimate.com/v1/badges/3a70b7ef602e2264342c/maintainability)](https://codeclimate.com/github/undergroundwires/privacy.sexy/maintainability)
-    <img
+[![Tests status](https://github.com/undergroundwires/privacy.sexy/workflows/Test/badge.svg)](https://github.com/undergroundwires/privacy.sexy/actions)
-      alt="donation badge"
+[![Quality checks status](https://github.com/undergroundwires/privacy.sexy/workflows/Quality%20checks/badge.svg)](https://github.com/undergroundwires/privacy.sexy/actions)
-      src="https://undergroundwires.dev/img/badges/donate/flat.svg"
+[![Security checks status](https://github.com/undergroundwires/privacy.sexy/workflows/Security%20checks/badge.svg)](https://github.com/undergroundwires/privacy.sexy/actions)
-    />
+[![Bump & release status](https://github.com/undergroundwires/privacy.sexy/workflows/Bump%20&%20release/badge.svg)](https://github.com/undergroundwires/privacy.sexy/actions)
-  </a>
+[![Deploy status](https://github.com/undergroundwires/privacy.sexy/workflows/Build%20&%20deploy/badge.svg)](https://github.com/undergroundwires/privacy.sexy/actions)
-  <a href="https://github.com/undergroundwires/privacy.sexy/blob/master/CONTRIBUTING.md">
+[![Auto-versioned by bump-everywhere](https://github.com/undergroundwires/bump-everywhere/blob/master/badge.svg?raw=true)](https://github.com/undergroundwires/bump-everywhere)
-    <img
-      alt="contributions are welcome"
-      src="https://img.shields.io/badge/contributions-welcome-brightgreen.svg?style=flat"
-    />
-  </a>
-  <!-- Code quality -->
-  <br />
-  <a href="https://lgtm.com/projects/g/undergroundwires/privacy.sexy/context:javascript">
-    <img
-      alt="Language grade: JavaScript/TypeScript"
-      src="https://img.shields.io/lgtm/grade/javascript/g/undergroundwires/privacy.sexy.svg?logo=lgtm&logoWidth=18"
-    />
-  </a>
-  <a href="https://codeclimate.com/github/undergroundwires/privacy.sexy/maintainability">
-    <img
-      alt="Maintainability"
-      src="https://api.codeclimate.com/v1/badges/3a70b7ef602e2264342c/maintainability"
-    />
-  </a>
-  <!-- Tests -->
-  <br />
-  <a href="https://github.com/undergroundwires/privacy.sexy/actions/workflows/tests.unit.yaml">
-    <img
-      alt="Unit tests status"
-      src="https://github.com/undergroundwires/privacy.sexy/workflows/unit-tests/badge.svg"
-    />
-  </a>
-  <a href="https://github.com/undergroundwires/privacy.sexy/actions/workflows/tests.integration.yaml">
-    <img
-      alt="Integration tests status"
-      src="https://github.com/undergroundwires/privacy.sexy/workflows/integration-tests/badge.svg"
-    />
-  </a>
-  <a href="https://github.com/undergroundwires/privacy.sexy/actions/workflows/tests.e2e.yaml">
-    <img
-      alt="E2E tests status"
-      src="https://github.com/undergroundwires/privacy.sexy/workflows/e2e-tests/badge.svg"
-    />
-  </a>
-  <!-- Checks -->
-  <br />
-  <a href="https://github.com/undergroundwires/privacy.sexy/actions/workflows/checks.quality.yaml">
-    <img
-      alt="Quality checks status"
-      src="https://github.com/undergroundwires/privacy.sexy/workflows/quality-checks/badge.svg"
-    />
-  </a>
-  <a href="https://github.com/undergroundwires/privacy.sexy/actions/workflows/checks.security.yaml">
-    <img
-      alt="Security checks status"
-      src="https://github.com/undergroundwires/privacy.sexy/workflows/security-checks/badge.svg"
-    />
-  </a>
-  <a href="https://github.com/undergroundwires/privacy.sexy/actions/workflows/checks.build.yaml">
-    <img
-      alt="Build checks status"
-      src="https://github.com/undergroundwires/privacy.sexy/workflows/build-checks/badge.svg"
-    />
-  </a>
-  <!-- Release -->
-  <br />
-  <a href="https://github.com/undergroundwires/privacy.sexy/actions/workflows/release.git.yaml">
-    <img
-      alt="Git release status"
-      src="https://github.com/undergroundwires/privacy.sexy/workflows/release-git/badge.svg"
-    />
-  </a>
-  <a href="https://github.com/undergroundwires/privacy.sexy/actions/workflows/release.site.yaml">
-    <img
-      alt="Site release status"
-      src="https://github.com/undergroundwires/privacy.sexy/workflows/release-site/badge.svg"
-    />
-  </a>
-  <a href="https://github.com/undergroundwires/privacy.sexy/actions/workflows/release.desktop.yaml">
-    <img
-      alt="Desktop application release status"
-      src="https://github.com/undergroundwires/privacy.sexy/workflows/release-desktop/badge.svg"
-    />
-  </a>
-  <!-- Others -->
-  <br />
-  <a href="https://github.com/undergroundwires/bump-everywhere">
-    <img
-      alt="Auto-versioned by bump-everywhere"
-      src="https://github.com/undergroundwires/bump-everywhere/blob/master/badge.svg?raw=true"
-    />
-  </a>
-</p>
-<!-- markdownlint-restore -->
 
 ## Get started
 
-- 🌍️ **Online**: [https://privacy.sexy](https://privacy.sexy).
+- Online version at [https://privacy.sexy](https://privacy.sexy)
-- 🖥️ **Offline**: Check [releases page](https://github.com/undergroundwires/privacy.sexy/releases), or download directly for: [Windows](https://github.com/undergroundwires/privacy.sexy/releases/download/0.11.2/privacy.sexy-Setup-0.11.2.exe), [macOS](https://github.com/undergroundwires/privacy.sexy/releases/download/0.11.2/privacy.sexy-0.11.2.dmg), [Linux](https://github.com/undergroundwires/pr.vacy.sexy/releases/download/0.11.2/privacy.sexy-0.11.2.AppImage).
+  - 💡 No need to run any compiled software on your computer.
+- Alternatively download offline version for [Windows](https://github.com/undergroundwires/privacy.sexy/releases/download/0.11.1/privacy.sexy-Setup-0.11.1.exe), [macOS](https://github.com/undergroundwires/privacy.sexy/releases/download/0.11.1/privacy.sexy-0.11.1.dmg) or [Linux](https://github.com/undergroundwires/privacy.sexy/releases/download/0.11.1/privacy.sexy-0.11.1.AppImage).
+  - 💡 Single click to execute your script.
+- ❗ Come back regularly to apply latest version for stronger privacy and security.
 
-Online version does not require to run any software on your computer. Offline version has more functions such as running the scripts directly.
+[![privacy.sexy application](img/screenshot.png?raw=true)](https://privacy.sexy)
 
-💡 You should apply your configuration from time to time (more than once). It would strengthen your privacy and security control because privacy.sexy and its scripts get better and stronger in every new version.
+## Why
 
-[![privacy.sexy application](img/screenshot.png?raw=true )](https://privacy.sexy)
+- Rich tweak pool to harden security & privacy of the OS and other software on it
+- Free (both free as in beer and free as in speech)
+- No need to run any compiled software that has access to your system, just run the generated scripts
+- Have full visibility into what the tweaks do as you enable them
+- Ability to revert (undo) applied scripts
+- Everything is transparent: both application and its infrastructure are open-source and automated
+- Easily extendable with [own powerful templating language](./docs/templating.md)
+- Each script is independently executable without cross-dependencies
 
-## Features
+## Extend scripts
 
-- **Rich**: Hundreds of scripts that aims to give you control of your data.
+- You can either [create an issue](https://github.com/undergroundwires/privacy.sexy/issues/new/choose)
-- **Free**: Both free as in "beer" and free as in "speech".
+- Or send a PR:
-- **Transparent**. Have full visibility into what the tweaks do as you enable them.
+  1. Fork the repository
-- **Reversible**. Revert if something feels wrong.
+  2. Add more scripts in respective script collection in [collections](src/application/collections/) folder.
-- **Accessible**. No need to run any compiled software on your computer with web version.
+     - 📖 If you're unsure about the syntax you can refer to the [collection files | documentation](docs/collection-files.md).
-- **Open**. What you see as code in this repository is what you get. The application itself, its infrastructure and deployments are open-source and automated thanks to [bump-everywhere](https://github.com/undergroundwires/bump-everywhere).
+     - 🙏 For any new script, please add `revertCode` and `docs` values if possible.
-- **Tested.** A lot of tests. Automated and manual. Community-testing and verification. Stability improvements comes before new features.
+  3. Send a pull request 👌
-- **Extensible**. Effortlessly [extend scripts](./CONTRIBUTING.md#extend-scripts) with a custom designed [templating language](./docs/templating.md).
-- **Portable and simple**. Every script is independently executable without cross-dependencies.
 
-## Support
+## Commands
 
-**Sponsor 💕**. This project is free, and it might not be tempting to donate since you don't have to pay. But your donations will ensure that this project stays alive. A monthly coffee from you would make a difference. Recurring donations allow me to spend more time and resources on this project. Consider sponsoring on [GitHub Sponsors](https://github.com/sponsors/undergroundwires), or you can donate using [other ways such as crypto or a coffee](https://undergroundwires.dev/donate).
+- Project setup: `npm install`
+- Testing
+  - Run unit tests: `npm run test:unit`
+  - Run integration tests: `npm run test:integration`
+  - Lint: `npm run lint`
+- **Desktop app**
+  - Development: `npm run electron:serve`
+  - Production: `npm run electron:build` to build an executable
+- **Webpage**
+  - Development: `npm run serve` to compile & hot-reload for development.
+  - Production: `npm run build` to prepare files for distribution.
+  - Or run using Docker:
+    1. Build: `docker build -t undergroundwires/privacy.sexy:0.11.1 .`
+    2. Run: `docker run -it -p 8080:80 --rm --name privacy.sexy-0.11.1 undergroundwires/privacy.sexy:0.11.1`
 
-**Star 🤩**. I know that not everyone can afford donating a coffee to show support. In this case, feel free to give it a star ⭐ . It helps me to see that you appreciate the project.
+## Architecture overview
 
-**Contribute 👷**. Contributions of any type are welcome. See [CONTRIBUTING.md](./CONTRIBUTING.md) as the starting point. It includes useful information like [how to add new scripts](./CONTRIBUTING.md#extend-scripts).
+### Application
 
-## Development
+- Powered by **TypeScript**, **Vue.js** and **Electron** 💪
+  - and driven by **Domain-driven design**, **Event-driven architecture**, **Data-driven programming** concepts.
+- Application uses highly decoupled models & services in different DDD layers.
+- 📖 Read more on • [Presentation](./docs/presentation.md) • [Application](./docs/application.md)
 
-Refer to [development.md](./docs/development.md) for Docker usage and reading more about setting up your development environment.
+![DDD + vue.js](img/architecture/app-ddd.png)
 
-Check [architecture.md](./docs/architecture.md) for an overview of design and how different parts and layers work together. You can refer to [application.md](./docs/application.md) for a closer look at application layer codebase and [presentation.md](./docs/presentation.md) for code related to GUI layer. [collection-files.md](./docs/collection-files.md) explains the YAML files that are the core of the application and [templating.md](./docs/templating.md) documents how to use templating language in those files. In [ci-cd.md](./docs/ci-cd.md), you can read more about the pipelines that automates maintenance tasks and ensures you get what see.
+### AWS Infrastructure
 
-[docs/](./docs/) folder includes all other documentation.
+[![AWS solution](img/architecture/aws-solution.png)](https://github.com/undergroundwires/aws-static-site-with-cd)
+
+- It uses infrastructure from the following repository: [aws-static-site-with-cd](https://github.com/undergroundwires/aws-static-site-with-cd)
+  - Runs on AWS 100% serverless and automatically provisioned using [GitHub Actions](.github/workflows/).
+  - Maximum security & automation and minimum AWS costs are the highest priorities of the design.
+
+#### GitOps: CI/CD to AWS
+
+- CI/CD is fully automated for this repo using different GIT events & GitHub actions.
+  - Versioning, tagging, creation of `CHANGELOG.md` and releasing is automated using [bump-everywhere](https://github.com/undergroundwires/bump-everywhere) action
+- Everything that's merged in the master goes directly to production.
+
+[![CI/CD to AWS with GitHub Actions](img/architecture/gitops.png)](.github/workflows/)

babel.config.js

@@ -1,5 +1,5 @@
 module.exports = {
   presets: [
-    '@vue/cli-plugin-babel/preset',
+    '@vue/cli-plugin-babel/preset'
-  ],
+  ]
-};
+}

cypress.json

@@ -1,3 +0,0 @@
-{
-  "pluginsFile": "tests/e2e/plugins/index.js"
-}

docs/application.md

@@ -1,45 +1,44 @@
 # Application
 
-Application layer is mainly responsible for:
+- It's mainly responsible for
-
+  - creating and event based [application state](#application-state)
-- creating an event-based and mutable [application state](#application-state),
+  - [parsing](#parsing) and [compiling](#compiling) [application data](#application-data)
-- [parsing and compiling](#parsing-and-compiling) the [application data](#application-data).
+- Consumed by [presentation layer](./presentation.md)
-
-📖 Refer to [architecture.md | Layered Application](./architecture.md#layered-application) to read more about the layered architecture.
 
 ## Structure
 
-Application layer code exists in [`/src/application`](./../src/application/) and includes following structure:
+- [`/src/` **`application/`**](./../src/application/): Contains all application related code.
-
+  - [**`collections/`**](./../src/application/collections/): Holds [collection files](./collection-files.md)
-- [**`collections/`**](./../src/application/collections/): Holds [collection files](./collection-files.md).
+  - [**`Common/`**](./../src/application/Common/): Contains common functionality that is shared in application layer.
-- [**`Common/`**](./../src/application/Common/): Contains common functionality in application layer.
+  - `..`: other classes are categorized using folders-by-feature structure
-- `...`: rest of the application layer source code organized using folders-by-feature structure.
 
 ## Application state
 
-It uses [state pattern](https://en.wikipedia.org/wiki/State_pattern) with context and state objects. [`ApplicationContext.ts`](./../src/application/Context/ApplicationContext.ts) the "Context" of state pattern provides an instance of [`CategoryCollectionState.ts`](./../src/application/Context/State/CategoryCollectionState.ts) (the "State" of the state pattern) for every supported collection.
+- [ApplicationContext.ts](./../src/application/Context/ApplicationContext.ts) holds the [CategoryCollectionState](./../src/application/Context/State/CategoryCollectionState.ts) for each OS
-
+- Uses [state pattern](https://en.wikipedia.org/wiki/State_pattern)
-Presentation layer uses a singleton (same instance of) [`ApplicationContext.ts`](./../src/application/Context/ApplicationContext.ts) throughout the application to ensure consistent state.
+- Same instance is shared throughout the application to ensure consistent state
-
+- 📖 See [Application State | Presentation layer](./presentation.md#application-state) to read more about how the state should be managed by the presentation layer.
-📖 Refer to [architecture.md | Application State](./architecture.md#application-state) to get an overview of event handling and [presentation.md | Application State](./presentation.md#application-state) for deeper look into how the presentation layer manages state.
+- 📖 See [ApplicationContext.ts](./../src/application/Context/ApplicationContext.ts) to start diving into the state code.
 
 ## Application data
 
-Application data is collection files using YAML. You can refer to [collection-files.md](./collection-files.md) to read more about the scheme and structure of application data files. You can also check the source code [collection yaml files](./../src/application/collections/) to directly see the application data using that scheme.
+- Compiled to [`Application`](./../src/domain/Application.ts) domain object.
+- The scripts are defined and controlled in different data files per OS
+- Enables [data-driven programming](https://en.wikipedia.org/wiki/Data-driven_programming) and easier contributions
+- Application data is defined in collection files and
+- 📖 See [Application data | Presentation layer](./presentation.md#application-data) to read how the application data is read by the presentation layer.
+- 📖 See [collection files documentation](./collection-files.md) to read more about how the data files are structured/defined and see [collection yaml files](./../src/application/collections/) to directly check the code.
 
-Application layer [parses and compiles](#parsing-and-compiling) application data into [`Application`](./../src/domain/Application.ts)). Once parsed, application layer provides the necessary functionality to presentation layer based on the application data. You can read more about how presentation layer consumes the application data in [presentation.md | Application Data](./presentation.md#application-data).
+## Parsing
 
-Application layer enables [data-driven programming](https://en.wikipedia.org/wiki/Data-driven_programming) by leveraging the data to the rest of the source code. It makes it easy for community to contribute on the project by using a declarative language used in collection files.
+- Application data is parsed to domain object [`Application.ts`](./../src/domain/Application.ts)
+- Steps
+  1. (Compile time) Load application data from [collection yaml files](./../src/application/collections/) using webpack loader
+  2. (Runtime) Parse and compile application and make it available to presentation layer by [`ApplicationFactory.ts`](./../src/application/ApplicationFactory.ts)
 
-### Parsing and compiling
+### Compiling
 
-Application layer parses the application data to compile the domain object [`Application.ts`](./../src/domain/Application.ts).
+- Parsing the application files includes compiling scripts using [collection file defined functions](./collection-files.md#function)
-
+- To extend the syntax:
-A webpack loader loads (or injects) application data ([collection yaml files](./../src/application/collections/)) into the application layer in compile time. Application layer ([`ApplicationFactory.ts`](./../src/application/ApplicationFactory.ts)) parses and compiles this data in runtime.
+  1. Add a new parser under [SyntaxParsers](./../src/application/Parser/Script/Compiler/Expressions/SyntaxParsers) where you can look at other parsers to understand more.
-
+  2. Register your in [CompositeExpressionParser](./../src/application/Parser/Script/Compiler/Expressions/Parser/CompositeExpressionParser.ts)
-Application layer compiles templating syntax during parsing to create the end scripts. You can read more about templating syntax in [templating.md](./templating.md) and how application data uses them through functions in [collection-files.md | Function](./collection-files.md#function).
-
-The steps to extend the templating syntax:
-
-1. Add a new parser under [SyntaxParsers](./../src/application/Parser/Script/Compiler/Expressions/SyntaxParsers) where you can look at other parsers to understand more.
-2. Register your in [CompositeExpressionParser](./../src/application/Parser/Script/Compiler/Expressions/Parser/CompositeExpressionParser.ts).

docs/architecture.md

@@ -1,66 +0,0 @@
-# Architecture overview
-
-This repository consists of:
-
-- A [layered application](#layered-application).
-- [AWS infrastructure](#aws-infrastructure) as code and instructions to host the website.
-- [GitOps](#gitops) practices for development, maintenance and deployment.
-
-## Layered application
-
-Application is
-
-- powered by **TypeScript**, **Vue.js** and **Electron** 💪,
-- and driven by **Domain-driven design**, **Event-driven architecture**, **Data-driven programming** concepts.
-
-Application uses highly decoupled models & services in different DDD layers:
-
-- presentation layer (see [presentation.md](./presentation.md)),
-- application layer (see [application.md](./application.md)),
-- and domain layer.
-
-Application layer depends on and consumes domain layer. [Presentation layer](./presentation.md) consumes and depends on application layer along with domain layer. Application and presentation layers can communicate through domain model.
-
-![DDD + vue.js](./../img/architecture/app-ddd.png)
-
-### Application state
-
-State handling uses an event-driven subscription model to signal state changes and special functions to register changes. It does not depend on third party packages.
-
-Each layer treat application layer differently.
-
-![State](./../img/architecture/app-state.png)
-
-*[Presentation layer](./presentation.md)*:
-
-- Each component holds their own state about presentation-related data.
-- Components register shared state changes into application state using functions.
-- Components listen to shared state changes using event subscriptions.
-- 📖 Read more: [presentation.md | Application state](./presentation.md#application-state).
-
-*[Application layer](./application.md)*:
-
-- Stores the application-specific state.
-- The state it exposed for read with getter functions and set using setter functions, setter functions also fire application events that allows other parts of application and the view in presentation layer to react.
-- So state is mutable, and fires related events when mutated.
-- 📖 Read more: [application.md | Application state](./application.md#application-state).
-
-It's comparable with flux ([`redux`](https://redux.js.org/)) or flux-like ([`vuex`](https://vuex.vuejs.org/)) patterns. Flux component "view" is [presentation layer](./presentation.md) in Vue. Flux functions "dispatcher", "store" and "action creation" functions lie in the [application layer](./application.md). A difference is that application state in privacy.sexy is mutable and lies in single flux "store" that holds app state and logic. The "actions" mutate the state directly which in turns act as dispatcher to notify its own event subscriptions (callbacks).
-
-## AWS infrastructure
-
-The web-site runs on serverless AWS infrastructure. Infrastructure is open-source and deployed as code. [aws-static-site-with-cd](https://github.com/undergroundwires/aws-static-site-with-cd) project includes the source code.
-
-[![AWS solution](../img/architecture/aws-solution.png)](https://github.com/undergroundwires/aws-static-site-with-cd)
-
-The design priorities highest security then minimizing cloud infrastructure costs.
-
-This project includes [GitHub Actions](../.github/workflows/) to automatically provision the infrastructure with zero-touch and without any "hidden" steps, ensuring everything is open-source and transparent. Git repositories includes all necessary instructions and automation with [GitOps](#gitops) practices.
-
-## GitOps
-
-CI/CD pipelines automate operational tasks based on different Git events. [bump-everywhere](https://github.com/undergroundwires/bump-everywhere) enables this automation.
-
-📖 Read more in [`ci-cd.md`](./ci-cd.md#gitops).
-
-[![CI/CD using GitHub Actions](../img/architecture/gitops.png)](../.github/workflows/)

docs/ci-cd.md

@@ -1,45 +0,0 @@
-# CI/CD overview
-
-## GitOps
-
-CI/CD is fully automated using different Git events and GitHub actions. This repository uses [bump-everywhere](https://github.com/undergroundwires/bump-everywhere) to automate versioning, tagging, creation of `CHANGELOG.md` and GitHub releases. A dedicated workflow [release.desktop.yaml](./../.github/workflows/release.desktop.yaml) creates desktop installers and executables and attaches them into GitHub releases.
-
-Everything that's merged in the master goes directly to production.
-
-[![CI/CD using GitHub Actions](./../img/architecture/gitops.png)](../.github/workflows/)
-
-## Pipeline files
-
-privacy.sexy uses [GitHub actions](https://github.com/features/actions) to define and run pipelines as code.
-
-GitHub workflows i.e. pipelines exist in [`/.github/.workflows/`](./../.github/workflows/) folder without any subfolders due to GitHub actions requirements [1] .
-
-[1]: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#about-yaml-syntax-for-workflows
-
-## Pipeline types
-
-We categorize pipelines into different categories. We use these names in convention when naming files and actions, see [naming conventions](#naming-conventions).
-
-The categories consist of:
-
-- `tests`: Different types of tests to verify functionality.
-- `checks`: Other controls such as vulnerability scans or styling checks.
-- `release`: Pipelines used for release of deployment such as building and testing.
-
-## Naming conventions
-
-Convention for naming pipeline files: **`<type>.<name>.yaml`**.
-
-**`type`**:
-
-- Sub-folders do not work for GitHub workflows [1] so we use `<type>.` prefix to organize them.
-- See also [pipeline types](#pipeline-types) for list of all usable types.
-
-**`name`**:
-
-- We name workflows using kebab-case.
-- E.g. file name `tests.unit.yaml`, pipeline file should set the naem as: `name: unit-tests`.
-- Kebab-case allows to have better URL references to them.
-  - [README.md](./../README.md) uses URL references to show status badges for actions.
-
-[1]: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#about-yaml-syntax-for-workflows

docs/development.md

@@ -1,53 +0,0 @@
-# Development
-
-Before your commit, a good practice is to:
-
-1. [Run unit tests](#testing)
-2. [Lint your code](#linting)
-
-You could run other types of tests as well, but they may take longer time and overkill for your changes. Automated actions executes the tests for a pull request or change in the main branch. See [ci-cd.md](./ci-cd.md) for more information.
-
-## Commands
-
-### Prerequisites
-
-- Install node >15.x.
-- Install dependencies using `npm install`.
-
-### Testing
-
-- Run unit tests: `npm run test:unit`
-- Run integration tests: `npm run test:integration`
-- Run e2e (end-to-end) tests
-  - Interactive mode with GUI: `npm run test:e2e`
-  - Headless mode without GUI: `npm run test:e2e -- --headless`
-
-📖 Read more about testing in [tests](./tests.md).
-
-### Linting
-
-- Lint all (recommended 💡): `npm run lint`
-- Markdown: `npm run lint:md`
-- Markdown consistency `npm run lint:md:consistency`
-- Markdown relative URLs: `npm run lint:md:relative-urls`
-- JavaScript/TypeScript: `npm run lint:eslint`
-- Yaml: `npm run lint:yaml`
-
-### Running
-
-- Run in local server: `npm run serve`
-  - 💡 Meant for local development with features such as hot-reloading.
-- Run using Docker:
-  1. Build: `docker build -t undergroundwires/privacy.sexy:latest .`
-  2. Run: `docker run -it -p 8080:80 --rm --name privacy.sexy undergroundwires/privacy.sexy:latest`
-
-### Building
-
-- Build web application: `npm run build`
-- Build desktop application: `npm run electron:build`
-
-## Recommended extensions
-
-You should use EditorConfig to follow project style.
-
-For Visual Studio Code, [`.vscode/extensions.json`](./../.vscode/extensions.json) includes list of recommended extensions.

docs/presentation.md

@@ -1,63 +1,53 @@
 # Presentation layer
 
-Presentation layer consists of UI-related code. It uses Vue.js as JavaScript framework and includes Vue.js components. It also includes [Electron](https://www.electronjs.org/) to provide functionality to desktop application.
+- Consists of Vue.js components and other UI-related code.
-
+- Desktop application is created using [Electron](https://www.electronjs.org/).
-It's designed event-driven from bottom to top. It listens user events (from top) and state events (from bottom) to update state or the GUI.
+- Event driven as in components simply listens to events from the state and act accordingly.
-
-📖 Refer to [architecture.md (Layered Application)](./architecture.md#layered-application) to read more about the layered architecture.
 
 ## Structure
 
 - [`/src/` **`presentation/`**](./../src/presentation/): Contains all presentation related code including Vue and Electron configurations
   - [**`bootstrapping/`**](./../src/presentation/bootstrapping/): Registers Vue global objects including components and plugins.
   - [**`components/`**](./../src/presentation/components/): Contains all Vue components and their helper classes.
-    - [**`Shared/`**](./../src/presentation/components/Shared): Contains Vue components and component helpers that other components share.
+    - [**`Shared/`**](./../src/presentation/components/Shared): Contains Vue components and component helpers that are shared across other components.
-  - [**`assets/`**](./../src/presentation/assets/styles/): Contains assets that webpack will process.
+  - [**`assets/`**](./../src/presentation/assets/styles/): Contains assets that will be processed by webpack.
     - [**`fonts/`**](./../src/presentation/assets/fonts/): Contains fonts
     - [**`styles/`**](./../src/presentation/assets/styles/): Contains shared styles used throughout different components.
-      - [**`components/`**](./../src/presentation/assets/styles/components): Contains reusable styles coupled to a Vue/HTML component.
+      - [**`components/`**](./../src/presentation/assets/styles/components): Contains styles that are reusable and tightly coupled a Vue/HTML component.
       - [**`vendors-extensions/`**](./../src/presentation/assets/styles/third-party-extensions): Contains styles that override third-party components used.
-      - [**`main.scss`**](./../src/presentation/assets/styles/main.scss): Primary Sass file, passes along all other styles, should be the single file used from other components.
+      - [**`main.scss`**](./../src/presentation/assets/styles/main.scss): Primary Sass file, passes along all other styles, should be the only file used from other components.
   - [**`main.ts`**](./../src/presentation/main.ts): Application entry point that mounts and starts Vue application.
   - [**`electron/`**](./../src/presentation/electron/): Electron configuration for the desktop application.
     - [**`main.ts`**](./../src/presentation/main.ts): Main process of Electron, started as first thing when app starts.
-- [**`/public/`**](./../public/): Contains static assets that are directly copied and do not go through webpack.
+- [**`/public/`**](./../public/): Contains static assets that will directly be copied and not go through webpack.
-- [**`/vue.config.js`**](./../vue.config.js): Global Vue CLI configurations loaded by `@vue/cli-service`.
+- [**`/vue.config.js`**](./../vue.config.js): Global Vue CLI configurations loaded by `@vue/cli-service`
-- [**`/postcss.config.js`**](./../postcss.config.js): PostCSS configurations used by Vue CLI internally.
+- [**`/postcss.config.js`**](./../postcss.config.js): PostCSS configurations that are used by Vue CLI internally
-- [**`/babel.config.js`**](./../babel.config.js): Babel configurations for polyfills used by `@vue/cli-plugin-babel`.
+- [**`/babel.config.js`**](./../babel.config.js): Babel configurations for polyfills used by `@vue/cli-plugin-babel`
 
 ## Application data
 
-Components (should) use [ApplicationFactory](./../src/application/ApplicationFactory.ts) singleton to reach the application domain to avoid [parsing and compiling](./application.md#parsing-and-compiling) the application again.
+- Components and should use [ApplicationFactory](./../src/application/ApplicationFactory.ts) singleton to reach the application domain.
-
+- [Application.ts](../src/domain/Application.ts) domain model is the stateless application representation including
-[Application.ts](../src/domain/Application.ts) is an immutable domain model that represents application state. It includes:
+  - available scripts, collections as defined in [collection files](./collection-files.md)
-
+  - package information as defined in [`package.json`](./../package.json)
-- available scripts, collections as defined in [collection files](./collection-files.md),
+- 📖 See [Application data | Application layer](./presentation.md#application-data) where application data is parsed and compiled.
-- package information as defined in [`package.json`](./../package.json).
-
-You can read more about how application layer provides application data to he presentation in [application.md | Application data](./application.md#application-data).
 
 ## Application state
 
-Inheritance of a Vue components marks whether it uses application state . Components that does not handle application state extends `Vue`. Stateful components mutate or/and react to state changes (such as user selection or search queries) in [ApplicationContext](./../src/application/Context/ApplicationContext.ts) extend [`StatefulVue`](./../src/presentation/components/Shared/StatefulVue.ts) class to access the context / state.
+- Stateful components mutate or/and react to state changes in [ApplicationContext](./../src/application/Context/ApplicationContext.ts).
-
+- Stateless components that does not handle state extends `Vue`
-[`StatefulVue`](./../src/presentation/components/Shared/StatefulVue.ts) functions include:
+- Stateful components that depends on the collection state such as user selection, search queries and more extends [`StatefulVue`](./../src/presentation/components/Shared/StatefulVue.ts)
-
+- The single source of truth is a singleton of the state created and made available to presentation layer by [`StatefulVue`](./../src/presentation/components/Shared/StatefulVue.ts)
-- Creating a singleton of the state and makes it available to presentation layer as single source of truth.
+- `StatefulVue` includes abstract `handleCollectionState` that is fired once the component is loaded and also each time [collection](./collection-files.md) is changed.
-- Providing virtual abstract `handleCollectionState` callback that it calls when
+- Do not forget to subscribe from events when component is destroyed or if needed [collection](./collection-files.md) is changed.
-  - the Vue loads the component,
+  - 💡 `events` in base class [`StatefulVue`](./../src/presentation/components/Shared/StatefulVue.ts) makes lifecycling easier
-  - and also every time when state changes.
+- 📖 See [Application state | Application layer](./presentation.md#application-state) where the state is implemented using using state pattern.
-- Providing `events` member to make lifecycling of state subscriptions events easier because it ensures that components unsubscribe from listening to state events when
-  - the component is no longer used (destroyed),
-  - an if [ApplicationContext](./../src/application/Context/ApplicationContext.ts) changes the active [collection](./collection-files.md) to a different one.
-
-📖 Refer to [architecture.md | Application State](./architecture.md#application-state) to get an overview of event handling and [application.md | Application State](./presentation.md#application-state) for deeper look into how the application layer manages state.
 
 ## Modals
 
-[Dialog.vue](./../src/presentation/components/Shared/Dialog.vue) is a shared component that other components used to show modal windows.
+- [Dialog.vue](./../src/presentation/components/Shared/Dialog.vue) is a shared component that can be used to show modal windows
-
+- Simply wrap the content inside of its slot and call `.show()` method on its reference.
-You can use it by wrapping the content inside of its `slot` and call `.show()` function on its reference. For example:
+- Example:
 
   ```html
     <Dialog ref="testDialog">
@@ -68,15 +58,15 @@ You can use it by wrapping the content inside of its `slot` and call `.show()` f
 
 ## Sass naming convention
 
-- Use lowercase for variables/functions/mixins, e.g.:
+- Use lowercase for variables/functions/mixins e.g.
   - Variable: `$variable: value;`
   - Function: `@function function() {}`
   - Mixin: `@mixin mixin() {}`
-- Use - for a phrase/compound word, e.g.:
+- Use - for a phrase/compound word e.g.
   - Variable: `$some-variable: value;`
   - Function: `@function some-function() {}`
   - Mixin: `@mixin some-mixin() {}`
-- Grouping and name variables from generic to specific, e.g.:
+- Grouping and name variables from generic to specific e.g.
   - ✅ `$border-blue`, `$border-blue-light`, `$border-blue-lightest`, `$border-red`
   - ❌ `$blue-border`, `$light-blue-border`, `$lightest-blue-border`, `$red-border`
   

docs/templating.md

@@ -3,15 +3,14 @@
 ## Benefits of templating
 
 - Generating scripts by sharing code to increase best-practice usage and maintainability.
-- Creating self-contained scripts without cross-dependencies.
+- Creating self-contained scripts without depending on each other that can be easily shared.
 - Use of pipes for writing cleaner code and letting pipes do dirty work.
 
 ## Expressions
 
-- Expressions start and end with mustaches (double brackets, `{{` and `}}`).
+- Expressions in the language are defined inside mustaches (double brackets, `{{` and `}}`).
-  - E.g. `Hello {{ $name }} !`
+- Expression syntax is inspired mainly by [Go Templates](https://pkg.go.dev/text/template).
-- Syntax is close to [Go Templates ❤️](https://pkg.go.dev/text/template) that has inspired this templating language.
+- Expressions are used in and enabled by functions where they can be used.
-- Functions enables usage of expressions.
   - In script definition parts of a function, see [`Function`](./collection-files.md#Function).
   - When doing a call as argument values, see [`FunctionCall`](./collection-files.md#Function).
 
@@ -56,15 +55,13 @@ A function can call other functions such as:
 
 ### with
 
-Skips its "block" if the variable is absent or empty. Its "block" is between `with` start (`{{ with .. }}`) and end (`{{ end }`}) expressions. E.g. `{{ with $parameterName }} Hi, I'm a block! {{ end }}`.
+- Skips the block if the variable is absent or empty.
+- Binds its context (`.`) value of provided argument for the parameter if provided one.
+- A block is defined as `{{ with $parameterName }} Parameter value is {{ . }} here {{ end }}`.
+- The parameters used for `with` condition should be declared as optional, otherwise `with` block becomes redundant.
+- Example:
 
-Binds its context (`.`) value of provided argument for the parameter if provided one. E.g. `{{ with $parameterName }} Parameter value is {{ . }} here {{ end }}`.
+  ```yaml
-
-💡 Declare parameters used for `with` condition as optional. Set `optional: true` for the argument if you use it like `{{ with $argument }} .. {{ end }}`.
-
-Example:
-
-```yaml
     function: FunctionThatOutputsConditionally
     parameters:
       - name: 'argument'
@@ -73,19 +70,19 @@ Example:
       {{ with $argument }}
         Value is: {{ . }}
       {{ end }}
-```
+  ```
 
 ### Pipes
 
-- Pipes are functions available for handling text.
+- Pipes are set of functions available for handling text in privacy.sexy.
 - Allows stacking actions one after another also known as "chaining".
-- Like [Unix pipelines](https://en.wikipedia.org/wiki/Pipeline_(Unix)), the concept is simple: each pipeline's output becomes the input of the following pipe.
+- Just like [Unix pipelines](https://en.wikipedia.org/wiki/Pipeline_(Unix)), the concept is simple: each pipeline's output becomes the input of the following pipe.
-- You cannot create pipes. [A dedicated compiler](./application.md#parsing-and-compiling) provides pre-defined pipes to consume in collection files.
+- Pipes are provided and defined by the compiler and consumed by collection files.
-- You can combine pipes with other expressions such as [parameter substitution](#parameter-substitution) and [with](#with) syntax.
+- Pipes can be combined with [parameter substitution](#parameter-substitution) and [with](#with).
 - ❗ Pipe names must be camelCase without any space or special characters.
 - **Existing pipes**
   - `inlinePowerShell`: Converts a multi-lined PowerShell script to a single line.
-  - `escapeDoubleQuotes`: Escapes `"` characters, allows you to use them inside double quotes (`"`).
+  - `escapeDoubleQuotes`: Escapes `"` characters to be used inside double quotes (`"`)
 - **Example usages**
   - `{{ with $code }} echo "{{ . | inlinePowerShell }}" {{ end }}`
   - `{{ with $code }} echo "{{ . | inlinePowerShell | escapeDoubleQuotes }}" {{ end }}`

docs/tests.md

@@ -1,81 +1,43 @@
 # Tests
 
-There are different types of tests executed:
+- There are two different types of tests executed:
-
+  1. [Unit tests](#unit-tests)
-1. [Unit tests](#unit-tests)
+  2. [Integration tests](#integration-tests)
-2. [Integration tests](#integration-tests)
+- 💡 You can use path/module alias `@/tests` in import statements.
-3. [End-to-end (E2E) tests](#e2e-tests)
-
-Common aspects for all tests:
-
-- They use [Mocha](https://mochajs.org/) and [Chai](https://www.chaijs.com/).
-- Their files end with `.spec.{ts|js}` suffix.
-
-💡 You can use path/module alias `@/tests` in import statements.
 
 ## Unit tests
 
-- Unit tests test each component in isolation.
+- Tests each component in isolation
-- All unit tests goes under [`./tests/unit`](./../tests/unit).
+- Defined in [`./tests/unit`](./../tests/unit)
-- They rely on [stubs](./../tests/unit/shared/Stubs) for isolation.
+- They follow same folder structure as [`./src`](./../src)
 
-### Unit tests structure
+### Naming
 
-- [`./src/`](./../src/)
+- Each test suite first describe the system under test
-  - Includes source code that unit tests will test.
+  - E.g. tests for class `Application` is categorized under `Application`
-- [`./tests/unit/`](./../tests/unit/)
+- Tests for specific methods are categorized under method name (if applicable)
-  - Includes test code.
+  - E.g. test for `run()` is categorized under `run`
-  - Tests follow same folder structure as [`./src/`](./../src).
-    - E.g. if system under test lies in [`./src/application/ApplicationFactory.ts`](./../src/application/ApplicationFactory.ts) then its tests would be in test would be at [`./tests/unit/application/ApplicationFactory.spec.ts`](./../tests/unit/application/ApplicationFactory.spec.ts).
-  - [`shared/`](./../tests/unit/shared/)
-    - Includes common functionality that's shared across unit tests.
-    - [`Assertions/`](./../tests/unit/shared/Assertions):
-      - Common assertions that extend [Chai Assertion Library](https://www.chaijs.com/).
-      - Asserting functions should start with `expect` prefix.
-    - [`TestCases/`](./../tests/unit/shared/TestCases/)
-      - Shared test cases.
-      - Functions that calls `it()` from [Mocha test framework](https://mochajs.org/) should have `it` prefix.
-        - E.g. `itEachAbsentCollectionValue()`.
-    - [`Stubs/`](./../tests/unit/shared/Stubs)
-      - Includes stubs to be able to test components in isolation.
-      - Stubs have minimal and dummy behavior to be functional, they may also have spying or mocking functions.
-
-### Unit tests naming
-
-- Each test suite first describe the system under test.
-  - E.g. tests for class `Application.ts` are all inside `Application.spec.ts`.
-- `describe` blocks tests for same function (if applicable).
-  - E.g. test for `run()` are inside `describe('run', () => ..)`.
 
 ### Act, arrange, assert
 
-- Tests use act, arrange and assert (AAA) pattern when applicable.
+- Tests use act, arrange and assert (AAA) pattern when applicable
 - **Arrange**
-  - Sets up the test case.
+  - Should set up the test case
-  - Starts with comment line `// arrange`.
+  - Starts with comment line `// arrange`
 - **Act**
-  - Executes the actual test.
+  - Should cover the main thing to be tested
-  - Starts with comment line `// act`.
+  - Starts with comment line `// act`
 - **Assert**
-  - Elicit some sort of expectation.
+  - Should elicit some sort of response
-  - Starts with comment line `// assert`.
+  - Starts with comment line `// assert`
+
+### Stubs
+
+- Stubs are defined in [`./tests/stubs`](./../tests/unit/stubs)
+- They implement dummy behavior to be functional
 
 ## Integration tests
 
-- Tests functionality of a component in combination with others (not isolated).
+- Tests functionality of a component in combination with others (not isolated)
-- Ensure dependencies to third parties work as expected.
+- Ensure dependencies to third parties work as expected
-- Defined in [./tests/integration](./../tests/integration).
+- Defined in [`./tests/integration`](./../tests/integration)
-
-## E2E tests
-
-- Test the functionality and performance of a running application.
-- Vue CLI plugin  [`e2e-cypress`](https://github.com/vuejs/vue-cli/tree/dev/packages/@vue/cli-plugin-e2e-cypress#readme) configures E2E tests.
-- Test names and folders have logical structure based on tests executed.
-- The structure is following:
-  - [`cypress.json`](./../cypress.json): Cypress configuration file.
-  - [`./tests/e2e/`](./../tests/e2e/): Base Cypress folder.
-    - [`/specs/`](./../tests/e2e/specs/): Test files named with `.spec.js` extension.
-    - [`/plugins/index.js`](./../tests/e2e/plugins/index.js): Plugin file executed before loading project.
-    - [`/support/index.js`](./../tests/e2e/support/index.js): Support file, runs before every single spec file.
-    - *(Ignored)* `/videos`: Asset folder for videos taken during tests.
-    - *(Ignored)* `/screenshots`: Asset folder for Screenshots taken during tests.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "privacy.sexy",
-  "version": "0.11.3",
+  "version": "0.11.1",
   "private": true,
   "description": "Enforce privacy & security best-practices on Windows and macOS, because privacy is sexy 🍑🍆",
   "author": "undergroundwires",
@@ -8,18 +8,17 @@
     "serve": "vue-cli-service serve",
     "build": "vue-cli-service build",
     "test:unit": "vue-cli-service test:unit",
-    "test:e2e": "vue-cli-service test:e2e",
+    "test:integration": "vue-cli-service test:unit \"tests/integration/**/*.spec.ts\"",
-    "lint": "npm run lint:md && npm run lint:md:consistency && npm run lint:md:relative-urls && npm run lint:eslint && npm run lint:yaml",
+    "lint": "npm run lint:vue && npm run lint:yaml && npm run lint:md && npm run lint:md:relative-urls && npm run lint:md:consistency",
     "electron:build": "vue-cli-service electron:build",
     "electron:serve": "vue-cli-service electron:serve",
     "lint:md": "markdownlint **/*.md --ignore node_modules",
     "lint:md:consistency": "remark . --frail --use remark-preset-lint-consistent",
     "lint:md:relative-urls": "remark . --frail --use remark-validate-links",
-    "lint:eslint": "vue-cli-service lint --no-fix --mode production",
+    "lint:vue": "vue-cli-service lint --no-fix",
     "lint:yaml": "yamllint **/*.yaml --ignore=node_modules/**/*.yaml",
     "postinstall": "electron-builder install-app-deps",
-    "postuninstall": "electron-builder install-app-deps",
+    "postuninstall": "electron-builder install-app-deps"
-    "test:integration": "vue-cli-service test:unit \"tests/integration/**/*.spec.ts\""
   },
   "main": "background.js",
   "dependencies": {
@@ -48,46 +47,31 @@
     "@types/chai": "^4.2.22",
     "@types/file-saver": "^2.0.3",
     "@types/mocha": "^9.0.0",
-    "@typescript-eslint/eslint-plugin": "^5.4.0",
+    "@vue/cli-plugin-babel": "^4.5.14",
-    "@typescript-eslint/parser": "^5.4.0",
+    "@vue/cli-plugin-typescript": "^4.5.14",
-    "@vue/cli-plugin-babel": "~5.0.0-rc.1",
+    "@vue/cli-plugin-unit-mocha": "^4.5.14",
-    "@vue/cli-plugin-e2e-cypress": "~5.0.0-rc.1",
+    "@vue/cli-service": "^4.5.14",
-    "@vue/cli-plugin-eslint": "~5.0.0-rc.1",
-    "@vue/cli-plugin-typescript": "~5.0.0-rc.1",
-    "@vue/cli-plugin-unit-mocha": "~5.0.0-rc.1",
-    "@vue/cli-service": "~5.0.0-rc.1",
-    "@vue/eslint-config-airbnb": "^6.0.0",
-    "@vue/eslint-config-typescript": "^9.1.0",
     "@vue/test-utils": "1.2.2",
     "chai": "^4.3.4",
-    "cypress": "^8.3.0",
     "electron": "^15.3.0",
-    "electron-builder": "^22.14.13",
     "electron-devtools-installer": "^3.2.0",
     "electron-log": "^4.4.1",
     "electron-updater": "^4.3.9",
-    "eslint": "^7.32.0",
-    "eslint-plugin-import": "^2.25.3",
-    "eslint-plugin-vue": "^8.0.3",
-    "eslint-plugin-vuejs-accessibility": "^1.1.0",
     "js-yaml-loader": "^1.2.2",
     "markdownlint-cli": "^0.29.0",
+    "raw-loader": "^4.0.2",
     "remark-cli": "^10.0.0",
     "remark-lint-no-dead-urls": "^1.1.0",
     "remark-preset-lint-consistent": "^5.1.0",
     "remark-validate-links": "^11.0.1",
     "sass": "^1.43.3",
     "sass-loader": "10.2.0",
-    "ts-loader": "9.0.1",
     "tslib": "^2.3.1",
     "typescript": "^4.4.4",
     "vue-cli-plugin-electron-builder": "^2.1.1",
     "vue-template-compiler": "^2.6.14",
     "yaml-lint": "^1.2.4"
   },
-  "//devDependencies": {
-    "ts-loader": "Here as workaround for vue-cli-plugin-electron-builder using older webpack 4"
-  },
   "homepage": "https://privacy.sexy",
   "repository": {
     "type": "git",

postcss.config.js

@@ -1,5 +1,5 @@
 module.exports = {
   plugins: {
-    autoprefixer: {},
+    autoprefixer: {}
-  },
+  }
-};
+}

src/application/ApplicationFactory.ts

@@ -3,21 +3,18 @@ import { AsyncLazy } from '@/infrastructure/Threading/AsyncLazy';
 import { IApplicationFactory } from './IApplicationFactory';
 import { parseApplication } from './Parser/ApplicationParser';
 
-export type ApplicationGetterType = () => IApplication;
+export type ApplicationGetter = () => IApplication;
-const ApplicationGetter: ApplicationGetterType = parseApplication;
+const ApplicationGetter: ApplicationGetter = parseApplication;
 
 export class ApplicationFactory implements IApplicationFactory {
     public static readonly Current: IApplicationFactory = new ApplicationFactory(ApplicationGetter);
-
     private readonly getter: AsyncLazy<IApplication>;
-
+    protected constructor(costlyGetter: ApplicationGetter) {
-  protected constructor(costlyGetter: ApplicationGetterType) {
         if (!costlyGetter) {
-      throw new Error('missing getter');
+            throw new Error('undefined getter');
         }
         this.getter = new AsyncLazy<IApplication>(() => Promise.resolve(costlyGetter()));
     }
-
     public getApp(): Promise<IApplication> {
         return this.getter.getValue();
     }

src/application/Common/Array.ts

@@ -1,7 +1,7 @@
 // Compares to Array<T> objects for equality, ignoring order
 export function scrambledEqual<T>(array1: readonly T[], array2: readonly T[]) {
-  if (!array1) { throw new Error('missing first array'); }
+    if (!array1) { throw new Error('undefined first array'); }
-  if (!array2) { throw new Error('missing second array'); }
+    if (!array2) { throw new Error('undefined second array'); }
     const sortedArray1 = sort(array1);
     const sortedArray2 = sort(array2);
     return sequenceEqual(sortedArray1, sortedArray2);
@@ -12,8 +12,8 @@ export function scrambledEqual<T>(array1: readonly T[], array2: readonly T[]) {
 
 // Compares to Array<T> objects for equality in same order
 export function sequenceEqual<T>(array1: readonly T[], array2: readonly T[]) {
-  if (!array1) { throw new Error('missing first array'); }
+    if (!array1) { throw new Error('undefined first array'); }
-  if (!array2) { throw new Error('missing second array'); }
+    if (!array2) { throw new Error('undefined second array'); }
     if (array1.length !== array2.length) {
         return false;
     }

src/application/Common/Enum.ts

@@ -1,27 +1,22 @@
 // Because we cannot do "T extends enum" 😞 https://github.com/microsoft/TypeScript/issues/30611
 export type EnumType = number | string;
-export type EnumVariable<T extends EnumType, TEnumValue extends EnumType>
+export type EnumVariable<T extends EnumType, TEnumValue extends EnumType> = { [key in T]: TEnumValue };
-  = { [key in T]: TEnumValue };
 
 export interface IEnumParser<TEnum> {
     parseEnum(value: string, propertyName: string): TEnum;
 }
-
 export function createEnumParser<T extends EnumType, TEnumValue extends EnumType>(
-  enumVariable: EnumVariable<T, TEnumValue>,
+    enumVariable: EnumVariable<T, TEnumValue>): IEnumParser<TEnumValue> {
-): IEnumParser<TEnumValue> {
     return {
         parseEnum: (value, propertyName) => parseEnumValue(value, propertyName, enumVariable),
     };
 }
-
 function parseEnumValue<T extends EnumType, TEnumValue extends EnumType>(
     value: string,
     enumName: string,
-  enumVariable: EnumVariable<T, TEnumValue>,
+    enumVariable: EnumVariable<T, TEnumValue>): TEnumValue {
-): TEnumValue {
     if (!value) {
-    throw new Error(`missing ${enumName}`);
+        throw new Error(`undefined ${enumName}`);
     }
     if (typeof value !== 'string') {
         throw new Error(`unexpected type of ${enumName}: "${typeof value}"`);
@@ -34,28 +29,24 @@ function parseEnumValue<T extends EnumType, TEnumValue extends EnumType>(
     return enumVariable[casedValue as keyof typeof enumVariable];
 }
 
-export function getEnumNames
+export function getEnumNames<T extends EnumType, TEnumValue extends EnumType>(
-<T extends EnumType, TEnumValue extends EnumType>(
+    enumVariable: EnumVariable<T, TEnumValue>): string[] {
-  enumVariable: EnumVariable<T, TEnumValue>,
-): string[] {
     return Object
         .values(enumVariable)
         .filter((enumMember) => typeof enumMember === 'string') as string[];
 }
 
 export function getEnumValues<T extends EnumType, TEnumValue extends EnumType>(
-  enumVariable: EnumVariable<T, TEnumValue>,
+    enumVariable: EnumVariable<T, TEnumValue>): TEnumValue[] {
-): TEnumValue[] {
     return getEnumNames(enumVariable)
         .map((level) => enumVariable[level]) as TEnumValue[];
 }
 
 export function assertInRange<T extends EnumType, TEnumValue extends EnumType>(
     value: TEnumValue,
-  enumVariable: EnumVariable<T, TEnumValue>,
+    enumVariable: EnumVariable<T, TEnumValue>) {
-) {
+    if (value === undefined) {
-  if (value === undefined || value === null) {
+        throw new Error('undefined enum value');
-    throw new Error('absent enum value');
     }
     if (!(value in enumVariable)) {
         throw new RangeError(`enum value "${value}" is out of range`);

src/application/Common/ScriptingLanguage/ScriptingLanguageFactory.ts

@@ -1,6 +1,6 @@
 import { ScriptingLanguage } from '@/domain/ScriptingLanguage';
-import { assertInRange } from '@/application/Common/Enum';
 import { IScriptingLanguageFactory } from './IScriptingLanguageFactory';
+import { assertInRange } from '@/application/Common/Enum';
 
 type Getter<T> = () => T;
 
@@ -20,11 +20,12 @@ export abstract class ScriptingLanguageFactory<T> implements IScriptingLanguageF
     protected registerGetter(language: ScriptingLanguage, getter: Getter<T>) {
         assertInRange(language, ScriptingLanguage);
         if (!getter)  {
-      throw new Error('missing getter');
+            throw new Error('undefined getter');
         }
         if (this.getters.has(language)) {
             throw new Error(`${ScriptingLanguage[language]} is already registered`);
         }
         this.getters.set(language, getter);
     }
+
 }

src/application/Context/ApplicationContext.ts

@@ -1,19 +1,17 @@
+import { IApplicationContext, IApplicationContextChangedEvent } from './IApplicationContext';
+import { ICategoryCollectionState } from './State/ICategoryCollectionState';
+import { CategoryCollectionState } from './State/CategoryCollectionState';
 import { IApplication } from '@/domain/IApplication';
 import { OperatingSystem } from '@/domain/OperatingSystem';
 import { ICategoryCollection } from '@/domain/ICategoryCollection';
 import { EventSource } from '@/infrastructure/Events/EventSource';
 import { assertInRange } from '@/application/Common/Enum';
-import { CategoryCollectionState } from './State/CategoryCollectionState';
-import { ICategoryCollectionState } from './State/ICategoryCollectionState';
-import { IApplicationContext, IApplicationContextChangedEvent } from './IApplicationContext';
 
 type StateMachine = Map<OperatingSystem, ICategoryCollectionState>;
 
 export class ApplicationContext implements IApplicationContext {
     public readonly contextChanged = new EventSource<IApplicationContextChangedEvent>();
-
     public collection: ICategoryCollection;
-
     public currentOs: OperatingSystem;
 
     public get state(): ICategoryCollectionState {
@@ -21,18 +19,16 @@ export class ApplicationContext implements IApplicationContext {
     }
 
     private readonly states: StateMachine;
-
     public constructor(
         public readonly app: IApplication,
-    initialContext: OperatingSystem,
+        initialContext: OperatingSystem) {
-  ) {
         validateApp(app);
+        assertInRange(initialContext, OperatingSystem);
         this.states = initializeStates(app);
         this.changeContext(initialContext);
     }
 
     public changeContext(os: OperatingSystem): void {
-    assertInRange(os, OperatingSystem);
         if (this.currentOs === os) {
             return;
         }
@@ -51,7 +47,7 @@ export class ApplicationContext implements IApplicationContext {
 
 function validateApp(app: IApplication) {
     if (!app) {
-    throw new Error('missing app');
+        throw new Error('undefined app');
     }
 }
 

src/application/Context/ApplicationContextFactory.ts

@@ -1,18 +1,17 @@
+import { ApplicationContext } from './ApplicationContext';
 import { IApplicationContext } from '@/application/Context/IApplicationContext';
 import { OperatingSystem } from '@/domain/OperatingSystem';
-import { IApplication } from '@/domain/IApplication';
 import { Environment } from '../Environment/Environment';
+import { IApplication } from '@/domain/IApplication';
 import { IEnvironment } from '../Environment/IEnvironment';
 import { IApplicationFactory } from '../IApplicationFactory';
 import { ApplicationFactory } from '../ApplicationFactory';
-import { ApplicationContext } from './ApplicationContext';
 
 export async function buildContext(
     factory: IApplicationFactory = ApplicationFactory.Current,
-  environment = Environment.CurrentEnvironment,
+    environment = Environment.CurrentEnvironment): Promise<IApplicationContext> {
-): Promise<IApplicationContext> {
+    if (!factory) { throw new Error('undefined factory'); }
-  if (!factory) { throw new Error('missing factory'); }
+    if (!environment) { throw new Error('undefined environment'); }
-  if (!environment) { throw new Error('missing environment'); }
     const app = await factory.getApp();
     const os = getInitialOs(app, environment);
     return new ApplicationContext(app, os);

src/application/Context/IApplicationContext.ts

@@ -1,16 +1,12 @@
+import { ICategoryCollectionState } from './State/ICategoryCollectionState';
 import { OperatingSystem } from '@/domain/OperatingSystem';
 import { IEventSource } from '@/infrastructure/Events/IEventSource';
 import { IApplication } from '@/domain/IApplication';
-import { ICategoryCollectionState, IReadOnlyCategoryCollectionState } from './State/ICategoryCollectionState';
 
-export interface IReadOnlyApplicationContext {
+export interface IApplicationContext {
     readonly app: IApplication;
-  readonly state: IReadOnlyCategoryCollectionState;
-  readonly contextChanged: IEventSource<IApplicationContextChangedEvent>;
-}
-
-export interface IApplicationContext extends IReadOnlyApplicationContext {
     readonly state: ICategoryCollectionState;
+    readonly contextChanged: IEventSource<IApplicationContextChangedEvent>;
     changeContext(os: OperatingSystem): void;
 }
 

src/application/Context/State/CategoryCollectionState.ts

@@ -1,5 +1,3 @@
-import { ICategoryCollection } from '@/domain/ICategoryCollection';
-import { OperatingSystem } from '@/domain/OperatingSystem';
 import { UserFilter } from './Filter/UserFilter';
 import { IUserFilter } from './Filter/IUserFilter';
 import { ApplicationCode } from './Code/ApplicationCode';
@@ -7,14 +5,13 @@ import { UserSelection } from './Selection/UserSelection';
 import { IUserSelection } from './Selection/IUserSelection';
 import { ICategoryCollectionState } from './ICategoryCollectionState';
 import { IApplicationCode } from './Code/IApplicationCode';
+import { ICategoryCollection } from '../../../domain/ICategoryCollection';
+import { OperatingSystem } from '@/domain/OperatingSystem';
 
 export class CategoryCollectionState implements ICategoryCollectionState {
     public readonly os: OperatingSystem;
-
     public readonly code: IApplicationCode;
-
     public readonly selection: IUserSelection;
-
     public readonly filter: IUserFilter;
 
     public constructor(readonly collection: ICategoryCollection) {

src/application/Context/State/Code/ApplicationCode.ts

@@ -1,29 +1,27 @@
-import { SelectedScript } from '@/application/Context/State/Selection/SelectedScript';
-import { IReadOnlyUserSelection } from '@/application/Context/State/Selection/IUserSelection';
-import { EventSource } from '@/infrastructure/Events/EventSource';
-import { IScriptingDefinition } from '@/domain/IScriptingDefinition';
 import { CodeChangedEvent } from './Event/CodeChangedEvent';
 import { CodePosition } from './Position/CodePosition';
 import { ICodeChangedEvent } from './Event/ICodeChangedEvent';
+import { SelectedScript } from '@/application/Context/State/Selection/SelectedScript';
+import { IUserSelection } from '@/application/Context/State/Selection/IUserSelection';
 import { UserScriptGenerator } from './Generation/UserScriptGenerator';
+import { EventSource } from '@/infrastructure/Events/EventSource';
 import { IApplicationCode } from './IApplicationCode';
 import { IUserScriptGenerator } from './Generation/IUserScriptGenerator';
+import { IScriptingDefinition } from '@/domain/IScriptingDefinition';
 
 export class ApplicationCode implements IApplicationCode {
     public readonly changed = new EventSource<ICodeChangedEvent>();
-
     public current: string;
 
     private scriptPositions = new Map<SelectedScript, CodePosition>();
 
     constructor(
-    userSelection: IReadOnlyUserSelection,
+        userSelection: IUserSelection,
         private readonly scriptingDefinition: IScriptingDefinition,
-    private readonly generator: IUserScriptGenerator = new UserScriptGenerator(),
+        private readonly generator: IUserScriptGenerator = new UserScriptGenerator()) {
-  ) {
+        if (!userSelection) { throw new Error('userSelection is null or undefined'); }
-    if (!userSelection) { throw new Error('missing userSelection'); }
+        if (!scriptingDefinition) { throw new Error('scriptingDefinition is null or undefined'); }
-    if (!scriptingDefinition) { throw new Error('missing scriptingDefinition'); }
+        if (!generator) { throw new Error('generator is null or undefined'); }
-    if (!generator) { throw new Error('missing generator'); }
         this.setCode(userSelection.selectedScripts);
         userSelection.changed.on((scripts) => {
             this.setCode(scripts);

src/application/Context/State/Code/Event/CodeChangedEvent.ts

@@ -1,15 +1,12 @@
+import { ICodeChangedEvent } from './ICodeChangedEvent';
+import { SelectedScript } from '../../Selection/SelectedScript';
 import { IScript } from '@/domain/IScript';
 import { ICodePosition } from '@/application/Context/State/Code/Position/ICodePosition';
-import { SelectedScript } from '../../Selection/SelectedScript';
-import { ICodeChangedEvent } from './ICodeChangedEvent';
 
 export class CodeChangedEvent implements ICodeChangedEvent {
     public readonly code: string;
-
     public readonly addedScripts: ReadonlyArray<IScript>;
-
     public readonly removedScripts: ReadonlyArray<IScript>;
-
     public readonly changedScripts: ReadonlyArray<IScript>;
 
     private readonly scripts: Map<IScript, ICodePosition>;
@@ -17,8 +14,7 @@ export class CodeChangedEvent implements ICodeChangedEvent {
     constructor(
         code: string,
         oldScripts: ReadonlyArray<SelectedScript>,
-    scripts: Map<SelectedScript, ICodePosition>,
+        scripts: Map<SelectedScript, ICodePosition>) {
-  ) {
         ensureAllPositionsExist(code, Array.from(scripts.values()));
         this.code = code;
         const newScripts = Array.from(scripts.keys());
@@ -42,29 +38,26 @@ export class CodeChangedEvent implements ICodeChangedEvent {
 
 function ensureAllPositionsExist(script: string, positions: ReadonlyArray<ICodePosition>) {
     const totalLines = script.split(/\r\n|\r|\n/).length;
-  const missingPositions = positions.filter((position) => position.endLine > totalLines);
+    for (const position of positions) {
-  if (missingPositions.length > 0) {
+        if (position.endLine > totalLines) {
-    throw new Error(
+            throw new Error(`script end line (${position.endLine}) is out of range.` +
-      `Out of range script end line: "${missingPositions.map((pos) => pos.endLine).join('", "')}"`
+                            `(total code lines: ${totalLines}`);
-        + `(total code lines: ${totalLines}).`,
+        }
-    );
     }
 }
 
 function getChangedScripts(
     oldScripts: ReadonlyArray<SelectedScript>,
-  newScripts: ReadonlyArray<SelectedScript>,
+    newScripts: ReadonlyArray<SelectedScript>): ReadonlyArray<IScript> {
-): ReadonlyArray<IScript> {
     return newScripts
         .filter((newScript) => oldScripts.find((oldScript) => oldScript.id === newScript.id
-      && oldScript.revert !== newScript.revert))
+                               && oldScript.revert !== newScript.revert ))
         .map((selection) => selection.script);
 }
 
 function selectIfNotExists(
     selectableContainer: ReadonlyArray<SelectedScript>,
-  test: ReadonlyArray<SelectedScript>,
+    test: ReadonlyArray<SelectedScript>) {
-) {
     return selectableContainer
         .filter((script) => !test.find((oldScript) => oldScript.id === script.id))
         .map((selection) => selection.script);

src/application/Context/State/Code/Generation/CodeBuilder.ts

@@ -17,13 +17,14 @@ export abstract class CodeBuilder implements ICodeBuilder {
             return this;
         }
         const lines = code.match(/[^\r\n]+/g);
-    this.lines.push(...lines);
+        for (const line of lines) {
+            this.lines.push(line);
+        }
         return this;
     }
 
     public appendTrailingHyphensCommentLine(
-    totalRepeatHyphens: number = TotalFunctionSeparatorChars,
+        totalRepeatHyphens: number = TotalFunctionSeparatorChars): CodeBuilder {
-  ): CodeBuilder {
         return this.appendCommentLine('-'.repeat(totalRepeatHyphens));
     }
 
@@ -44,8 +45,7 @@ export abstract class CodeBuilder implements ICodeBuilder {
 
     public appendCommentLineWithHyphensAround(
         sectionName: string,
-    totalRepeatHyphens: number = TotalFunctionSeparatorChars,
+        totalRepeatHyphens: number = TotalFunctionSeparatorChars): CodeBuilder {
-  ): CodeBuilder {
         if (!sectionName)  { throw new Error('sectionName cannot be empty or null'); }
         if (sectionName.length >= totalRepeatHyphens) {
             return this.appendCommentLine(sectionName);
@@ -63,6 +63,5 @@ export abstract class CodeBuilder implements ICodeBuilder {
     }
 
     protected abstract getCommentDelimiter(): string;
-
     protected abstract writeStandardOut(text: string): string;
 }

src/application/Context/State/Code/Generation/CodeBuilderFactory.ts

@@ -5,9 +5,7 @@ import { BatchBuilder } from './Languages/BatchBuilder';
 import { ShellBuilder } from './Languages/ShellBuilder';
 import { ICodeBuilderFactory } from './ICodeBuilderFactory';
 
-export class CodeBuilderFactory
+export class CodeBuilderFactory extends ScriptingLanguageFactory<ICodeBuilder> implements ICodeBuilderFactory {
-  extends ScriptingLanguageFactory<ICodeBuilder>
-  implements ICodeBuilderFactory {
     constructor() {
         super();
         this.registerGetter(ScriptingLanguage.shellscript, () => new ShellBuilder());

src/application/Context/State/Code/Generation/ICodeBuilderFactory.ts

@@ -1,4 +1,5 @@
-import { IScriptingLanguageFactory } from '@/application/Common/ScriptingLanguage/IScriptingLanguageFactory';
 import { ICodeBuilder } from './ICodeBuilder';
+import { IScriptingLanguageFactory } from '@/application/Common/ScriptingLanguage/IScriptingLanguageFactory';
 
-export type ICodeBuilderFactory = IScriptingLanguageFactory<ICodeBuilder>;
+export interface ICodeBuilderFactory extends IScriptingLanguageFactory<ICodeBuilder> {
+}

src/application/Context/State/Code/Generation/IUserScriptGenerator.ts

@@ -1,6 +1,6 @@
 import { SelectedScript } from '@/application/Context/State/Selection/SelectedScript';
-import { IScriptingDefinition } from '@/domain/IScriptingDefinition';
 import { IUserScript } from './IUserScript';
+import { IScriptingDefinition } from '@/domain/IScriptingDefinition';
 
 export interface IUserScriptGenerator {
     buildCode(

src/application/Context/State/Code/Generation/Languages/BatchBuilder.ts

@@ -4,7 +4,6 @@ export class BatchBuilder extends CodeBuilder {
     protected getCommentDelimiter(): string {
         return '::';
     }
-
     protected writeStandardOut(text: string): string {
         return `echo ${escapeForEcho(text)}`;
     }

src/application/Context/State/Code/Generation/Languages/ShellBuilder.ts

@@ -4,7 +4,6 @@ export class ShellBuilder extends CodeBuilder {
     protected getCommentDelimiter(): string {
         return '#';
     }
-
     protected writeStandardOut(text: string): string {
         return `echo '${escapeForEcho(text)}'`;
     }

src/application/Context/State/Code/Generation/UserScriptGenerator.ts

@@ -1,9 +1,9 @@
 import { SelectedScript } from '@/application/Context/State/Selection/SelectedScript';
-import { ICodePosition } from '@/application/Context/State/Code/Position/ICodePosition';
-import { IScriptingDefinition } from '@/domain/IScriptingDefinition';
-import { CodePosition } from '../Position/CodePosition';
 import { IUserScriptGenerator } from './IUserScriptGenerator';
+import { ICodePosition } from '@/application/Context/State/Code/Position/ICodePosition';
+import { CodePosition } from '../Position/CodePosition';
 import { IUserScript } from './IUserScript';
+import { IScriptingDefinition } from '@/domain/IScriptingDefinition';
 import { ICodeBuilder } from './ICodeBuilder';
 import { ICodeBuilderFactory } from './ICodeBuilderFactory';
 import { CodeBuilderFactory } from './CodeBuilderFactory';
@@ -12,21 +12,20 @@ export class UserScriptGenerator implements IUserScriptGenerator {
     constructor(private readonly codeBuilderFactory: ICodeBuilderFactory = new CodeBuilderFactory()) {
 
     }
-
     public buildCode(
         selectedScripts: ReadonlyArray<SelectedScript>,
-    scriptingDefinition: IScriptingDefinition,
+        scriptingDefinition: IScriptingDefinition): IUserScript {
-  ): IUserScript {
+        if (!selectedScripts) { throw new Error('undefined scripts'); }
-    if (!selectedScripts) { throw new Error('missing scripts'); }
+        if (!scriptingDefinition) { throw new Error('undefined definition'); }
-    if (!scriptingDefinition) { throw new Error('missing definition'); }
+        let scriptPositions = new Map<SelectedScript, ICodePosition>();
         if (!selectedScripts.length) {
-      return { code: '', scriptPositions: new Map<SelectedScript, ICodePosition>() };
+            return { code: '', scriptPositions };
         }
         let builder = this.codeBuilderFactory.create(scriptingDefinition.language);
         builder = initializeCode(scriptingDefinition.startCode, builder);
-    const scriptPositions = selectedScripts.reduce((result, selection) => {
+        for (const selection of selectedScripts) {
-      return appendSelection(selection, result, builder);
+            scriptPositions = appendSelection(selection, scriptPositions, builder);
-    }, new Map<SelectedScript, ICodePosition>());
+        }
         const code = finalizeCode(builder, scriptingDefinition.endCode);
         return { code, scriptPositions };
     }
@@ -53,11 +52,9 @@ function finalizeCode(builder: ICodeBuilder, endCode: string): string {
 function appendSelection(
     selection: SelectedScript,
     scriptPositions: Map<SelectedScript, ICodePosition>,
-  builder: ICodeBuilder,
+    builder: ICodeBuilder): Map<SelectedScript, ICodePosition> {
-): Map<SelectedScript, ICodePosition> {
+    const startPosition = builder.currentLine + 1; // Because first line will be empty to separate scripts
-  // Start from next line because first line will be empty to separate scripts
+    builder = appendCode(selection, builder);
-  const startPosition = builder.currentLine + 1;
-  appendCode(selection, builder);
     const endPosition = builder.currentLine - 1;
     builder.appendLine();
     const position = new CodePosition(startPosition, endPosition);
@@ -66,9 +63,8 @@ function appendSelection(
 }
 
 function appendCode(selection: SelectedScript, builder: ICodeBuilder): ICodeBuilder {
-  const { script } = selection;
+    const name = selection.revert ? `${selection.script.name} (revert)` : selection.script.name;
-  const name = selection.revert ? `${script.name} (revert)` : script.name;
+    const scriptCode = selection.revert ? selection.script.code.revert : selection.script.code.execute;
-  const scriptCode = selection.revert ? script.code.revert : script.code.execute;
     return builder
         .appendLine()
         .appendFunction(name, scriptCode);

src/application/Context/State/Code/IApplicationCode.ts

@@ -1,5 +1,5 @@
-import { IEventSource } from '@/infrastructure/Events/IEventSource';
 import { ICodeChangedEvent } from './Event/ICodeChangedEvent';
+import { IEventSource } from '@/infrastructure/Events/IEventSource';
 
 export interface IApplicationCode {
     readonly changed: IEventSource<ICodeChangedEvent>;

src/application/Context/State/Code/Position/CodePosition.ts

@@ -7,8 +7,7 @@ export class CodePosition implements ICodePosition {
 
     constructor(
         public readonly startLine: number,
-    public readonly endLine: number,
+        public readonly endLine: number) {
-  ) {
         if (startLine < 0) {
             throw new Error('Code cannot start in a negative line');
         }

src/application/Context/State/Filter/FilterResult.ts

@@ -1,18 +1,16 @@
+import { IFilterResult } from './IFilterResult';
 import { IScript } from '@/domain/IScript';
 import { ICategory } from '@/domain/ICategory';
-import { IFilterResult } from './IFilterResult';
 
 export class FilterResult implements IFilterResult {
     constructor(
         public readonly scriptMatches: ReadonlyArray<IScript>,
         public readonly categoryMatches: ReadonlyArray<ICategory>,
-    public readonly query: string,
+        public readonly query: string) {
-  ) {
         if (!query) { throw new Error('Query is empty or undefined'); }
         if (!scriptMatches) { throw new Error('Script matches is undefined'); }
         if (!categoryMatches) { throw new Error('Category matches is undefined'); }
     }
-
     public hasAnyMatches(): boolean {
         return this.scriptMatches.length > 0
          || this.categoryMatches.length > 0;

src/application/Context/State/Filter/IUserFilter.ts

@@ -1,13 +1,10 @@
 import { IEventSource } from '@/infrastructure/Events/IEventSource';
 import { IFilterResult } from './IFilterResult';
 
-export interface IReadOnlyUserFilter {
+export interface IUserFilter {
     readonly currentFilter: IFilterResult | undefined;
     readonly filtered: IEventSource<IFilterResult>;
     readonly filterRemoved: IEventSource<void>;
-}
-
-export interface IUserFilter extends IReadOnlyUserFilter {
     setFilter(filter: string): void;
     removeFilter(): void;
 }

src/application/Context/State/Filter/UserFilter.ts

@@ -1,15 +1,13 @@
 import { IScript } from '@/domain/IScript';
-import { EventSource } from '@/infrastructure/Events/EventSource';
-import { ICategoryCollection } from '@/domain/ICategoryCollection';
 import { FilterResult } from './FilterResult';
 import { IFilterResult } from './IFilterResult';
 import { IUserFilter } from './IUserFilter';
+import { EventSource } from '@/infrastructure/Events/EventSource';
+import { ICategoryCollection } from '@/domain/ICategoryCollection';
 
 export class UserFilter implements IUserFilter {
     public readonly filtered = new EventSource<IFilterResult>();
-
     public readonly filterRemoved = new EventSource<void>();
-
     public currentFilter: IFilterResult | undefined;
 
     constructor(private collection: ICategoryCollection) {
@@ -22,11 +20,9 @@ export class UserFilter implements IUserFilter {
         }
         const filterLowercase = filter.toLocaleLowerCase();
         const filteredScripts = this.collection.getAllScripts().filter(
-      (script) => isScriptAMatch(script, filterLowercase),
+            (script) => isScriptAMatch(script, filterLowercase));
-    );
         const filteredCategories = this.collection.getAllCategories().filter(
-      (category) => category.name.toLowerCase().includes(filterLowercase),
+            (category) => category.name.toLowerCase().includes(filterLowercase));
-    );
         const matches = new FilterResult(
             filteredScripts,
             filteredCategories,

src/application/Context/State/ICategoryCollectionState.ts

@@ -1,18 +1,13 @@
+import { IUserFilter } from './Filter/IUserFilter';
+import { IUserSelection } from './Selection/IUserSelection';
+import { IApplicationCode } from './Code/IApplicationCode';
 import { ICategoryCollection } from '@/domain/ICategoryCollection';
 import { OperatingSystem } from '@/domain/OperatingSystem';
-import { IReadOnlyUserFilter, IUserFilter } from './Filter/IUserFilter';
-import { IReadOnlyUserSelection, IUserSelection } from './Selection/IUserSelection';
-import { IApplicationCode } from './Code/IApplicationCode';
 
-export interface IReadOnlyCategoryCollectionState {
+export interface ICategoryCollectionState {
     readonly code: IApplicationCode;
-  readonly os: OperatingSystem;
-  readonly filter: IReadOnlyUserFilter;
-  readonly selection: IReadOnlyUserSelection;
-  readonly collection: ICategoryCollection;
-}
-
-export interface ICategoryCollectionState extends IReadOnlyCategoryCollectionState {
     readonly filter: IUserFilter;
     readonly selection: IUserSelection;
+    readonly collection: ICategoryCollection;
+    readonly os: OperatingSystem;
 }

src/application/Context/State/Selection/IUserSelection.ts

@@ -1,23 +1,20 @@
+import { SelectedScript } from './SelectedScript';
 import { IScript } from '@/domain/IScript';
 import { ICategory } from '@/domain/ICategory';
 import { IEventSource } from '@/infrastructure/Events/IEventSource';
-import { SelectedScript } from './SelectedScript';
 
-export interface IReadOnlyUserSelection {
+export interface IUserSelection {
     readonly changed: IEventSource<ReadonlyArray<SelectedScript>>;
     readonly selectedScripts: ReadonlyArray<SelectedScript>;
-  isSelected(scriptId: string): boolean;
     areAllSelected(category: ICategory): boolean;
     isAnySelected(category: ICategory): boolean;
-}
-
-export interface IUserSelection extends IReadOnlyUserSelection {
     removeAllInCategory(categoryId: number): void;
     addOrUpdateAllInCategory(categoryId: number, revert: boolean): void;
     addSelectedScript(scriptId: string, revert: boolean): void;
     addOrUpdateSelectedScript(scriptId: string, revert: boolean): void;
     removeSelectedScript(scriptId: string): void;
     selectOnly(scripts: ReadonlyArray<IScript>): void;
+    isSelected(scriptId: string): boolean;
     selectAll(): void;
     deselectAll(): void;
 }

src/application/Context/State/Selection/UserSelection.ts

@@ -1,26 +1,26 @@
+import { SelectedScript } from './SelectedScript';
+import { IUserSelection } from './IUserSelection';
 import { InMemoryRepository } from '@/infrastructure/Repository/InMemoryRepository';
 import { IScript } from '@/domain/IScript';
 import { EventSource } from '@/infrastructure/Events/EventSource';
 import { IRepository } from '@/infrastructure/Repository/IRepository';
 import { ICategory } from '@/domain/ICategory';
 import { ICategoryCollection } from '@/domain/ICategoryCollection';
-import { IUserSelection } from './IUserSelection';
-import { SelectedScript } from './SelectedScript';
 
 export class UserSelection implements IUserSelection {
     public readonly changed = new EventSource<ReadonlyArray<SelectedScript>>();
-
     private readonly scripts: IRepository<string, SelectedScript>;
 
     constructor(
         private readonly collection: ICategoryCollection,
-    selectedScripts: ReadonlyArray<SelectedScript>,
+        selectedScripts: ReadonlyArray<SelectedScript>) {
-  ) {
         this.scripts =  new InMemoryRepository<string, SelectedScript>();
+        if (selectedScripts && selectedScripts.length > 0) {
             for (const script of selectedScripts) {
                 this.scripts.addItem(script);
             }
         }
+    }
 
     public areAllSelected(category: ICategory): boolean {
         if (this.selectedScripts.length === 0) {
@@ -30,9 +30,7 @@ export class UserSelection implements IUserSelection {
         if (this.selectedScripts.length < scripts.length) {
             return false;
         }
-    return scripts.every(
+        return scripts.every((script) => this.selectedScripts.some((selected) => selected.id === script.id));
-      (script) => this.selectedScripts.some((selected) => selected.id === script.id),
-    );
     }
 
     public isAnySelected(category: ICategory): boolean {
@@ -55,20 +53,19 @@ export class UserSelection implements IUserSelection {
         this.changed.notify(this.scripts.getItems());
     }
 
-  public addOrUpdateAllInCategory(categoryId: number, revert = false): void {
+    public addOrUpdateAllInCategory(categoryId: number, revert: boolean = false): void {
-    const scriptsToAddOrUpdate = this.collection
+        const category = this.collection.findCategory(categoryId);
-      .findCategory(categoryId)
+        const scriptsToAddOrUpdate = category.getAllScriptsRecursively()
-      .getAllScriptsRecursively()
+            .filter((script) =>
-      .filter(
+                !this.scripts.exists(script.id)
-        (script) => !this.scripts.exists(script.id)
                     || this.scripts.getById(script.id).revert !== revert,
-      )
+            );
-      .map((script) => new SelectedScript(script, revert));
         if (!scriptsToAddOrUpdate.length) {
             return;
         }
         for (const script of scriptsToAddOrUpdate) {
-      this.scripts.addOrUpdateItem(script);
+            const selectedScript = new SelectedScript(script, revert);
+            this.scripts.addOrUpdateItem(selectedScript);
         }
         this.changed.notify(this.scripts.getItems());
     }
@@ -105,23 +102,16 @@ export class UserSelection implements IUserSelection {
     }
 
     public selectAll(): void {
-    const scriptsToSelect = this.collection
+        for (const script of this.collection.getAllScripts()) {
-      .getAllScripts()
+            if (!this.scripts.exists(script.id)) {
-      .filter((script) => !this.scripts.exists(script.id))
+                const selection = new SelectedScript(script, false);
-      .map((script) => new SelectedScript(script, false));
+                this.scripts.addItem(selection);
-    if (scriptsToSelect.length === 0) {
-      return;
             }
-    for (const script of scriptsToSelect) {
-      this.scripts.addItem(script);
         }
         this.changed.notify(this.scripts.getItems());
     }
 
     public deselectAll(): void {
-    if (this.scripts.length === 0) {
-      return;
-    }
         const selectedScriptIds = this.scripts.getItems().map((script) => script.id);
         for (const scriptId of selectedScriptIds) {
             this.scripts.removeItem(scriptId);
@@ -133,35 +123,19 @@ export class UserSelection implements IUserSelection {
         if (!scripts || scripts.length === 0) {
             throw new Error('Scripts are empty. Use deselectAll() if you want to deselect everything');
         }
-    let totalChanged = 0;
+        // Unselect from selected scripts
-    totalChanged += this.unselectMissingWithoutNotifying(scripts);
+        if (this.scripts.length !== 0) {
-    totalChanged += this.selectNewWithoutNotifying(scripts);
+            this.scripts.getItems()
-    if (totalChanged > 0) {
+                .filter((existing) => !scripts.some((script) => existing.id === script.id))
+                .map((script) => script.id)
+                .forEach((scriptId) => this.scripts.removeItem(scriptId));
+        }
+        // Select from unselected scripts
+        const unselectedScripts = scripts.filter((script) => !this.scripts.exists(script.id));
+        for (const toSelect of unselectedScripts) {
+            const selection = new SelectedScript(toSelect, false);
+            this.scripts.addItem(selection);
+        }
         this.changed.notify(this.scripts.getItems());
     }
-  }
-
-  private unselectMissingWithoutNotifying(scripts: readonly IScript[]): number {
-    if (this.scripts.length === 0 || scripts.length === 0) {
-      return 0;
-    }
-    const existingItems = this.scripts.getItems();
-    const missingIds = existingItems
-      .filter((existing) => !scripts.some((script) => existing.id === script.id))
-      .map((script) => script.id);
-    for (const id of missingIds) {
-      this.scripts.removeItem(id);
-    }
-    return missingIds.length;
-  }
-
-  private selectNewWithoutNotifying(scripts: readonly IScript[]): number {
-    const unselectedScripts = scripts
-      .filter((script) => !this.scripts.exists(script.id))
-      .map((script) => new SelectedScript(script, false));
-    for (const newScript of unselectedScripts) {
-      this.scripts.addItem(newScript);
-    }
-    return unselectedScripts.length;
-  }
 }

src/application/Environment/BrowserOs/BrowserOsDetector.ts

@@ -4,7 +4,6 @@ import { IBrowserOsDetector } from './IBrowserOsDetector';
 
 export class BrowserOsDetector implements IBrowserOsDetector {
     private readonly detectors = BrowserDetectors;
-
     public detect(userAgent: string): OperatingSystem | undefined {
         if (!userAgent) {
             return undefined;
@@ -20,37 +19,35 @@ export class BrowserOsDetector implements IBrowserOsDetector {
 }
 
 // Reference: https://github.com/keithws/browser-report/blob/master/index.js#L304
-const BrowserDetectors = [
+const BrowserDetectors =
-  define(OperatingSystem.KaiOS, (b) => b
+[
-    .mustInclude('KAIOS')),
+    define(OperatingSystem.KaiOS, (b) =>
-  define(OperatingSystem.ChromeOS, (b) => b
+        b.mustInclude('KAIOS')),
-    .mustInclude('CrOS')),
+    define(OperatingSystem.ChromeOS, (b) =>
-  define(OperatingSystem.BlackBerryOS, (b) => b
+        b.mustInclude('CrOS')),
-    .mustInclude('BlackBerry')),
+    define(OperatingSystem.BlackBerryOS, (b) =>
-  define(OperatingSystem.BlackBerryTabletOS, (b) => b
+        b.mustInclude('BlackBerry')),
-    .mustInclude('RIM Tablet OS')),
+    define(OperatingSystem.BlackBerryTabletOS, (b) =>
-  define(OperatingSystem.BlackBerry, (b) => b
+        b.mustInclude('RIM Tablet OS')),
-    .mustInclude('BB10')),
+    define(OperatingSystem.BlackBerry, (b) =>
-  define(OperatingSystem.Android, (b) => b
+        b.mustInclude('BB10')),
-    .mustInclude('Android').mustNotInclude('Windows Phone')),
+    define(OperatingSystem.Android, (b) =>
-  define(OperatingSystem.Android, (b) => b
+        b.mustInclude('Android').mustNotInclude('Windows Phone')),
-    .mustInclude('Adr').mustNotInclude('Windows Phone')),
+    define(OperatingSystem.Android, (b) =>
-  define(OperatingSystem.iOS, (b) => b
+        b.mustInclude('Adr').mustNotInclude('Windows Phone')),
-    .mustInclude('like Mac OS X')),
+    define(OperatingSystem.iOS, (b) =>
-  define(OperatingSystem.Linux, (b) => b
+        b.mustInclude('like Mac OS X')),
-    .mustInclude('Linux').mustNotInclude('Android').mustNotInclude('Adr')),
+    define(OperatingSystem.Linux, (b) =>
-  define(OperatingSystem.Windows, (b) => b
+        b.mustInclude('Linux').mustNotInclude('Android').mustNotInclude('Adr')),
-    .mustInclude('Windows').mustNotInclude('Windows Phone')),
+    define(OperatingSystem.Windows, (b) =>
-  define(OperatingSystem.WindowsPhone, (b) => b
+        b.mustInclude('Windows').mustNotInclude('Windows Phone')),
-    .mustInclude('Windows Phone')),
+    define(OperatingSystem.WindowsPhone, (b) =>
-  define(OperatingSystem.macOS, (b) => b
+        b.mustInclude('Windows Phone')),
-    .mustInclude('OS X').mustNotInclude('Android').mustNotInclude('like Mac OS X')),
+    define(OperatingSystem.macOS, (b) =>
+        b.mustInclude('OS X').mustNotInclude('Android').mustNotInclude('like Mac OS X')),
 ];
 
-function define(
+function define(os: OperatingSystem, applyRules: (builder: DetectorBuilder) => DetectorBuilder): IBrowserOsDetector {
-  os: OperatingSystem,
-  applyRules: (builder: DetectorBuilder) => DetectorBuilder,
-): IBrowserOsDetector {
     const builder = new DetectorBuilder(os);
     applyRules(builder);
     return builder.build();

src/application/Environment/BrowserOs/DetectorBuilder.ts

@@ -1,9 +1,8 @@
-import { OperatingSystem } from '@/domain/OperatingSystem';
 import { IBrowserOsDetector } from './IBrowserOsDetector';
+import { OperatingSystem } from '@/domain/OperatingSystem';
 
 export class DetectorBuilder {
     private readonly existingPartsInUserAgent = new Array<string>();
-
     private readonly notExistingPartsInUserAgent = new Array<string>();
 
     constructor(private readonly os: OperatingSystem) { }
@@ -27,7 +26,7 @@ export class DetectorBuilder {
 
     private detect(userAgent: string): OperatingSystem {
         if (!userAgent) {
-      throw new Error('missing userAgent');
+            throw new Error('User agent is null or undefined');
         }
         if (this.existingPartsInUserAgent.some((part) => !userAgent.includes(part))) {
             return undefined;

src/application/Environment/Environment.ts

@@ -1,9 +1,9 @@
-import { OperatingSystem } from '@/domain/OperatingSystem';
 import { BrowserOsDetector } from './BrowserOs/BrowserOsDetector';
 import { IBrowserOsDetector } from './BrowserOs/IBrowserOsDetector';
 import { IEnvironment } from './IEnvironment';
+import { OperatingSystem } from '@/domain/OperatingSystem';
 
-export interface IEnvironmentVariables {
+interface IEnvironmentVariables {
     readonly window: Window & typeof globalThis;
     readonly process: NodeJS.Process;
     readonly navigator: Navigator;
@@ -12,28 +12,21 @@ export interface IEnvironmentVariables {
 export class Environment implements IEnvironment {
     public static readonly CurrentEnvironment: IEnvironment = new Environment({
         window,
-    process: typeof process !== 'undefined' ? process /* electron only */ : undefined,
+        process,
         navigator,
     });
-
     public readonly isDesktop: boolean;
-
     public readonly os: OperatingSystem;
-
     protected constructor(
       variables: IEnvironmentVariables,
-    browserOsDetector: IBrowserOsDetector = new BrowserOsDetector(),
+      browserOsDetector: IBrowserOsDetector = new BrowserOsDetector()) {
-  ) {
         if (!variables) {
             throw new Error('variables is null or empty');
         }
         this.isDesktop = isDesktop(variables);
-    if (this.isDesktop) {
+        this.os = this.isDesktop ?
-      this.os = getDesktopOsType(getProcessPlatform(variables));
+            getDesktopOsType(getProcessPlatform(variables))
-    } else {
+          : browserOsDetector.detect(getUserAgent(variables));
-      const userAgent = getUserAgent(variables);
-      this.os = !userAgent ? undefined : browserOsDetector.detect(userAgent);
-    }
     }
 }
 
@@ -53,16 +46,14 @@ function getProcessPlatform(variables: IEnvironmentVariables): string {
 
 function getDesktopOsType(processPlatform: string): OperatingSystem | undefined {
     // https://nodejs.org/api/process.html#process_process_platform
-  switch (processPlatform) {
+    if (processPlatform === 'darwin') {
-    case 'darwin':
         return OperatingSystem.macOS;
-    case 'win32':
+    } else if (processPlatform === 'win32') {
         return OperatingSystem.Windows;
-    case 'linux':
+    } else if (processPlatform === 'linux') {
         return OperatingSystem.Linux;
-    default:
-      return undefined;
     }
+    return undefined;
 }
 
 function isDesktop(variables: IEnvironmentVariables): boolean {

src/application/Parser/ApplicationParser.ts

@@ -1,18 +1,17 @@
-import type { CollectionData } from '@/application/collections/';
 import { IApplication } from '@/domain/IApplication';
 import { IProjectInformation } from '@/domain/IProjectInformation';
 import { ICategoryCollection } from '@/domain/ICategoryCollection';
-import WindowsData from '@/application/collections/windows.yaml';
+import { parseCategoryCollection } from './CategoryCollectionParser';
-import MacOsData from '@/application/collections/macos.yaml';
+import WindowsData from 'js-yaml-loader!@/application/collections/windows.yaml';
+import MacOsData from 'js-yaml-loader!@/application/collections/macos.yaml';
+import { CollectionData } from 'js-yaml-loader!@/*';
 import { parseProjectInformation } from '@/application/Parser/ProjectInformationParser';
 import { Application } from '@/domain/Application';
-import { parseCategoryCollection } from './CategoryCollectionParser';
 
 export function parseApplication(
     parser = CategoryCollectionParser,
     processEnv: NodeJS.ProcessEnv = process.env,
-  collectionsData = PreParsedCollections,
+    collectionsData = PreParsedCollections): IApplication {
-): IApplication {
     validateCollectionsData(collectionsData);
     const information = parseProjectInformation(processEnv);
     const collections = collectionsData.map((collection) => parser(collection, information));
@@ -23,19 +22,17 @@ export function parseApplication(
 export type CategoryCollectionParserType
     = (file: CollectionData, info: IProjectInformation) => ICategoryCollection;
 
-const CategoryCollectionParser: CategoryCollectionParserType = (file, info) => {
+const CategoryCollectionParser: CategoryCollectionParserType
-  return parseCategoryCollection(file, info);
+    = (file, info) => parseCategoryCollection(file, info);
-};
 
-const PreParsedCollections: readonly CollectionData [] = [
+const PreParsedCollections: readonly CollectionData []
-  WindowsData, MacOsData,
+    = [ WindowsData, MacOsData ];
-];
 
 function validateCollectionsData(collections: readonly CollectionData[]) {
-  if (!collections || !collections.length) {
+    if (!collections.length) {
-    throw new Error('missing collections');
+        throw new Error('no collection provided');
     }
     if (collections.some((collection) => !collection)) {
-    throw new Error('missing collection provided');
+        throw new Error('undefined collection provided');
     }
 }

src/application/Parser/CategoryCollectionParser.ts

@@ -1,35 +1,38 @@
-import type { CollectionData } from '@/application/collections/';
+import { Category } from '@/domain/Category';
+import { CollectionData } from 'js-yaml-loader!@/*';
+import { parseCategory } from './CategoryParser';
 import { OperatingSystem } from '@/domain/OperatingSystem';
+import { createEnumParser } from '../Common/Enum';
 import { ICategoryCollection } from '@/domain/ICategoryCollection';
 import { CategoryCollection } from '@/domain/CategoryCollection';
 import { IProjectInformation } from '@/domain/IProjectInformation';
-import { createEnumParser } from '../Common/Enum';
-import { parseCategory } from './CategoryParser';
 import { CategoryCollectionParseContext } from './Script/CategoryCollectionParseContext';
 import { ScriptingDefinitionParser } from './ScriptingDefinition/ScriptingDefinitionParser';
 
 export function parseCategoryCollection(
     content: CollectionData,
     info: IProjectInformation,
-  osParser = createEnumParser(OperatingSystem),
+    osParser = createEnumParser(OperatingSystem)): ICategoryCollection {
-): ICategoryCollection {
     validate(content);
     const scripting = new ScriptingDefinitionParser()
         .parse(content.scripting, info);
     const context = new CategoryCollectionParseContext(content.functions, scripting);
-  const categories = content.actions.map((action) => parseCategory(action, context));
+    const categories = new Array<Category>();
+    for (const action of content.actions) {
+        const category = parseCategory(action, context);
+        categories.push(category);
+    }
     const os = osParser.parseEnum(content.os, 'os');
     const collection = new CategoryCollection(
         os,
         categories,
-    scripting,
+        scripting);
-  );
     return collection;
 }
 
 function validate(content: CollectionData): void {
     if (!content) {
-    throw new Error('missing content');
+        throw new Error('content is null or undefined');
     }
     if (!content.actions || content.actions.length <= 0) {
         throw new Error('content does not define any action');

src/application/Parser/CategoryParser.ts

@@ -1,19 +1,19 @@
-import type {
+import { CategoryData, ScriptData, CategoryOrScriptData } from 'js-yaml-loader!@/*';
-  CategoryData, ScriptData, CategoryOrScriptData, InstructionHolder,
-} from '@/application/collections/';
 import { Script } from '@/domain/Script';
 import { Category } from '@/domain/Category';
 import { parseDocUrls } from './DocumentationParser';
 import { ICategoryCollectionParseContext } from './Script/ICategoryCollectionParseContext';
 import { parseScript } from './Script/ScriptParser';
 
-let categoryIdCounter = 0;
+let categoryIdCounter: number = 0;
 
-export function parseCategory(
+interface ICategoryChildren {
-  category: CategoryData,
+    subCategories: Category[];
-  context: ICategoryCollectionParseContext,
+    subScripts: Script[];
-): Category {
+}
-  if (!context) { throw new Error('missing context'); }
+
+export function parseCategory(category: CategoryData, context: ICategoryCollectionParseContext): Category {
+    if (!context) { throw new Error('undefined context'); }
     ensureValid(category);
     const children: ICategoryChildren = {
         subCategories: new Array<Category>(),
@@ -23,17 +23,17 @@ export function parseCategory(
         parseCategoryChild(data, children, category, context);
     }
     return new Category(
-    /* id: */ categoryIdCounter++,
+        /*id*/ categoryIdCounter++,
-    /* name: */ category.category,
+        /*name*/ category.category,
-    /* docs: */ parseDocUrls(category),
+        /*docs*/ parseDocUrls(category),
-    /* categories: */ children.subCategories,
+        /*categories*/ children.subCategories,
-    /* scripts: */ children.subScripts,
+        /*scripts*/ children.subScripts,
     );
 }
 
 function ensureValid(category: CategoryData) {
     if (!category) {
-    throw Error('missing category');
+        throw Error('category is null or undefined');
     }
     if (!category.children || category.children.length === 0) {
         throw Error(`category has no children: "${category.category}"`);
@@ -43,17 +43,11 @@ function ensureValid(category: CategoryData) {
     }
 }
 
-interface ICategoryChildren {
-  subCategories: Category[];
-  subScripts: Script[];
-}
-
 function parseCategoryChild(
     data: CategoryOrScriptData,
     children: ICategoryChildren,
     parent: CategoryData,
-  context: ICategoryCollectionParseContext,
+    context: ICategoryCollectionParseContext) {
-) {
     if (isCategory(data)) {
         const subCategory = parseCategory(data as CategoryData, context);
         children.subCategories.push(subCategory);
@@ -67,20 +61,11 @@ function parseCategoryChild(
     }
 }
 
-function isScript(data: CategoryOrScriptData): data is ScriptData {
+function isScript(data: any): boolean {
-  const holder = (data as InstructionHolder);
+    return (data.code && data.code.length > 0)
-  return hasCode(holder) || hasCall(holder);
+        || data.call;
 }
 
-function isCategory(data: CategoryOrScriptData): data is CategoryData {
+function isCategory(data: any): boolean {
-  const { category } = data as CategoryData;
+    return data.category && data.category.length > 0;
-  return category && category.length > 0;
-}
-
-function hasCode(holder: InstructionHolder): boolean {
-  return holder.code && holder.code.length > 0;
-}
-
-function hasCall(holder: InstructionHolder) {
-  return holder.call !== undefined;
 }

src/application/Parser/DocumentationParser.ts

@@ -1,10 +1,10 @@
-import type { DocumentableData, DocumentationUrlsData } from '@/application/collections/';
+import { DocumentableData, DocumentationUrlsData } from 'js-yaml-loader!@/*';
 
 export function parseDocUrls(documentable: DocumentableData): ReadonlyArray<string> {
     if (!documentable) {
-    throw new Error('missing documentable');
+        throw new Error('documentable is null or undefined');
     }
-  const { docs } = documentable;
+    const docs = documentable.docs;
     if (!docs || !docs.length) {
         return [];
     }
@@ -13,10 +13,7 @@ export function parseDocUrls(documentable: DocumentableData): ReadonlyArray<stri
     return result.getAll();
 }
 
-function addDocs(
+function addDocs(docs: DocumentationUrlsData, urls: DocumentationUrlContainer): DocumentationUrlContainer {
-  docs: DocumentationUrlsData,
-  urls: DocumentationUrlContainer,
-): DocumentationUrlContainer {
     if (docs instanceof Array) {
         urls.addUrls(docs);
     } else if (typeof docs === 'string') {
@@ -35,7 +32,7 @@ class DocumentationUrlContainer {
         this.urls.push(url);
     }
 
-  public addUrls(urls: readonly string[]) {
+    public addUrls(urls: readonly any[]) {
         for (const url of urls) {
             if (typeof url !== 'string') {
                 throw new Error('Docs field (documentation url) must be an array of strings');
@@ -56,8 +53,8 @@ function validateUrl(docUrl: string): void {
     if (docUrl.includes('\n')) {
         throw new Error('Documentation url cannot be multi-lined.');
     }
-  const validUrlRegex = /(http(s)?:\/\/.)?(www\.)?[-a-zA-Z0-9@:%._+~#=]{2,256}\.[a-z]{2,6}\b([-a-zA-Z0-9@:%_+.~#?&//=]*)/g;
+    const res = docUrl.match(
-  const res = docUrl.match(validUrlRegex);
+        /(http(s)?:\/\/.)?(www\.)?[-a-zA-Z0-9@:%._\+~#=]{2,256}\.[a-z]{2,6}\b([-a-zA-Z0-9@:%_\+.~#?&//=]*)/g);
     if (res == null) {
         throw new Error(`Invalid documentation url: ${docUrl}`);
     }

src/application/Parser/ProjectInformationParser.ts

@@ -1,14 +1,11 @@
 import { IProjectInformation } from '@/domain/IProjectInformation';
 import { ProjectInformation } from '@/domain/ProjectInformation';
-import { Version } from '@/domain/Version';
 
 export function parseProjectInformation(
-  environment: NodeJS.ProcessEnv,
+    environment: NodeJS.ProcessEnv): IProjectInformation {
-): IProjectInformation {
-  const version = new Version(environment.VUE_APP_VERSION);
     return new ProjectInformation(
         environment.VUE_APP_NAME,
-    version,
+        environment.VUE_APP_VERSION,
         environment.VUE_APP_REPOSITORY_URL,
         environment.VUE_APP_HOMEPAGE_URL,
     );

src/application/Parser/Script/CategoryCollectionParseContext.ts

@@ -1,6 +1,6 @@
-import type { FunctionData } from '@/application/collections/';
 import { IScriptingDefinition } from '@/domain/IScriptingDefinition';
 import { ILanguageSyntax } from '@/domain/ScriptCode';
+import { FunctionData } from 'js-yaml-loader!@/*';
 import { IScriptCompiler } from './Compiler/IScriptCompiler';
 import { ScriptCompiler } from './Compiler/ScriptCompiler';
 import { ICategoryCollectionParseContext } from './ICategoryCollectionParseContext';
@@ -9,15 +9,13 @@ import { ISyntaxFactory } from './Syntax/ISyntaxFactory';
 
 export class CategoryCollectionParseContext implements ICategoryCollectionParseContext {
     public readonly compiler: IScriptCompiler;
-
     public readonly syntax: ILanguageSyntax;
 
     constructor(
         functionsData: ReadonlyArray<FunctionData> | undefined,
         scripting: IScriptingDefinition,
-    syntaxFactory: ISyntaxFactory = new SyntaxFactory(),
+        syntaxFactory: ISyntaxFactory = new SyntaxFactory()) {
-  ) {
+        if (!scripting) { throw new Error('undefined scripting'); }
-    if (!scripting) { throw new Error('missing scripting'); }
         this.syntax = syntaxFactory.create(scripting.language);
         this.compiler = new ScriptCompiler(functionsData, this.syntax);
     }

src/application/Parser/Script/Compiler/Expressions/Expression/Expression.ts

@@ -1,37 +1,33 @@
-import { FunctionParameterCollection } from '@/application/Parser/Script/Compiler/Function/Parameter/FunctionParameterCollection';
+import { ExpressionPosition } from './ExpressionPosition';
+import { IExpression } from './IExpression';
 import { IReadOnlyFunctionCallArgumentCollection } from '../../Function/Call/Argument/IFunctionCallArgumentCollection';
 import { IReadOnlyFunctionParameterCollection } from '../../Function/Parameter/IFunctionParameterCollection';
+import { FunctionParameterCollection } from '@/application/Parser/Script/Compiler/Function/Parameter/FunctionParameterCollection';
 import { FunctionCallArgumentCollection } from '../../Function/Call/Argument/FunctionCallArgumentCollection';
-import { IExpression } from './IExpression';
+import { IExpressionEvaluationContext } from './ExpressionEvaluationContext';
-import { ExpressionPosition } from './ExpressionPosition';
+import { ExpressionEvaluationContext } from '@/application/Parser/Script/Compiler/Expressions/Expression/ExpressionEvaluationContext';
-import { ExpressionEvaluationContext, IExpressionEvaluationContext } from './ExpressionEvaluationContext';
 
 export type ExpressionEvaluator = (context: IExpressionEvaluationContext) => string;
 export class Expression implements IExpression {
-  public readonly parameters: IReadOnlyFunctionParameterCollection;
-
     constructor(
         public readonly position: ExpressionPosition,
         public readonly evaluator: ExpressionEvaluator,
-    parameters?: IReadOnlyFunctionParameterCollection,
+        public readonly parameters: IReadOnlyFunctionParameterCollection = new FunctionParameterCollection()) {
-  ) {
         if (!position) {
-      throw new Error('missing position');
+            throw new Error('undefined position');
         }
         if (!evaluator) {
-      throw new Error('missing evaluator');
+            throw new Error('undefined evaluator');
         }
-    this.parameters = parameters ?? new FunctionParameterCollection();
     }
-
     public evaluate(context: IExpressionEvaluationContext): string {
         if (!context) {
-      throw new Error('missing context');
+            throw new Error('undefined context');
         }
         validateThatAllRequiredParametersAreSatisfied(this.parameters, context.args);
         const args = filterUnusedArguments(this.parameters, context.args);
-    const filteredContext = new ExpressionEvaluationContext(args, context.pipelineCompiler);
+        context = new ExpressionEvaluationContext(args, context.pipelineCompiler);
-    return this.evaluator(filteredContext);
+        return this.evaluator(context);
     }
 }
 
@@ -47,19 +43,20 @@ function validateThatAllRequiredParametersAreSatisfied(
         .filter((parameterName) => !args.hasArgument(parameterName));
     if (missingParameterNames.length) {
         throw new Error(
-      `argument values are provided for required parameters: "${missingParameterNames.join('", "')}"`,
+            `argument values are provided for required parameters: "${missingParameterNames.join('", "')}"`);
-    );
     }
 }
 
 function filterUnusedArguments(
     parameters: IReadOnlyFunctionParameterCollection,
-  allFunctionArgs: IReadOnlyFunctionCallArgumentCollection,
+    allFunctionArgs: IReadOnlyFunctionCallArgumentCollection): IReadOnlyFunctionCallArgumentCollection {
-): IReadOnlyFunctionCallArgumentCollection {
     const specificCallArgs = new FunctionCallArgumentCollection();
-  parameters.all
+    for (const parameter of parameters.all) {
-    .filter((parameter) => allFunctionArgs.hasArgument(parameter.name))
+        if (parameter.isOptional && !allFunctionArgs.hasArgument(parameter.name)) {
-    .map((parameter) => allFunctionArgs.getArgument(parameter.name))
+            continue; // Optional parameter is not necessarily provided
-    .forEach((argument) => specificCallArgs.addArgument(argument));
+        }
+        const arg = allFunctionArgs.getArgument(parameter.name);
+        specificCallArgs.addArgument(arg);
+    }
     return specificCallArgs;
 }

src/application/Parser/Script/Compiler/Expressions/Expression/ExpressionEvaluationContext.ts

@@ -10,10 +10,9 @@ export interface IExpressionEvaluationContext {
 export class ExpressionEvaluationContext implements IExpressionEvaluationContext {
     constructor(
         public readonly args: IReadOnlyFunctionCallArgumentCollection,
-    public readonly pipelineCompiler: IPipelineCompiler = new PipelineCompiler(),
+        public readonly pipelineCompiler: IPipelineCompiler = new PipelineCompiler()) {
-  ) {
         if (!args) {
-      throw new Error('missing args, send empty collection instead.');
+            throw new Error('undefined args, send empty collection instead');
         }
     }
 }

src/application/Parser/Script/Compiler/Expressions/Expression/ExpressionPosition.ts

@@ -1,8 +1,7 @@
 export class ExpressionPosition {
     constructor(
         public readonly start: number,
-    public readonly end: number,
+        public readonly end: number) {
-  ) {
         if (start === end) {
             throw new Error(`no length (start = end = ${start})`);
         }

src/application/Parser/Script/Compiler/Expressions/Expression/IExpression.ts

@@ -1,5 +1,5 @@
-import { IReadOnlyFunctionParameterCollection } from '../../Function/Parameter/IFunctionParameterCollection';
 import { ExpressionPosition } from './ExpressionPosition';
+import { IReadOnlyFunctionParameterCollection } from '../../Function/Parameter/IFunctionParameterCollection';
 import { IExpressionEvaluationContext } from './ExpressionEvaluationContext';
 
 export interface IExpression {

src/application/Parser/Script/Compiler/Expressions/ExpressionsCompiler.ts

@@ -1,24 +1,19 @@
-import { IExpressionEvaluationContext, ExpressionEvaluationContext } from '@/application/Parser/Script/Compiler/Expressions/Expression/ExpressionEvaluationContext';
-import { IReadOnlyFunctionCallArgumentCollection } from '../Function/Call/Argument/IFunctionCallArgumentCollection';
 import { IExpressionsCompiler } from './IExpressionsCompiler';
 import { IExpression } from './Expression/IExpression';
 import { IExpressionParser } from './Parser/IExpressionParser';
 import { CompositeExpressionParser } from './Parser/CompositeExpressionParser';
+import { IReadOnlyFunctionCallArgumentCollection } from '../Function/Call/Argument/IFunctionCallArgumentCollection';
+import { ExpressionEvaluationContext } from './Expression/ExpressionEvaluationContext';
+import { IExpressionEvaluationContext } from '@/application/Parser/Script/Compiler/Expressions/Expression/ExpressionEvaluationContext';
 
 export class ExpressionsCompiler implements IExpressionsCompiler {
     public constructor(
-    private readonly extractor: IExpressionParser = new CompositeExpressionParser(),
+        private readonly extractor: IExpressionParser = new CompositeExpressionParser()) { }
-  ) { }
-
     public compileExpressions(
-    code: string | undefined,
+        code: string,
-    args: IReadOnlyFunctionCallArgumentCollection,
+        args: IReadOnlyFunctionCallArgumentCollection): string {
-  ): string {
         if (!args) {
-      throw new Error('missing args, send empty collection instead.');
+            throw new Error('undefined args, send empty collection instead');
-    }
-    if (!code) {
-      return code;
         }
         const expressions = this.extractor.findExpressions(code);
         ensureParamsUsedInCodeHasArgsProvided(expressions, args);
@@ -31,8 +26,7 @@ export class ExpressionsCompiler implements IExpressionsCompiler {
 function compileExpressions(
     expressions: readonly IExpression[],
     code: string,
-  context: IExpressionEvaluationContext,
+    context: IExpressionEvaluationContext) {
-) {
     let compiledCode = '';
     const sortedExpressions = expressions
         .slice() // copy the array to not mutate the parameter
@@ -54,21 +48,20 @@ function compileExpressions(
 }
 
 function extractRequiredParameterNames(
-  expressions: readonly IExpression[],
+    expressions: readonly IExpression[]): string[] {
-): string[] {
+    const usedParameterNames = expressions
-  return expressions
         .map((e) => e.parameters.all
             .filter((p) => !p.isOptional)
             .map((p) => p.name))
-    .filter(Boolean) // Remove empty or undefined
+        .filter((p) => p)
-    .flat()
+        .flat();
-    .filter((name, index, array) => array.indexOf(name) === index); // Remove duplicates
+    const uniqueParameterNames = Array.from(new Set(usedParameterNames));
+    return uniqueParameterNames;
 }
 
 function ensureParamsUsedInCodeHasArgsProvided(
     expressions: readonly IExpression[],
-  providedArgs: IReadOnlyFunctionCallArgumentCollection,
+    providedArgs: IReadOnlyFunctionCallArgumentCollection): void {
-): void {
     const usedParameterNames = extractRequiredParameterNames(expressions);
     if (!usedParameterNames?.length) {
         return;

src/application/Parser/Script/Compiler/Expressions/IExpressionsCompiler.ts

@@ -2,6 +2,6 @@ import { IReadOnlyFunctionCallArgumentCollection } from '../Function/Call/Argume
 
 export interface IExpressionsCompiler {
     compileExpressions(
-    code: string | undefined,
+        code: string,
         args: IReadOnlyFunctionCallArgumentCollection): string;
 }

src/application/Parser/Script/Compiler/Expressions/Parser/CompositeExpressionParser.ts

@@ -1,7 +1,7 @@
 import { IExpression } from '../Expression/IExpression';
+import { IExpressionParser } from './IExpressionParser';
 import { ParameterSubstitutionParser } from '../SyntaxParsers/ParameterSubstitutionParser';
 import { WithParser } from '../SyntaxParsers/WithParser';
-import { IExpressionParser } from './IExpressionParser';
 
 const Parsers = [
     new ParameterSubstitutionParser(),
@@ -10,17 +10,18 @@ const Parsers = [
 
 export class CompositeExpressionParser implements IExpressionParser {
     public constructor(private readonly leafs: readonly IExpressionParser[] = Parsers) {
-    if (!leafs) {
-      throw new Error('missing leafs');
-    }
         if (leafs.some((leaf) => !leaf)) {
-      throw new Error('missing leaf');
+            throw new Error('undefined leaf');
         }
     }
-
     public findExpressions(code: string): IExpression[] {
-    return this.leafs.flatMap(
+        const expressions = new Array<IExpression>();
-      (parser) => parser.findExpressions(code) || [],
+        for (const parser of this.leafs) {
-    );
+            const newExpressions = parser.findExpressions(code);
+            if (newExpressions && newExpressions.length) {
+                expressions.push(...newExpressions);
+            }
+        }
+        return expressions;
     }
 }

src/application/Parser/Script/Compiler/Expressions/Parser/Regex/ExpressionRegexBuilder.ts

@@ -52,7 +52,6 @@ export class ExpressionRegexBuilder {
         return this
             .addRawRegex('\\s*');
     }
-
     private addRawRegex(regex: string) {
         this.parts.push(regex);
         return this;

src/application/Parser/Script/Compiler/Expressions/Parser/Regex/RegexParser.ts

@@ -15,45 +15,34 @@ export abstract class RegexParser implements IExpressionParser {
     protected abstract buildExpression(match: RegExpMatchArray): IPrimitiveExpression;
 
     private* findRegexExpressions(code: string): Iterable<IExpression> {
-    if (!code) {
+        const matches = Array.from(code.matchAll(this.regex));
-      throw new Error('missing code');
-    }
-    const matches = code.matchAll(this.regex);
         for (const match of matches) {
+            const startPos = match.index;
+            const endPos = startPos + match[0].length;
+            let position: ExpressionPosition;
+            try {
+                position = new ExpressionPosition(startPos, endPos);
+            } catch (error) {
+                throw new Error(`[${this.constructor.name}] invalid script position: ${error.message}\nRegex ${this.regex}\nCode: ${code}`);
+            }
             const primitiveExpression = this.buildExpression(match);
-      const position = this.doOrRethrow(() => createPosition(match), 'invalid script position', code);
+            const parameters = getParameters(primitiveExpression);
-      const parameters = createParameters(primitiveExpression);
             const expression = new Expression(position, primitiveExpression.evaluator, parameters);
             yield expression;
         }
     }
-
-  private doOrRethrow<T>(action: () => T, errorText: string, code: string): T {
-    try {
-      return action();
-    } catch (error) {
-      throw new Error(`[${this.constructor.name}] ${errorText}: ${error.message}\nRegex: ${this.regex}\nCode: ${code}`);
-    }
-  }
-}
-
-function createPosition(match: RegExpMatchArray): ExpressionPosition {
-  const startPos = match.index;
-  const endPos = startPos + match[0].length;
-  return new ExpressionPosition(startPos, endPos);
-}
-
-function createParameters(
-  expression: IPrimitiveExpression,
-): FunctionParameterCollection {
-  return (expression.parameters || [])
-    .reduce((parameters, parameter) => {
-      parameters.addParameter(parameter);
-      return parameters;
-    }, new FunctionParameterCollection());
 }
 
 export interface IPrimitiveExpression {
     evaluator: ExpressionEvaluator;
     parameters?: readonly IFunctionParameter[];
 }
+
+function getParameters(
+    expression: IPrimitiveExpression): FunctionParameterCollection {
+    const parameters  = new FunctionParameterCollection();
+    for (const parameter of expression.parameters || []) {
+        parameters.addParameter(parameter);
+    }
+    return parameters;
+}

src/application/Parser/Script/Compiler/Expressions/Pipes/PipeDefinitions/EscapeDoubleQuotes.ts

@@ -2,13 +2,8 @@ import { IPipe } from '../IPipe';
 
 export class EscapeDoubleQuotes implements IPipe {
     public readonly name: string = 'escapeDoubleQuotes';
-
     public apply(raw: string): string {
-    if (!raw) {
+        return raw?.replaceAll('"', '"^""');
-      return raw;
-    }
-    return raw.replaceAll('"', '"^""');
-    /* eslint-disable max-len */
         /*
             "^"" is the most robust and stable choice.
             Other options:
@@ -16,18 +11,17 @@ export class EscapeDoubleQuotes implements IPipe {
                     Breaks, because it is fundamentally unsupported
                 """"
                     Does not work with consecutive double quotes.
-          E.g. `PowerShell -Command "$name='aq'; Write-Host """"Disabled `""""$name`"""""""";"`
+                    E.g. PowerShell -Command "$name='aq'; Write-Host """"Disabled `""""$name`"""""""";"
-          Works when using: `PowerShell -Command "$name='aq'; Write-Host "^""Disabled `"^""$name`"^"" "^"";"`
+                    Works when using: PowerShell -Command "$name='aq'; Write-Host "^""Disabled `"^""$name`"^"" "^"";"
                 \"
                     May break as they are interpreted by cmd.exe as metacharacters breaking the command
-          E.g. `PowerShell -Command "Write-Host 'Hello \"w&orld\"'"` does not work due to unescaped "&"
+                    E.g. PowerShell -Command "Write-Host 'Hello \"w&orld\"'" does not work due to unescaped "&"
-          Works when using: `PowerShell -Command "Write-Host 'Hello "^""w&orld"^""'"`
+                    Works when using: PowerShell -Command "Write-Host 'Hello "^""w&orld"^""'"
                 \""
                     Normalizes interior whitespace
-          E.g. `PowerShell -Command "\""a&  c\"".length"`, outputs 4 and discards one of two whitespaces
+                    E.g. PowerShell -Command "\""a&  c\"".length", outputs 4 and discards one of two whitespaces
-          Works when using "^"": `PowerShell -Command ""^""a&  c"^"".length"`
+                    Works when using "^"": PowerShell -Command ""^""a&  c"^"".length"
             A good explanation: https://stackoverflow.com/a/31413730
         */
-    /* eslint-enable max-len */
     }
 }

src/application/Parser/Script/Compiler/Expressions/Pipes/PipeDefinitions/InlinePowerShell.ts

@@ -2,19 +2,18 @@ import { IPipe } from '../IPipe';
 
 export class InlinePowerShell implements IPipe {
     public readonly name: string = 'inlinePowerShell';
-
     public apply(code: string): string {
         if (!code || !hasLines(code)) {
             return code;
         }
-    const processor = new Array<(data: string) => string>(...[ // for broken ESlint "indent"
+        code = inlineComments(code);
-      inlineComments,
+        code = mergeLinesWithBacktick(code);
-      mergeLinesWithBacktick,
+        code = mergeHereStrings(code);
-      mergeHereStrings,
+        const lines = getLines(code)
-      mergeNewLines,
+            .map((line) => line.trim())
-    ]).reduce((a, b) => (data) => b(a(data)));
+            .filter((line) => line.length > 0);
-    const newCode = processor(code);
+        return lines
-    return newCode;
+            .join('; ');
     }
 }
 
@@ -89,7 +88,7 @@ function inlineComments(code: string): string {
     */
 }
 
-function getLines(code: string): string[] {
+function getLines(code: string): string [] {
     return (code?.split(/\r\n|\r|\n/) || []);
 }
 
@@ -113,18 +112,15 @@ interface IInlinedHereString {
     readonly escapedQuotes: string;
     readonly separator: string;
 }
+// We handle @' and @" differently so single quotes are interpreted literally and doubles are expandable
 function getHereStringHandler(quotes: string): IInlinedHereString {
-  /*
-    We handle @' and @" differently.
-    Single quotes are interpreted literally and doubles are expandable.
-  */
     const expandableNewLine = '`r`n';
     switch (quotes) {
         case '\'':
             return {
                 quotesAround: '\'',
                 escapedQuotes: '\'\'',
-        separator: `'+"${expandableNewLine}"+'`,
+                separator: `\'+"${expandableNewLine}"+\'`,
             };
         case '"':
             return {
@@ -157,10 +153,3 @@ function mergeLinesWithBacktick(code: string) {
     */
     return code.replaceAll(/ +`\s*(?:\r\n|\r|\n)\s*/g, ' ');
 }
-
-function mergeNewLines(code: string) {
-  return getLines(code)
-    .map((line) => line.trim())
-    .filter((line) => line.length > 0)
-    .join('; ');
-}

src/application/Parser/Script/Compiler/Expressions/Pipes/PipeFactory.ts

@@ -13,19 +13,14 @@ export interface IPipeFactory {
 
 export class PipeFactory implements IPipeFactory {
     private readonly pipes = new Map<string, IPipe>();
-
     constructor(pipes: readonly IPipe[] = RegisteredPipes) {
-    if (!pipes) {
-      throw new Error('missing pipes');
-    }
         if (pipes.some((pipe) => !pipe)) {
-      throw new Error('missing pipe in list');
+            throw new Error('undefined pipe in list');
         }
         for (const pipe of pipes) {
             this.registerPipe(pipe);
         }
     }
-
     public get(pipeName: string): IPipe {
         validatePipeName(pipeName);
         if (!this.pipes.has(pipeName)) {
@@ -33,7 +28,6 @@ export class PipeFactory implements IPipeFactory {
         }
         return this.pipes.get(pipeName);
     }
-
     private registerPipe(pipe: IPipe): void {
         validatePipeName(pipe.name);
         if (this.pipes.has(pipe.name)) {

src/application/Parser/Script/Compiler/Expressions/Pipes/PipelineCompiler.ts

@@ -3,14 +3,14 @@ import { IPipelineCompiler } from './IPipelineCompiler';
 
 export class PipelineCompiler implements IPipelineCompiler {
     constructor(private readonly factory: IPipeFactory = new PipeFactory()) { }
-
     public compile(value: string, pipeline: string): string {
         ensureValidArguments(value, pipeline);
         const pipeNames = extractPipeNames(pipeline);
         const pipes = pipeNames.map((pipeName) => this.factory.get(pipeName));
-    return pipes.reduce((previousValue, pipe) => {
+        for (const pipe of pipes) {
-      return pipe.apply(previousValue);
+            value = pipe.apply(value);
-    }, value);
+        }
+        return value;
     }
 }
 
@@ -23,8 +23,8 @@ function extractPipeNames(pipeline: string): string[] {
 }
 
 function ensureValidArguments(value: string, pipeline: string) {
-  if (!value) { throw new Error('missing value'); }
+    if (!value) { throw new Error('undefined value'); }
-  if (!pipeline) { throw new Error('missing pipeline'); }
+    if (!pipeline) { throw new Error('undefined pipeline'); }
     if (!pipeline.trimStart().startsWith('|')) {
         throw new Error('pipeline does not start with pipe');
     }

src/application/Parser/Script/Compiler/Expressions/SyntaxParsers/ParameterSubstitutionParser.ts

@@ -1,5 +1,5 @@
-import { FunctionParameter } from '@/application/Parser/Script/Compiler/Function/Parameter/FunctionParameter';
 import { RegexParser, IPrimitiveExpression } from '../Parser/Regex/RegexParser';
+import { FunctionParameter } from '@/application/Parser/Script/Compiler/Function/Parameter/FunctionParameter';
 import { ExpressionRegexBuilder } from '../Parser/Regex/ExpressionRegexBuilder';
 
 export class ParameterSubstitutionParser extends RegexParser {
@@ -15,9 +15,9 @@ export class ParameterSubstitutionParser extends RegexParser {
         const parameterName = match[1];
         const pipeline = match[2];
         return {
-      parameters: [new FunctionParameter(parameterName, false)],
+            parameters: [ new FunctionParameter(parameterName, false) ],
             evaluator: (context) => {
-        const { argumentValue } = context.args.getArgument(parameterName);
+                const argumentValue = context.args.getArgument(parameterName).argumentValue;
                 if (!pipeline) {
                     return argumentValue;
                 }

src/application/Parser/Script/Compiler/Expressions/SyntaxParsers/WithParser.ts

@@ -1,5 +1,5 @@
-import { FunctionParameter } from '@/application/Parser/Script/Compiler/Function/Parameter/FunctionParameter';
 import { RegexParser, IPrimitiveExpression } from '../Parser/Regex/RegexParser';
+import { FunctionParameter } from '@/application/Parser/Script/Compiler/Function/Parameter/FunctionParameter';
 import { ExpressionRegexBuilder } from '../Parser/Regex/ExpressionRegexBuilder';
 
 export class WithParser extends RegexParser {
@@ -23,10 +23,10 @@ export class WithParser extends RegexParser {
         const parameterName = match[1];
         const scopeText = match[2];
         return {
-      parameters: [new FunctionParameter(parameterName, true)],
+            parameters: [ new FunctionParameter(parameterName, true) ],
             evaluator: (context) => {
-        const argumentValue = context.args.hasArgument(parameterName)
+                const argumentValue = context.args.hasArgument(parameterName) ?
-          ? context.args.getArgument(parameterName).argumentValue
+                    context.args.getArgument(parameterName).argumentValue
                     : undefined;
                 if (!argumentValue) {
                     return '';
@@ -43,7 +43,7 @@ export class WithParser extends RegexParser {
 }
 
 const ScopeSubstitutionRegEx = new ExpressionRegexBuilder()
-// {{ . | pipeName }}
+    // {{ . | pipeName }}
     .expectExpressionStart()
     .expectCharacters('.')
     .matchPipeline()    // First match: pipeline
@@ -51,9 +51,8 @@ const ScopeSubstitutionRegEx = new ExpressionRegexBuilder()
     .buildRegExp();
 
 function replaceEachScopeSubstitution(scopeText: string, replacer: (pipeline: string) => string) {
-  // Not using /{{\s*.\s*(?:(\|\s*[^{}]*?)\s*)?}}/g for not matching brackets,
+    // Not using /{{\s*.\s*(?:(\|\s*[^{}]*?)\s*)?}}/g for not matching brackets, but let pipeline compiler fail on those
-  // but instead letting the pipeline compiler to fail on those.
+    return scopeText.replaceAll(ScopeSubstitutionRegEx, (_$, match1 ) => {
-  return scopeText.replaceAll(ScopeSubstitutionRegEx, (_$, match1) => {
         return replacer(match1);
     });
 }

src/application/Parser/Script/Compiler/Function/Call/Argument/FunctionCallArgument.ts

@@ -1,14 +1,13 @@
-import { ensureValidParameterName } from '../../Shared/ParameterNameValidator';
 import { IFunctionCallArgument } from './IFunctionCallArgument';
+import { ensureValidParameterName } from '../../Shared/ParameterNameValidator';
 
 export class FunctionCallArgument implements IFunctionCallArgument {
     constructor(
         public readonly parameterName: string,
-    public readonly argumentValue: string,
+        public readonly argumentValue: string) {
-  ) {
         ensureValidParameterName(parameterName);
         if (!argumentValue) {
-      throw new Error(`missing argument value for "${parameterName}"`);
+            throw new Error(`undefined argument value for "${parameterName}"`);
         }
     }
 }

src/application/Parser/Script/Compiler/Function/Call/Argument/FunctionCallArgumentCollection.ts

@@ -3,31 +3,27 @@ import { IFunctionCallArgumentCollection } from './IFunctionCallArgumentCollecti
 
 export class FunctionCallArgumentCollection implements IFunctionCallArgumentCollection {
     private readonly arguments = new Map<string, IFunctionCallArgument>();
-
     public addArgument(argument: IFunctionCallArgument): void {
         if (!argument) {
-      throw new Error('missing argument');
+            throw new Error('undefined argument');
         }
         if (this.hasArgument(argument.parameterName)) {
             throw new Error(`argument value for parameter ${argument.parameterName} is already provided`);
         }
         this.arguments.set(argument.parameterName, argument);
     }
-
     public getAllParameterNames(): string[] {
         return Array.from(this.arguments.keys());
     }
-
     public hasArgument(parameterName: string): boolean {
         if (!parameterName) {
-      throw new Error('missing parameter name');
+            throw new Error('undefined parameter name');
         }
         return this.arguments.has(parameterName);
     }
-
     public getArgument(parameterName: string): IFunctionCallArgument {
         if (!parameterName) {
-      throw new Error('missing parameter name');
+            throw new Error('undefined parameter name');
         }
         const arg = this.arguments.get(parameterName);
         if (!arg) {

src/application/Parser/Script/Compiler/Function/Call/Compiler/FunctionCallCompiler.ts

@@ -1,30 +1,28 @@
 import { IReadOnlyFunctionCallArgumentCollection } from '@/application/Parser/Script/Compiler/Function/Call/Argument/IFunctionCallArgumentCollection';
-import { IFunctionCall } from '@/application/Parser/Script/Compiler/Function/Call/IFunctionCall';
+import { ICompiledCode } from './ICompiledCode';
-import { FunctionCallArgument } from '@/application/Parser/Script/Compiler/Function/Call/Argument/FunctionCallArgument';
 import { ISharedFunctionCollection } from '../../ISharedFunctionCollection';
+import { IFunctionCallCompiler } from './IFunctionCallCompiler';
 import { IExpressionsCompiler } from '../../../Expressions/IExpressionsCompiler';
 import { ExpressionsCompiler } from '../../../Expressions/ExpressionsCompiler';
 import { ISharedFunction, IFunctionCode } from '../../ISharedFunction';
+import { IFunctionCall } from '@/application/Parser/Script/Compiler/Function/Call/IFunctionCall';
 import { FunctionCall } from '../FunctionCall';
 import { FunctionCallArgumentCollection } from '../Argument/FunctionCallArgumentCollection';
-import { IFunctionCallCompiler } from './IFunctionCallCompiler';
+import { FunctionCallArgument } from '@/application/Parser/Script/Compiler/Function/Call/Argument/FunctionCallArgument';
-import { ICompiledCode } from './ICompiledCode';
 
 export class FunctionCallCompiler implements IFunctionCallCompiler {
     public static readonly instance: IFunctionCallCompiler = new FunctionCallCompiler();
 
     protected constructor(
-    private readonly expressionsCompiler: IExpressionsCompiler = new ExpressionsCompiler(),
+        private readonly expressionsCompiler: IExpressionsCompiler = new ExpressionsCompiler()) {
-  ) {
     }
 
     public compileCall(
         calls: IFunctionCall[],
-    functions: ISharedFunctionCollection,
+        functions: ISharedFunctionCollection): ICompiledCode {
-  ): ICompiledCode {
+        if (!functions) { throw new Error('undefined functions'); }
-    if (!functions) { throw new Error('missing functions'); }
+        if (!calls) { throw new Error('undefined calls'); }
-    if (!calls) { throw new Error('missing calls'); }
+        if (calls.some((f) => !f)) { throw new Error('undefined function call'); }
-    if (calls.some((f) => !f)) { throw new Error('missing function call'); }
         const context: ICompilationContext = {
             allFunctions: functions,
             callSequence: calls,
@@ -47,25 +45,24 @@ interface ICompiledFunctionCall {
 }
 
 function compileCallSequence(context: ICompilationContext): ICompiledFunctionCall {
-  const compiledFunctions = context.callSequence
+    const compiledFunctions = new Array<ICompiledFunctionCall>();
-    .flatMap((call) => compileSingleCall(call, context));
+    for (const call of context.callSequence) {
+        const compiledCode = compileSingleCall(call, context);
+        compiledFunctions.push(...compiledCode);
+    }
     return {
         code: merge(compiledFunctions.map((f) => f.code)),
         revertCode: merge(compiledFunctions.map((f) => f.revertCode)),
     };
 }
 
-function compileSingleCall(
+function compileSingleCall(call: IFunctionCall, context: ICompilationContext): ICompiledFunctionCall[] {
-  call: IFunctionCall,
-  context: ICompilationContext,
-): ICompiledFunctionCall[] {
     const func = context.allFunctions.getFunctionByName(call.functionName);
     ensureThatCallArgumentsExistInParameterDefinition(func, call.args);
     if (func.body.code) { // Function with inline code
         const compiledCode = compileCode(func.body.code, call.args, context.expressionsCompiler);
-    return [compiledCode];
+        return [ compiledCode ];
-  }
+    } else { // Function with inner calls
-  // Function with inner calls
         return func.body.calls
             .map((innerCall) => {
                 const compiledArgs = compileArgs(innerCall.args, call.args, context.expressionsCompiler);
@@ -73,13 +70,13 @@ function compileSingleCall(
                 return compileSingleCall(compiledCall, context);
             })
             .flat();
+    }
 }
 
 function compileCode(
     code: IFunctionCode,
     args: IReadOnlyFunctionCallArgumentCollection,
-  compiler: IExpressionsCompiler,
+    compiler: IExpressionsCompiler): ICompiledFunctionCall {
-): ICompiledFunctionCall {
     return {
         code: compiler.compileExpressions(code.do, args),
         revertCode: compiler.compileExpressions(code.revert, args),
@@ -90,18 +87,15 @@ function compileArgs(
     argsToCompile: IReadOnlyFunctionCallArgumentCollection,
     args: IReadOnlyFunctionCallArgumentCollection,
     compiler: IExpressionsCompiler,
-): IReadOnlyFunctionCallArgumentCollection {
+    ): IReadOnlyFunctionCallArgumentCollection {
-  return argsToCompile
+    const compiledArgs = new FunctionCallArgumentCollection();
-    .getAllParameterNames()
+    for (const parameterName of argsToCompile.getAllParameterNames()) {
-    .map((parameterName) => {
+        const argumentValue = argsToCompile.getArgument(parameterName).argumentValue;
-      const { argumentValue } = argsToCompile.getArgument(parameterName);
         const compiledValue = compiler.compileExpressions(argumentValue, args);
-      return new FunctionCallArgument(parameterName, compiledValue);
+        const newArgument = new FunctionCallArgument(parameterName, compiledValue);
-    })
+        compiledArgs.addArgument(newArgument);
-    .reduce((compiledArgs, arg) => {
+    }
-      compiledArgs.addArgument(arg);
     return compiledArgs;
-    }, new FunctionCallArgumentCollection());
 }
 
 function merge(codeParts: readonly string[]): string {
@@ -112,8 +106,7 @@ function merge(codeParts: readonly string[]): string {
 
 function ensureThatCallArgumentsExistInParameterDefinition(
     func: ISharedFunction,
-  args: IReadOnlyFunctionCallArgumentCollection,
+    args: IReadOnlyFunctionCallArgumentCollection): void {
-): void {
     const callArgumentNames = args.getAllParameterNames();
     const functionParameterNames = func.parameters.all.map((param) => param.name) || [];
     const unexpectedParameters = findUnexpectedParameters(callArgumentNames, functionParameterNames);
@@ -122,8 +115,7 @@ function ensureThatCallArgumentsExistInParameterDefinition(
 
 function findUnexpectedParameters(
     callArgumentNames: string[],
-  functionParameterNames: string[],
+    functionParameterNames: string[]): string[] {
-): string[] {
     if (!callArgumentNames.length && !functionParameterNames.length) {
         return [];
     }
@@ -134,16 +126,14 @@ function findUnexpectedParameters(
 function throwIfNotEmpty(
     functionName: string,
     unexpectedParameters: string[],
-  expectedParameters: string[],
+    expectedParameters: string[]) {
-) {
     if (!unexpectedParameters.length) {
         return;
     }
     throw new Error(
-    // eslint-disable-next-line prefer-template
+        `Function "${functionName}" has unexpected parameter(s) provided: ` +
-    `Function "${functionName}" has unexpected parameter(s) provided: `
+        `"${unexpectedParameters.join('", "')}"` +
-      + `"${unexpectedParameters.join('", "')}"`
+        '. Expected parameter(s): ' +
-      + '. Expected parameter(s): '
+        (expectedParameters.length ? `"${expectedParameters.join('", "')}"` : 'none'),
-      + (expectedParameters.length ? `"${expectedParameters.join('", "')}"` : 'none'),
     );
 }

src/application/Parser/Script/Compiler/Function/Call/Compiler/IFunctionCallCompiler.ts

@@ -1,6 +1,6 @@
+import { ICompiledCode } from './ICompiledCode';
 import { ISharedFunctionCollection } from '@/application/Parser/Script/Compiler/Function/ISharedFunctionCollection';
 import { IFunctionCall } from '../IFunctionCall';
-import { ICompiledCode } from './ICompiledCode';
 
 export interface IFunctionCallCompiler {
     compileCall(

src/application/Parser/Script/Compiler/Function/Call/FunctionCall.ts

@@ -4,13 +4,12 @@ import { IFunctionCall } from './IFunctionCall';
 export class FunctionCall implements IFunctionCall {
     constructor(
         public readonly functionName: string,
-    public readonly args: IReadOnlyFunctionCallArgumentCollection,
+        public readonly args: IReadOnlyFunctionCallArgumentCollection) {
-  ) {
         if (!functionName) {
-      throw new Error('missing function name in function call');
+            throw new Error('empty function name in function call');
         }
         if (!args) {
-      throw new Error('missing args');
+            throw new Error('undefined args');
         }
     }
 }

src/application/Parser/Script/Compiler/Function/Call/FunctionCallParser.ts

@@ -1,12 +1,12 @@
-import type { FunctionCallData, FunctionCallsData, FunctionCallParametersData } from '@/application/collections/';
+import { FunctionCallData, FunctionCallsData } from 'js-yaml-loader!@/*';
 import { IFunctionCall } from './IFunctionCall';
 import { FunctionCallArgumentCollection } from './Argument/FunctionCallArgumentCollection';
 import { FunctionCallArgument } from './Argument/FunctionCallArgument';
 import { FunctionCall } from './FunctionCall';
 
 export function parseFunctionCalls(calls: FunctionCallsData): IFunctionCall[] {
-  if (calls === undefined) {
+    if (!calls) {
-    throw new Error('missing call data');
+        throw new Error('undefined call data');
     }
     const sequence = getCallSequence(calls);
     return sequence.map((call) => parseFunctionCall(call));
@@ -19,24 +19,17 @@ function getCallSequence(calls: FunctionCallsData): FunctionCallData[] {
     if (calls instanceof Array) {
         return calls as FunctionCallData[];
     }
-  return [calls as FunctionCallData];
+    return [ calls as FunctionCallData ];
 }
 
 function parseFunctionCall(call: FunctionCallData): IFunctionCall {
     if (!call) {
-    throw new Error('missing call data');
+        throw new Error(`undefined function call`);
     }
-  const callArgs = parseArgs(call.parameters);
+    const args = new FunctionCallArgumentCollection();
-  return new FunctionCall(call.function, callArgs);
+    for (const parameterName of Object.keys(call.parameters || {})) {
-}
+        const arg = new FunctionCallArgument(parameterName, call.parameters[parameterName]);
-
-function parseArgs(
-  parameters: FunctionCallParametersData,
-): FunctionCallArgumentCollection {
-  return Object.keys(parameters || {})
-    .map((parameterName) => new FunctionCallArgument(parameterName, parameters[parameterName]))
-    .reduce((args, arg) => {
         args.addArgument(arg);
-      return args;
+    }
-    }, new FunctionCallArgumentCollection());
+    return new FunctionCall(call.function, args);
 }

src/application/Parser/Script/Compiler/Function/ISharedFunction.ts

@@ -1,5 +1,5 @@
 import { IReadOnlyFunctionParameterCollection } from './Parameter/IFunctionParameterCollection';
-import { IFunctionCall } from './Call/IFunctionCall';
+import { IFunctionCall } from '../Function/Call/IFunctionCall';
 
 export interface ISharedFunction {
     readonly name: string;

src/application/Parser/Script/Compiler/Function/ISharedFunctionsParser.ts

@@ -1,4 +1,4 @@
-import type { FunctionData } from '@/application/collections/';
+import { FunctionData } from 'js-yaml-loader!@/*';
 import { ISharedFunctionCollection } from './ISharedFunctionCollection';
 
 export interface ISharedFunctionsParser {

src/application/Parser/Script/Compiler/Function/Parameter/FunctionParameter.ts

@@ -1,11 +1,10 @@
-import { ensureValidParameterName } from '../Shared/ParameterNameValidator';
 import { IFunctionParameter } from './IFunctionParameter';
+import { ensureValidParameterName } from '../Shared/ParameterNameValidator';
 
 export class FunctionParameter implements IFunctionParameter {
     constructor(
         public readonly name: string,
-    public readonly isOptional: boolean,
+        public readonly isOptional: boolean) {
-  ) {
         ensureValidParameterName(name);
     }
 }

src/application/Parser/Script/Compiler/Function/Parameter/FunctionParameterCollection.ts

@@ -7,7 +7,6 @@ export class FunctionParameterCollection implements IFunctionParameterCollection
     public get all(): readonly IFunctionParameter[] {
         return this.parameters;
     }
-
     public addParameter(parameter: IFunctionParameter) {
         this.ensureValidParameter(parameter);
         this.parameters.push(parameter);
@@ -16,10 +15,9 @@ export class FunctionParameterCollection implements IFunctionParameterCollection
     private includesName(name: string) {
         return this.parameters.find((existingParameter) => existingParameter.name === name);
     }
-
     private ensureValidParameter(parameter: IFunctionParameter) {
         if (!parameter) {
-      throw new Error('missing parameter');
+            throw new Error('undefined parameter');
         }
         if (this.includesName(parameter.name)) {
             throw new Error(`duplicate parameter name: "${parameter.name}"`);

src/application/Parser/Script/Compiler/Function/Shared/ParameterNameValidator.ts

@@ -1,6 +1,6 @@
 export function ensureValidParameterName(parameterName: string) {
     if (!parameterName) {
-    throw new Error('missing parameter name');
+        throw new Error('undefined parameter name');
     }
     if (!parameterName.match(/^[0-9a-zA-Z]+$/)) {
         throw new Error(`parameter name must be alphanumeric but it was "${parameterName}"`);

src/application/Parser/Script/Compiler/Function/SharedFunction.ts

@@ -1,16 +1,16 @@
-import { IFunctionCall } from './Call/IFunctionCall';
+import { IFunctionCall } from '../Function/Call/IFunctionCall';
-import {
+import { FunctionBodyType, IFunctionCode, ISharedFunction, ISharedFunctionBody } from './ISharedFunction';
-  FunctionBodyType, IFunctionCode, ISharedFunction, ISharedFunctionBody,
-} from './ISharedFunction';
 import { IReadOnlyFunctionParameterCollection } from './Parameter/IFunctionParameterCollection';
 
 export function createCallerFunction(
     name: string,
     parameters: IReadOnlyFunctionParameterCollection,
-  callSequence: readonly IFunctionCall[],
+    callSequence: readonly IFunctionCall[]): ISharedFunction {
-): ISharedFunction {
+    if (!callSequence) {
-  if (!callSequence || !callSequence.length) {
+        throw new Error(`undefined call sequence in function "${name}"`);
-    throw new Error(`missing call sequence in function "${name}"`);
+    }
+    if (!callSequence.length) {
+        throw new Error(`empty call sequence in function "${name}"`);
     }
     return new SharedFunction(name, parameters, callSequence, FunctionBodyType.Calls);
 }
@@ -19,8 +19,7 @@ export function createFunctionWithInlineCode(
     name: string,
     parameters: IReadOnlyFunctionParameterCollection,
     code: string,
-  revertCode?: string,
+    revertCode?: string): ISharedFunction {
-): ISharedFunction {
     if (!code) {
         throw new Error(`undefined code in function "${name}"`);
     }
@@ -33,15 +32,14 @@ export function createFunctionWithInlineCode(
 
 class SharedFunction implements ISharedFunction {
     public readonly body: ISharedFunctionBody;
-
     constructor(
         public readonly name: string,
         public readonly parameters: IReadOnlyFunctionParameterCollection,
         content: IFunctionCode | readonly IFunctionCall[],
         bodyType: FunctionBodyType,
         ) {
-    if (!name) { throw new Error('missing function name'); }
+        if (!name) { throw new Error('undefined function name'); }
-    if (!parameters) { throw new Error('missing parameters'); }
+        if (!parameters) { throw new Error(`undefined parameters`); }
         this.body = {
             type: bodyType,
             code: bodyType === FunctionBodyType.Code ? content as IFunctionCode : undefined,

src/application/Parser/Script/Compiler/Function/SharedFunctionCollection.ts

@@ -5,7 +5,7 @@ export class SharedFunctionCollection implements ISharedFunctionCollection {
     private readonly functionsByName = new Map<string, ISharedFunction>();
 
     public addFunction(func: ISharedFunction): void {
-    if (!func) { throw new Error('missing function'); }
+        if (!func) { throw new Error('undefined function'); }
         if (this.has(func.name)) {
             throw new Error(`function with name ${func.name} already exists`);
         }
@@ -13,7 +13,7 @@ export class SharedFunctionCollection implements ISharedFunctionCollection {
     }
 
     public getFunctionByName(name: string): ISharedFunction {
-    if (!name) { throw Error('missing function name'); }
+        if (!name) { throw Error('undefined function name'); }
         const func = this.functionsByName.get(name);
         if (!func) {
             throw new Error(`called function is not defined "${name}"`);

src/application/Parser/Script/Compiler/Function/SharedFunctionsParser.ts

@@ -1,4 +1,4 @@
-import type { FunctionData, InstructionHolder } from '@/application/collections/';
+import { FunctionData, InstructionHolder } from 'js-yaml-loader!@/*';
 import { createFunctionWithInlineCode, createCallerFunction } from './SharedFunction';
 import { SharedFunctionCollection } from './SharedFunctionCollection';
 import { ISharedFunctionCollection } from './ISharedFunctionCollection';
@@ -11,51 +11,47 @@ import { parseFunctionCalls } from './Call/FunctionCallParser';
 
 export class SharedFunctionsParser implements ISharedFunctionsParser {
     public static readonly instance: ISharedFunctionsParser = new SharedFunctionsParser();
-
     public parseFunctions(
-    functions: readonly FunctionData[],
+        functions: readonly FunctionData[]): ISharedFunctionCollection {
-  ): ISharedFunctionCollection {
         const collection = new SharedFunctionCollection();
         if (!functions || !functions.length) {
             return collection;
         }
         ensureValidFunctions(functions);
-    return functions
+        for (const func of functions) {
-      .map((func) => parseFunction(func))
+            const sharedFunction = parseFunction(func);
-      .reduce((acc, func) => {
+            collection.addFunction(sharedFunction);
-        acc.addFunction(func);
+        }
-        return acc;
+        return collection;
-      }, collection);
     }
 }
 
 function parseFunction(data: FunctionData): ISharedFunction {
-  const { name } = data;
+    const name = data.name;
     const parameters = parseParameters(data);
     if (hasCode(data)) {
         return createFunctionWithInlineCode(name, parameters, data.code, data.revertCode);
-  }
+    } else { // has call
-  // Has call
         const calls = parseFunctionCalls(data.call);
         return createCallerFunction(name, parameters, calls);
+    }
 }
 
 function parseParameters(data: FunctionData): IReadOnlyFunctionParameterCollection {
-  return (data.parameters || [])
+    const parameters = new FunctionParameterCollection();
-    .map((parameter) => {
+    if (!data.parameters) {
+        return parameters;
+    }
+    for (const parameterData of data.parameters) {
+        const isOptional = parameterData.optional || false;
         try {
-        return new FunctionParameter(
+            const parameter = new FunctionParameter(parameterData.name, isOptional);
-          parameter.name,
+            parameters.addParameter(parameter);
-          parameter.optional || false,
-        );
         } catch (err) {
             throw new Error(`"${data.name}": ${err.message}`);
         }
-    })
+    }
-    .reduce((parameters, parameter) => {
-      parameters.addParameter(parameter);
     return parameters;
-    }, new FunctionParameterCollection());
 }
 
 function hasCode(data: FunctionData): boolean {
@@ -100,7 +96,7 @@ function ensureExpectedParametersType(functions: readonly FunctionData[]) {
     }
 }
 
-function isArrayOfObjects(value: unknown): boolean {
+function isArrayOfObjects(value: any): boolean {
     return Array.isArray(value)
         && value.every((item) => typeof item === 'object');
 }
@@ -119,14 +115,15 @@ function ensureNoDuplicatesInFunctionNames(functions: readonly FunctionData[]) {
 
 function ensureNoUndefinedItem(functions: readonly FunctionData[]) {
     if (functions.some((func) => !func)) {
-    throw new Error('some functions are undefined');
+        throw new Error(`some functions are undefined`);
     }
 }
 
 function ensureNoDuplicateCode(functions: readonly FunctionData[]) {
     const duplicateCodes = getDuplicates(functions
         .map((func) => func.code)
-    .filter((code) => code));
+        .filter((code) => code),
+    );
     if (duplicateCodes.length > 0) {
         throw new Error(`duplicate "code" in functions: ${printList(duplicateCodes)}`);
     }

src/application/Parser/Script/Compiler/IScriptCompiler.ts

@@ -1,5 +1,5 @@
-import type { ScriptData } from '@/application/collections/';
 import { IScriptCode } from '@/domain/IScriptCode';
+import { ScriptData } from 'js-yaml-loader!@/*';
 
 export interface IScriptCompiler {
     canCompile(script: ScriptData): boolean;

src/application/Parser/Script/Compiler/ScriptCompiler.ts

@@ -1,6 +1,7 @@
-import type { FunctionData, ScriptData } from '@/application/collections/';
 import { IScriptCode } from '@/domain/IScriptCode';
-import { ScriptCode, ILanguageSyntax } from '@/domain/ScriptCode';
+import { ScriptCode } from '@/domain/ScriptCode';
+import { ILanguageSyntax } from '@/domain/ScriptCode';
+import { FunctionData, ScriptData } from 'js-yaml-loader!@/*';
 import { IScriptCompiler } from './IScriptCompiler';
 import { ISharedFunctionCollection } from './Function/ISharedFunctionCollection';
 import { IFunctionCallCompiler } from './Function/Call/Compiler/IFunctionCallCompiler';
@@ -11,35 +12,31 @@ import { parseFunctionCalls } from './Function/Call/FunctionCallParser';
 
 export class ScriptCompiler implements IScriptCompiler {
     private readonly functions: ISharedFunctionCollection;
-
     constructor(
         functions: readonly FunctionData[] | undefined,
         private readonly syntax: ILanguageSyntax,
-    private readonly callCompiler: IFunctionCallCompiler = FunctionCallCompiler.instance,
         sharedFunctionsParser: ISharedFunctionsParser = SharedFunctionsParser.instance,
+        private readonly callCompiler: IFunctionCallCompiler = FunctionCallCompiler.instance,
         ) {
-    if (!syntax) { throw new Error('missing syntax'); }
+        if (!syntax) { throw new Error('undefined syntax'); }
         this.functions = sharedFunctionsParser.parseFunctions(functions);
     }
-
     public canCompile(script: ScriptData): boolean {
-    if (!script) { throw new Error('missing script'); }
+        if (!script) { throw new Error('undefined script'); }
         if (!script.call) {
             return false;
         }
         return true;
     }
-
     public compile(script: ScriptData): IScriptCode {
-    if (!script) { throw new Error('missing script'); }
+        if (!script) { throw new Error('undefined script'); }
         try {
             const calls = parseFunctionCalls(script.call);
             const compiledCode = this.callCompiler.compileCall(calls, this.functions);
             return new ScriptCode(
                 compiledCode.code,
                 compiledCode.revertCode,
-        this.syntax,
+                this.syntax);
-      );
         } catch (error) {
             throw Error(`Script "${script.name}" ${error.message}`);
         }

src/application/Parser/Script/ScriptParser.ts

@@ -1,32 +1,26 @@
-import type { ScriptData } from '@/application/collections/';
 import { Script } from '@/domain/Script';
+import { ScriptData } from 'js-yaml-loader!@/*';
+import { parseDocUrls } from '../DocumentationParser';
 import { RecommendationLevel } from '@/domain/RecommendationLevel';
 import { IScriptCode } from '@/domain/IScriptCode';
 import { ScriptCode } from '@/domain/ScriptCode';
-import { parseDocUrls } from '../DocumentationParser';
 import { createEnumParser, IEnumParser } from '../../Common/Enum';
 import { ICategoryCollectionParseContext } from './ICategoryCollectionParseContext';
 
 export function parseScript(
-  data: ScriptData,
+    data: ScriptData, context: ICategoryCollectionParseContext,
-  context: ICategoryCollectionParseContext,
+    levelParser = createEnumParser(RecommendationLevel)): Script {
-  levelParser = createEnumParser(RecommendationLevel),
-): Script {
     validateScript(data);
-  if (!context) { throw new Error('missing context'); }
+    if (!context)    {    throw new Error('undefined context');  }
     const script = new Script(
-    /* name: */ data.name,
+        /* name */  data.name,
-    /* code: */ parseCode(data, context),
+        /* code */  parseCode(data, context),
-    /* docs: */ parseDocUrls(data),
+        /* docs */  parseDocUrls(data),
-    /* level: */ parseLevel(data.recommend, levelParser),
+        /* level */ parseLevel(data.recommend, levelParser));
-  );
     return script;
 }
 
-function parseLevel(
+function parseLevel(level: string, parser: IEnumParser<RecommendationLevel>): RecommendationLevel | undefined {
-  level: string,
-  parser: IEnumParser<RecommendationLevel>,
-): RecommendationLevel | undefined {
     if (!level) {
         return undefined;
     }
@@ -51,7 +45,7 @@ function ensureNotBothCallAndCode(script: ScriptData) {
 
 function validateScript(script: ScriptData) {
     if (!script) {
-    throw new Error('missing script');
+        throw new Error('undefined script');
     }
     if (!script.code && !script.call) {
         throw new Error('must define either "call" or "code"');