Add AD detection on desktop app #264, #304

This commit addresses issues #264 and #304, where users were not
receiving error messages when script execution failed due to
antivirus intervention, particularly with Microsoft Defender.
Now, desktop app users will see a detailed error message with
guidance on next steps if script saving or execution fails due
to antivirus removal.

Key changes:

- Implement a check to detect failure in file writing,
  including reading the written file back. This method effectively
  detects antivirus interventions, as the read operation triggers
  an antivirus scan, leading to file deletion by the antivirus.
- Introduce a specific error message for scenarios where an
  antivirus intervention is detected.

src/infrastructure/CodeRunner/Creation/ScriptFileCreationOrchestrator.ts

@@ -1,6 +1,8 @@
 import { ElectronLogger } from '@/infrastructure/Log/ElectronLogger';
 import { Logger } from '@/application/Common/Log/Logger';
 import { CodeRunError, CodeRunErrorType } from '@/application/CodeRunner/CodeRunner';
+import { FileReadbackVerificationErrors, ReadbackFileWriter } from '@/infrastructure/ReadbackFileWriter/ReadbackFileWriter';
+import { NodeReadbackFileWriter } from '@/infrastructure/ReadbackFileWriter/NodeReadbackFileWriter';
 import { SystemOperations } from '../System/SystemOperations';
 import { NodeElectronSystemOperations } from '../System/NodeElectronSystemOperations';
 import { FilenameGenerator } from './Filename/FilenameGenerator';
@@ -14,6 +16,7 @@ export class ScriptFileCreationOrchestrator implements ScriptFileCreator {
     private readonly system: SystemOperations = new NodeElectronSystemOperations(),
     private readonly filenameGenerator: FilenameGenerator = new TimestampedFilenameGenerator(),
     private readonly directoryProvider: ScriptDirectoryProvider = new PersistentDirectoryProvider(),
+    private readonly fileWriter: ReadbackFileWriter = new NodeReadbackFileWriter(),
     private readonly logger: Logger = ElectronLogger,
   ) { }
 
@@ -65,17 +68,19 @@ export class ScriptFileCreationOrchestrator implements ScriptFileCreator {
     filePath: string,
     contents: string,
   ): Promise<FileWriteOutcome> {
-    try {
-      this.logger.info(`Creating file at ${filePath}, size: ${contents.length} characters`);
-      await this.system.fileSystem.writeToFile(filePath, contents);
-      this.logger.info(`File created successfully at ${filePath}`);
+    const {
+      success, error,
+    } = await this.fileWriter.writeAndVerifyFile(filePath, contents);
+    if (success) {
       return { success: true };
-    } catch (error) {
-      return {
-        success: false,
-        error: this.handleException(error, 'FileWriteError'),
-      };
     }
+    return {
+      success: false,
+      error: {
+        message: error.message,
+        type: FileReadbackVerificationErrors.find((e) => e === error.type) ? 'FileReadbackVerificationError' : 'FileWriteError',
+      },
+    };
   }
 
   private handleException(

src/infrastructure/CodeRunner/System/NodeElectronSystemOperations.ts

@@ -1,5 +1,5 @@
 import { join } from 'node:path';
-import { chmod, mkdir, writeFile } from 'node:fs/promises';
+import { chmod, mkdir } from 'node:fs/promises';
 import { exec } from 'node:child_process';
 import { app } from 'electron/main';
 import {
@@ -46,10 +46,6 @@ export class NodeElectronSystemOperations implements SystemOperations {
       // when `recursive` is true, or empty return value.
       // See https://github.com/nodejs/node/pull/31530
     },
-    writeToFile: (
-      filePath: string,
-      data: string,
-    ) => writeFile(filePath, data),
   };
 
   public readonly command: CommandOps = {

src/infrastructure/CodeRunner/System/SystemOperations.ts

@@ -20,5 +20,4 @@ export interface CommandOps {
 export interface FileSystemOps {
   setFilePermissions(filePath: string, mode: string | number): Promise<void>;
   createDirectory(directoryPath: string, isRecursive?: boolean): Promise<void>;
-  writeToFile(filePath: string, data: string): Promise<void>;
 }