From ea5f9ec27df7cec6ac575e23fef18948d2b8e68a Mon Sep 17 00:00:00 2001 From: undergroundwires Date: Mon, 23 Aug 2021 17:38:14 +0100 Subject: [PATCH] Fix infinitely subscribing to state changes --- .../components/Scripts/Menu/Selector/TheSelector.vue | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/presentation/components/Scripts/Menu/Selector/TheSelector.vue b/src/presentation/components/Scripts/Menu/Selector/TheSelector.vue index 5694071f..3e396648 100644 --- a/src/presentation/components/Scripts/Menu/Selector/TheSelector.vue +++ b/src/presentation/components/Scripts/Menu/Selector/TheSelector.vue @@ -72,13 +72,11 @@ export default class TheSelector extends StatefulVue { this.selectionTypeHandler.selectType(type); } - protected handleCollectionState(newState: ICategoryCollectionState, oldState: ICategoryCollectionState): void { + protected handleCollectionState(newState: ICategoryCollectionState): void { + this.events.unsubscribeAll(); this.selectionTypeHandler = new SelectionTypeHandler(newState); this.updateSelections(); - newState.selection.changed.on(() => this.updateSelections()); - if (oldState) { - oldState.selection.changed.on(() => this.updateSelections()); - } + this.events.register(newState.selection.changed.on(() => this.updateSelections())); } private updateSelections() {