Bump to TypeScript 5.5 and enable noImplicitAny
This commit upgrades TypeScript from 5.4 to 5.5 and enables the
`noImplicitAny` option for stricter type checking. It refactors code to
comply with `noImplicitAny` and adapts to new TypeScript features and
limitations.
Key changes:
- Migrate from TypeScript 5.4 to 5.5
- Enable `noImplicitAny` for stricter type checking
- Refactor code to comply with new TypeScript features and limitations
Other supporting changes:
- Refactor progress bar handling for type safety
- Drop 'I' prefix from interfaces to align with new code convention
- Update TypeScript target from `ES2017` and `ES2018`.
This allows named capturing groups. Otherwise, new TypeScript compiler
does not compile the project and shows the following error:
```
...
TimestampedFilenameGenerator.spec.ts:105:23 - error TS1503: Named capturing groups are only available when targeting 'ES2018' or later
const pattern = /^(?<timestamp>\d{4}-\d{2}-\d{2}_\d{2}-\d{2}-\d{2})-(?<scriptName>[^.]+?)(?:\.(?<extension>[^.]+))?$/;// timestamp-scriptName.extension
...
```
- Refactor usage of `electron-progressbar` for type safety and
less complexity.
This commit is contained in:
@@ -67,7 +67,7 @@ function runSharedTestsForAnimation(
|
||||
};
|
||||
const element = document.createElement('div');
|
||||
Object.entries(expectedStyleValues).forEach(([key, value]) => {
|
||||
element.style[key] = value;
|
||||
element.style[key as keyof MutatedStyleProperties] = value;
|
||||
});
|
||||
const timer = new TimerStub();
|
||||
const hookResult = useExpandCollapseAnimation(timer);
|
||||
@@ -78,7 +78,8 @@ function runSharedTestsForAnimation(
|
||||
await promise;
|
||||
// assert
|
||||
Object.entries(expectedStyleValues).forEach(([key, expectedStyleValue]) => {
|
||||
const actualStyleValue = element.style[key];
|
||||
const styleProperty = key as keyof MutatedStyleProperties;
|
||||
const actualStyleValue = element.style[styleProperty];
|
||||
expect(actualStyleValue).to.equal(expectedStyleValue, formatAssertionMessage([
|
||||
`Style key: ${key}`,
|
||||
`Expected style value: ${expectedStyleValue}`,
|
||||
@@ -86,7 +87,7 @@ function runSharedTestsForAnimation(
|
||||
`Initial style value: ${expectedStyleValues}`,
|
||||
'All styles:',
|
||||
...Object.entries(expectedStyleValues)
|
||||
.map(([k, value]) => indentText(`- ${k} > actual: "${element.style[k]}" | expected: "${value}"`)),
|
||||
.map(([k, value]) => indentText(`- ${k} > actual: "${actualStyleValue}" | expected: "${value}"`)),
|
||||
]));
|
||||
});
|
||||
});
|
||||
|
||||
@@ -30,18 +30,19 @@ describe('useClipboard', () => {
|
||||
} = {
|
||||
copyText: ['text-arg'],
|
||||
};
|
||||
Object.entries(testScenarios).forEach(([functionName, testFunctionArgs]) => {
|
||||
describe(functionName, () => {
|
||||
Object.entries(testScenarios).forEach(([functionNameValue, testFunctionArgs]) => {
|
||||
const functionName = functionNameValue as ClipboardFunction;
|
||||
describe(functionNameValue, () => {
|
||||
it('binds the method to the instance', () => {
|
||||
// arrange
|
||||
const expectedArgs = testFunctionArgs;
|
||||
const clipboardStub = new ClipboardStub();
|
||||
// act
|
||||
const clipboard = useClipboard(clipboardStub);
|
||||
const { [functionName as ClipboardFunction]: testFunction } = clipboard;
|
||||
const { [functionName]: testFunction } = clipboard;
|
||||
// assert
|
||||
testFunction(...expectedArgs);
|
||||
const call = clipboardStub.callHistory.find((c) => c.methodName === functionName);
|
||||
const call = clipboardStub.callHistory.find((c) => c.methodName === functionNameValue);
|
||||
expectExists(call);
|
||||
expect(call.args).to.deep.equal(expectedArgs);
|
||||
});
|
||||
@@ -50,14 +51,15 @@ describe('useClipboard', () => {
|
||||
const clipboardStub = new ClipboardStub();
|
||||
const expectedThisContext = clipboardStub;
|
||||
let actualThisContext: typeof expectedThisContext | undefined;
|
||||
// eslint-disable-next-line func-names
|
||||
clipboardStub[functionName] = function () {
|
||||
// eslint-disable-next-line func-names, @typescript-eslint/no-unused-vars
|
||||
clipboardStub[functionName] = function (_text) {
|
||||
// eslint-disable-next-line @typescript-eslint/no-this-alias
|
||||
actualThisContext = this;
|
||||
return Promise.resolve();
|
||||
};
|
||||
// act
|
||||
const clipboard = useClipboard(clipboardStub);
|
||||
const { [functionName as ClipboardFunction]: testFunction } = clipboard;
|
||||
const { [functionNameValue as ClipboardFunction]: testFunction } = clipboard;
|
||||
// assert
|
||||
testFunction(...testFunctionArgs);
|
||||
expect(expectedThisContext).to.equal(actualThisContext);
|
||||
|
||||
@@ -9,6 +9,7 @@ import { ScriptStub } from '@tests/unit/shared/Stubs/ScriptStub';
|
||||
import { CategoryCollectionStateStub } from '@tests/unit/shared/Stubs/CategoryCollectionStateStub';
|
||||
import { SelectedScriptStub } from '@tests/unit/shared/Stubs/SelectedScriptStub';
|
||||
import { ScriptSelectionStub } from '@tests/unit/shared/Stubs/ScriptSelectionStub';
|
||||
import type { SelectedScript } from '@/application/Context/State/Selection/Script/SelectedScript';
|
||||
|
||||
describe('useUserSelectionState', () => {
|
||||
describe('currentSelection', () => {
|
||||
@@ -170,8 +171,8 @@ describe('useUserSelectionState', () => {
|
||||
describe('triggers change', () => {
|
||||
it('with new selected scripts array reference', async () => {
|
||||
// arrange
|
||||
const oldSelectedScriptsArrayReference = [];
|
||||
const newSelectedScriptsArrayReference = [];
|
||||
const oldSelectedScriptsArrayReference = new Array<SelectedScript>();
|
||||
const newSelectedScriptsArrayReference = new Array<SelectedScript>();
|
||||
const scriptSelectionStub = new ScriptSelectionStub()
|
||||
.withSelectedScripts(oldSelectedScriptsArrayReference);
|
||||
const collectionStateStub = new UseCollectionStateStub()
|
||||
@@ -191,7 +192,7 @@ describe('useUserSelectionState', () => {
|
||||
});
|
||||
it('with same selected scripts array reference', async () => {
|
||||
// arrange
|
||||
const sharedSelectedScriptsReference = [];
|
||||
const sharedSelectedScriptsReference = new Array<SelectedScript>();
|
||||
const scriptSelectionStub = new ScriptSelectionStub()
|
||||
.withSelectedScripts(sharedSelectedScriptsReference);
|
||||
const collectionStateStub = new UseCollectionStateStub()
|
||||
|
||||
Reference in New Issue
Block a user