Refactor executable IDs to use strings #262
This commit unifies executable ID structure across categories and scripts, paving the way for more complex ID solutions for #262. It also refactors related code to adapt to the changes. Key changes: - Change numeric IDs to string IDs for categories - Use named types for string IDs to improve code clarity - Add unit tests to verify ID uniqueness Other supporting changes: - Separate concerns in entities for data access and executables by using separate abstractions (`Identifiable` and `RepositoryEntity`) - Simplify usage and construction of entities. - Remove `BaseEntity` for simplicity. - Move creation of categories/scripts to domain layer - Refactor CategoryCollection for better validation logic isolation - Rename some categories to keep the names (used as pseudo-IDs) unique on Windows.
This commit is contained in:
@@ -1,15 +1,15 @@
|
||||
import { BaseEntity } from '@/infrastructure/Entity/BaseEntity';
|
||||
import type { Script } from '@/domain/Executables/Script/Script';
|
||||
import { RecommendationLevel } from '@/domain/Executables/Script/RecommendationLevel';
|
||||
import type { ScriptCode } from '@/domain/Executables/Script/Code/ScriptCode';
|
||||
import type { ExecutableId } from '@/domain/Executables/Identifiable';
|
||||
import { SelectedScriptStub } from './SelectedScriptStub';
|
||||
|
||||
export class ScriptStub extends BaseEntity<string> implements Script {
|
||||
public name = `name${this.id}`;
|
||||
export class ScriptStub implements Script {
|
||||
public name = `name${this.executableId}`;
|
||||
|
||||
public code: ScriptCode = {
|
||||
execute: `REM execute-code (${this.id})`,
|
||||
revert: `REM revert-code (${this.id})`,
|
||||
execute: `REM execute-code (${this.executableId})`,
|
||||
revert: `REM revert-code (${this.executableId})`,
|
||||
};
|
||||
|
||||
public docs: readonly string[] = new Array<string>();
|
||||
@@ -18,9 +18,7 @@ export class ScriptStub extends BaseEntity<string> implements Script {
|
||||
|
||||
private isReversible: boolean | undefined = undefined;
|
||||
|
||||
constructor(public readonly id: string) {
|
||||
super(id);
|
||||
}
|
||||
constructor(public readonly executableId: ExecutableId) { }
|
||||
|
||||
public canRevert(): boolean {
|
||||
if (this.isReversible === undefined) {
|
||||
|
||||
Reference in New Issue
Block a user