Refactor executable IDs to use strings #262
This commit unifies executable ID structure across categories and scripts, paving the way for more complex ID solutions for #262. It also refactors related code to adapt to the changes. Key changes: - Change numeric IDs to string IDs for categories - Use named types for string IDs to improve code clarity - Add unit tests to verify ID uniqueness Other supporting changes: - Separate concerns in entities for data access and executables by using separate abstractions (`Identifiable` and `RepositoryEntity`) - Simplify usage and construction of entities. - Remove `BaseEntity` for simplicity. - Move creation of categories/scripts to domain layer - Refactor CategoryCollection for better validation logic isolation - Rename some categories to keep the names (used as pseudo-IDs) unique on Windows.
This commit is contained in:
@@ -4,6 +4,7 @@ import type { SelectedScript } from '@/application/Context/State/Selection/Scrip
|
||||
import type { Script } from '@/domain/Executables/Script/Script';
|
||||
import type { ScriptSelectionChange, ScriptSelectionChangeCommand } from '@/application/Context/State/Selection/Script/ScriptSelectionChange';
|
||||
import { formatAssertionMessage } from '@tests/shared/FormatAssertionMessage';
|
||||
import type { ExecutableId } from '@/domain/Executables/Identifiable';
|
||||
import { StubWithObservableMethodCalls } from './StubWithObservableMethodCalls';
|
||||
import { EventSourceStub } from './EventSourceStub';
|
||||
import { SelectedScriptStub } from './SelectedScriptStub';
|
||||
@@ -32,9 +33,9 @@ export class ScriptSelectionStub
|
||||
return this;
|
||||
}
|
||||
|
||||
public isScriptSelected(scriptId: string, revert: boolean): boolean {
|
||||
public isScriptSelected(scriptExecutableId: ExecutableId, revert: boolean): boolean {
|
||||
return this.isScriptChanged({
|
||||
scriptId,
|
||||
scriptId: scriptExecutableId,
|
||||
newStatus: {
|
||||
isSelected: true,
|
||||
isReverted: revert,
|
||||
@@ -42,9 +43,9 @@ export class ScriptSelectionStub
|
||||
});
|
||||
}
|
||||
|
||||
public isScriptDeselected(scriptId: string): boolean {
|
||||
public isScriptDeselected(scriptExecutableId: ExecutableId): boolean {
|
||||
return this.isScriptChanged({
|
||||
scriptId,
|
||||
scriptId: scriptExecutableId,
|
||||
newStatus: {
|
||||
isSelected: false,
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user