refactoring to new function

This commit is contained in:
undergroundwires
2020-01-06 17:45:38 +01:00
parent aff463dd64
commit c646c10273

View File

@@ -13,18 +13,11 @@ export class Script extends BaseEntity<string> implements IScript {
if (lines.length === 0) { if (lines.length === 0) {
return; return;
} }
const checkForDuplicates = (line: string) => {
const trimmed = line.trim();
if (trimmed.length === 1 && trimmed === ')' || trimmed === '(') {
return false;
}
return true;
};
const duplicateLines = new Array<string>(); const duplicateLines = new Array<string>();
const uniqueLines = new Set<string>(); const uniqueLines = new Set<string>();
let validatedLineCount = 0; let validatedLineCount = 0;
for (const line of lines) { for (const line of lines) {
if (!checkForDuplicates(line)) { if (!this.isUniqueLine(line)) {
continue; continue;
} }
uniqueLines.add(line); uniqueLines.add(line);
@@ -38,6 +31,14 @@ export class Script extends BaseEntity<string> implements IScript {
} }
} }
private static isUniqueLine(codeLine: string): boolean {
const trimmed = codeLine.trim();
if (trimmed === ')' || trimmed === '(') { // "(" and ")" are used often in batch code
return false;
}
return true;
}
constructor(public name: string, public code: string, public documentationUrls: ReadonlyArray<string>) { constructor(public name: string, public code: string, public documentationUrls: ReadonlyArray<string>) {
super(name); super(name);
if (code == null || code.length === 0) { if (code == null || code.length === 0) {