This commit introduces native operating system file dialogs in the desktop application replacing the existing web-based dialogs. It lays the foundation for future enhancements such as: - Providing error messages when saving or executing files, addressing #264. - Creating system restore points, addressing #50. Documentation updates: - Update `desktop-vs-web-features.md` with added functionality. - Update `README.md` with security feature highlights. - Update home page documentation to emphasize security features. Other supporting changes include: - Integrate IPC communication channels for secure Electron dialog API interactions. - Refactor `IpcRegistration` for more type-safety and simplicity. - Introduce a Vue hook to encapsulate dialog functionality. - Improve errors during IPC registration for easier troubleshooting. - Move `ClientLoggerFactory` for consistency in hooks organization and remove `LoggerFactory` interface for simplicity. - Add tests for the save file dialog in the browser context. - Add `Blob` polyfill in tests to compensate for the missing `blob.text()` function in `jsdom` (see jsdom/jsdom#2555). Improve environment detection logic: - Treat test environment as browser environments to correctly activate features based on the environment. This resolves issues where the environment is misidentified as desktop, but Electron preloader APIs are missing. - Rename `isDesktop` environment identification variable to `isRunningAsDesktopApplication` for better clarity and to avoid confusion with desktop environments in web/browser/test environments. - Simplify `BrowserRuntimeEnvironment` to consistently detect non-desktop application environments. - Improve environment detection for Electron main process (electron/electron#2288).
This commit is contained in:
@@ -1,10 +1,10 @@
|
||||
import { describe, it, expect } from 'vitest';
|
||||
import { IpcChannel } from '@/presentation/electron/shared/IpcBridging/IpcChannel';
|
||||
import { IpcChannelDefinitions } from '@/presentation/electron/shared/IpcBridging/IpcChannelDefinitions';
|
||||
import { ChannelDefinitionKey, IpcChannelDefinitions } from '@/presentation/electron/shared/IpcBridging/IpcChannelDefinitions';
|
||||
|
||||
describe('IpcChannelDefinitions', () => {
|
||||
it('defines IPC channels correctly', () => {
|
||||
const testScenarios: Record<keyof typeof IpcChannelDefinitions, {
|
||||
const testScenarios: Record<ChannelDefinitionKey, {
|
||||
readonly expectedNamespace: string;
|
||||
readonly expectedAccessibleMembers: readonly string[];
|
||||
}> = {
|
||||
@@ -12,6 +12,10 @@ describe('IpcChannelDefinitions', () => {
|
||||
expectedNamespace: 'code-run',
|
||||
expectedAccessibleMembers: ['runCode'],
|
||||
},
|
||||
Dialog: {
|
||||
expectedNamespace: 'dialogs',
|
||||
expectedAccessibleMembers: ['saveFile'],
|
||||
},
|
||||
};
|
||||
Object.entries(testScenarios).forEach((
|
||||
[definitionKey, { expectedNamespace, expectedAccessibleMembers }],
|
||||
@@ -49,7 +53,7 @@ describe('IpcChannelDefinitions', () => {
|
||||
it('has unique accessible members within each channel', () => {
|
||||
Object.values(IpcChannelDefinitions).forEach((channel) => {
|
||||
// arrange
|
||||
const { accessibleMembers: accessibleMembersOfChannel } = channel;
|
||||
const accessibleMembersOfChannel = channel.accessibleMembers as string[];
|
||||
// act
|
||||
const repeatedAccessibleMembersInChannel = accessibleMembersOfChannel
|
||||
.filter((item, index) => accessibleMembersOfChannel.indexOf(item) !== index);
|
||||
|
||||
@@ -215,19 +215,35 @@ describe('IpcProxy', () => {
|
||||
expect(actualChannelNames).to.have.lengthOf(expectedChannelNames.length);
|
||||
expect(actualChannelNames).to.have.members(expectedChannelNames);
|
||||
});
|
||||
it('throws error for non-function members', () => {
|
||||
// arrange
|
||||
const expectedError = 'Non-function members are not yet supported';
|
||||
const propertyName = 'propertyKey';
|
||||
const testObject = { [`${propertyName}`]: 123 };
|
||||
const testIpcChannel: IpcChannel<typeof testObject> = {
|
||||
namespace: 'testNamespace',
|
||||
accessibleMembers: [propertyName] as never,
|
||||
};
|
||||
// act
|
||||
const act = () => registerIpcChannel(testIpcChannel, testObject, mockIpcMain().ipcMainMock);
|
||||
// assert
|
||||
expect(act).to.throw(expectedError);
|
||||
describe('validation', () => {
|
||||
it('throws error for non-function members', () => {
|
||||
// arrange
|
||||
const expectedError = 'Non-function members are not yet supported';
|
||||
const propertyName = 'propertyKey';
|
||||
const testObject = { [`${propertyName}`]: 123 };
|
||||
const testIpcChannel: IpcChannel<typeof testObject> = {
|
||||
namespace: 'testNamespace',
|
||||
accessibleMembers: [propertyName] as never,
|
||||
};
|
||||
// act
|
||||
const act = () => registerIpcChannel(testIpcChannel, testObject, mockIpcMain().ipcMainMock);
|
||||
// assert
|
||||
expect(act).to.throw(expectedError);
|
||||
});
|
||||
it('throws error for undefined members', () => {
|
||||
// arrange
|
||||
const nonExistingFunctionName = 'nonExistingFunction';
|
||||
const expectedError = `The function "${nonExistingFunctionName}" is not found on the target object.`;
|
||||
const testObject = { };
|
||||
const testIpcChannel: IpcChannel<typeof testObject> = {
|
||||
namespace: 'testNamespace',
|
||||
accessibleMembers: [nonExistingFunctionName] as never,
|
||||
};
|
||||
// act
|
||||
const act = () => registerIpcChannel(testIpcChannel, testObject, mockIpcMain().ipcMainMock);
|
||||
// assert
|
||||
expect(act).to.throw(expectedError);
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user