This commit introduces native operating system file dialogs in the desktop application replacing the existing web-based dialogs. It lays the foundation for future enhancements such as: - Providing error messages when saving or executing files, addressing #264. - Creating system restore points, addressing #50. Documentation updates: - Update `desktop-vs-web-features.md` with added functionality. - Update `README.md` with security feature highlights. - Update home page documentation to emphasize security features. Other supporting changes include: - Integrate IPC communication channels for secure Electron dialog API interactions. - Refactor `IpcRegistration` for more type-safety and simplicity. - Introduce a Vue hook to encapsulate dialog functionality. - Improve errors during IPC registration for easier troubleshooting. - Move `ClientLoggerFactory` for consistency in hooks organization and remove `LoggerFactory` interface for simplicity. - Add tests for the save file dialog in the browser context. - Add `Blob` polyfill in tests to compensate for the missing `blob.text()` function in `jsdom` (see jsdom/jsdom#2555). Improve environment detection logic: - Treat test environment as browser environments to correctly activate features based on the environment. This resolves issues where the environment is misidentified as desktop, but Electron preloader APIs are missing. - Rename `isDesktop` environment identification variable to `isRunningAsDesktopApplication` for better clarity and to avoid confusion with desktop environments in web/browser/test environments. - Simplify `BrowserRuntimeEnvironment` to consistently detect non-desktop application environments. - Improve environment detection for Electron main process (electron/electron#2288).
This commit is contained in:
@@ -17,6 +17,7 @@ describe('ScriptFileCodeRunner', () => {
|
||||
const currentOperatingSystem = CurrentEnvironment.os;
|
||||
if (await shouldSkipTest(currentOperatingSystem)) {
|
||||
skip();
|
||||
return;
|
||||
}
|
||||
const temporaryDirectoryProvider = createTemporaryDirectoryProvider();
|
||||
const codeRunner = createCodeRunner(temporaryDirectoryProvider);
|
||||
@@ -61,10 +62,14 @@ function getPlatformSpecificArguments(
|
||||
function shouldSkipTest(
|
||||
os: OperatingSystem | undefined,
|
||||
): Promise<boolean> {
|
||||
if (os !== OperatingSystem.Linux) {
|
||||
return Promise.resolve(false);
|
||||
}
|
||||
return isLinuxTerminalEmulatorSupported();
|
||||
}
|
||||
|
||||
function isLinuxTerminalEmulatorSupported(): Promise<boolean> {
|
||||
return new Promise((resolve) => {
|
||||
if (os !== OperatingSystem.Linux) {
|
||||
resolve(false);
|
||||
}
|
||||
exec(`which ${LinuxTerminalEmulator}`).on('close', (exitCode) => {
|
||||
resolve(exitCode !== 0);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user