This commit introduces native operating system file dialogs in the desktop application replacing the existing web-based dialogs. It lays the foundation for future enhancements such as: - Providing error messages when saving or executing files, addressing #264. - Creating system restore points, addressing #50. Documentation updates: - Update `desktop-vs-web-features.md` with added functionality. - Update `README.md` with security feature highlights. - Update home page documentation to emphasize security features. Other supporting changes include: - Integrate IPC communication channels for secure Electron dialog API interactions. - Refactor `IpcRegistration` for more type-safety and simplicity. - Introduce a Vue hook to encapsulate dialog functionality. - Improve errors during IPC registration for easier troubleshooting. - Move `ClientLoggerFactory` for consistency in hooks organization and remove `LoggerFactory` interface for simplicity. - Add tests for the save file dialog in the browser context. - Add `Blob` polyfill in tests to compensate for the missing `blob.text()` function in `jsdom` (see jsdom/jsdom#2555). Improve environment detection logic: - Treat test environment as browser environments to correctly activate features based on the environment. This resolves issues where the environment is misidentified as desktop, but Electron preloader APIs are missing. - Rename `isDesktop` environment identification variable to `isRunningAsDesktopApplication` for better clarity and to avoid confusion with desktop environments in web/browser/test environments. - Simplify `BrowserRuntimeEnvironment` to consistently detect non-desktop application environments. - Improve environment detection for Electron main process (electron/electron#2288).
This commit is contained in:
@@ -17,6 +17,7 @@ describe('ScriptFileCodeRunner', () => {
|
||||
const currentOperatingSystem = CurrentEnvironment.os;
|
||||
if (await shouldSkipTest(currentOperatingSystem)) {
|
||||
skip();
|
||||
return;
|
||||
}
|
||||
const temporaryDirectoryProvider = createTemporaryDirectoryProvider();
|
||||
const codeRunner = createCodeRunner(temporaryDirectoryProvider);
|
||||
@@ -61,10 +62,14 @@ function getPlatformSpecificArguments(
|
||||
function shouldSkipTest(
|
||||
os: OperatingSystem | undefined,
|
||||
): Promise<boolean> {
|
||||
if (os !== OperatingSystem.Linux) {
|
||||
return Promise.resolve(false);
|
||||
}
|
||||
return isLinuxTerminalEmulatorSupported();
|
||||
}
|
||||
|
||||
function isLinuxTerminalEmulatorSupported(): Promise<boolean> {
|
||||
return new Promise((resolve) => {
|
||||
if (os !== OperatingSystem.Linux) {
|
||||
resolve(false);
|
||||
}
|
||||
exec(`which ${LinuxTerminalEmulator}`).on('close', (exitCode) => {
|
||||
resolve(exitCode !== 0);
|
||||
});
|
||||
|
||||
@@ -39,6 +39,8 @@ export const BrowserOsTestCases: ReadonlyArray<BrowserOsTestCase> = [
|
||||
'Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 UBrowser/6.0.1308.1016 Safari/537.36',
|
||||
// Electron:
|
||||
'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.5993.54 Electron/27.0.0 Safari/537.36',
|
||||
// jsdom:
|
||||
'Mozilla/5.0 (Windows) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/22.1.0',
|
||||
],
|
||||
}),
|
||||
...createTests({
|
||||
@@ -60,6 +62,8 @@ export const BrowserOsTestCases: ReadonlyArray<BrowserOsTestCase> = [
|
||||
'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36 Edg/119.0.0.0',
|
||||
// Electron:
|
||||
'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.5993.54 Electron/27.0.0 Safari/537.36',
|
||||
// jsdom:
|
||||
'Mozilla/5.0 (darwin) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/22.1.0',
|
||||
],
|
||||
}),
|
||||
...createTests({
|
||||
@@ -74,6 +78,8 @@ export const BrowserOsTestCases: ReadonlyArray<BrowserOsTestCase> = [
|
||||
'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36 Edg/115.0.1901.188',
|
||||
// Electron:
|
||||
'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.5993.54 Electron/27.0.0 Safari/537.36',
|
||||
// jsdom:
|
||||
'Mozilla/5.0 (linux) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/22.1.0',
|
||||
],
|
||||
}),
|
||||
...createTests({
|
||||
|
||||
@@ -0,0 +1,23 @@
|
||||
import { describe, it, expect } from 'vitest';
|
||||
import { CurrentEnvironment } from '@/infrastructure/RuntimeEnvironment/RuntimeEnvironmentFactory';
|
||||
|
||||
describe('RuntimeEnvironmentFactory', () => {
|
||||
describe('CurrentEnvironment', () => {
|
||||
it('identifies as browser in test environment', () => { // Ensures test independence from Electron IPC
|
||||
// arrange
|
||||
const expectedDesktopAppState = false;
|
||||
// act
|
||||
const isRunningAsDesktop = CurrentEnvironment.isRunningAsDesktopApplication;
|
||||
// assert
|
||||
expect(isRunningAsDesktop).to.equal(expectedDesktopAppState);
|
||||
});
|
||||
it('identifies as non-production in test environment', () => {
|
||||
// arrange
|
||||
const expectedNonProductionState = true;
|
||||
// act
|
||||
const isNonProductionEnvironment = CurrentEnvironment.isNonProduction;
|
||||
// assert
|
||||
expect(isNonProductionEnvironment).to.equal(expectedNonProductionState);
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -29,7 +29,7 @@ describe('MobileSafariActivePseudoClassEnabler', () => {
|
||||
`User agent\t\t: ${navigator.userAgent}`,
|
||||
`Touch supported\t\t: ${supportsTouch}`,
|
||||
`Current OS\t\t: ${patchedEnvironment.os === undefined ? 'unknown' : OperatingSystem[patchedEnvironment.os]}`,
|
||||
`Is desktop?\t\t: ${patchedEnvironment.isDesktop ? 'Yes (Desktop app)' : 'No (Browser)'}`,
|
||||
`Is desktop?\t\t: ${patchedEnvironment.isRunningAsDesktopApplication ? 'Yes (Desktop app)' : 'No (Browser)'}`,
|
||||
`Listeners (${currentListeners.length})\t\t: ${JSON.stringify(currentListeners)}`,
|
||||
]));
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user