Change "grouping" to "view"
1. *Grouping* becomes *view*. Because *view* is more clear and extensible than *grouping*. It increases flexibility to extend by e.g. adding *flat* as a new view as discussed in #50, in this case "flat *view*" would make more sense than "flat *grouping*". 2. *None* becomes *tree*. Because *tree* is more descriptive than *none*. Updates labels on top menu. As labels are updated, the file structure/names are refactored to follow the same concept. `TheScriptsList` is renamed to `TheScriptsView`. Also refactors `ViewChanger` so view types are presented in same way.
This commit is contained in:
@@ -0,0 +1,54 @@
|
||||
import 'mocha';
|
||||
import { expect } from 'chai';
|
||||
import { NonCollapsing } from '@/presentation/components/Scripts/View/Cards/NonCollapsingDirective';
|
||||
import { hasDirective } from '@/presentation/components/Scripts/View/Cards/NonCollapsingDirective';
|
||||
|
||||
const expectedAttributeName = 'data-interaction-does-not-collapse';
|
||||
|
||||
describe('NonCollapsingDirective', () => {
|
||||
describe('NonCollapsing', () => {
|
||||
it('adds expected attribute to the element when inserted', () => {
|
||||
// arrange
|
||||
const element = getElementMock();
|
||||
// act
|
||||
NonCollapsing.inserted(element, undefined, undefined, undefined);
|
||||
// assert
|
||||
expect(element.hasAttribute(expectedAttributeName));
|
||||
});
|
||||
});
|
||||
describe('hasDirective', () => {
|
||||
it('returns true if the element has expected attribute', () => {
|
||||
// arrange
|
||||
const element = getElementMock();
|
||||
element.setAttribute(expectedAttributeName, undefined);
|
||||
// act
|
||||
const actual = hasDirective(element);
|
||||
// assert
|
||||
expect(actual).to.equal(true);
|
||||
});
|
||||
it('returns true if the element has a parent with expected attribute', () => {
|
||||
// arrange
|
||||
const parent = getElementMock();
|
||||
const element = getElementMock();
|
||||
parent.appendChild(element);
|
||||
element.setAttribute(expectedAttributeName, undefined);
|
||||
// act
|
||||
const actual = hasDirective(element);
|
||||
// assert
|
||||
expect(actual).to.equal(true);
|
||||
});
|
||||
it('returns false if nor the element or its parent has expected attribute', () => {
|
||||
// arrange
|
||||
const element = getElementMock();
|
||||
// act
|
||||
const actual = hasDirective(element);
|
||||
// assert
|
||||
expect(actual).to.equal(false);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
function getElementMock(): HTMLElement {
|
||||
const element = document.createElement('div');
|
||||
return element;
|
||||
}
|
||||
Reference in New Issue
Block a user