Fix invisible script execution on Windows #264

This commit addresses an issue in the privacy.sexy desktop application
where scripts executed as administrator on Windows were running in the
background. This was observed in environments like Windows Pro VMs on
Azure, where operations typically run with administrative privileges.

Previously, the application used the `"$path"` shell command to execute
scripts. This mechanism failed to activate the logic for requesting
admin privileges if the app itself was running as an administrator.
To resolve this, the script execution process has been modified to
explicitly ask for administrator privileges using the `VerbAs` method.
This ensures that the script always runs in a new `cmd.exe` window,
enhancing visibility and user interaction.

Other supporting changes:

- Rename the generated script file from `run-{timestamp}-{extension}` er
  to `{timestamp}-privacy-script-{extension}` for clearer identification
  and better file sorting.
- Refactor `ScriptFileCreator` to parameterize file extension and
  script name.
- Rename `OsTimestampedFilenameGenerator` to
  `TimestampedFilenameGenerator` to better reflect its new and more
  scoped functionality after refactoring mentioned abvoe.
- Remove `setAppName()` due to ineffective behavior in Windows.
- Update `SECURITY.md` to highlight that the app doesn't require admin
  rights for standard operations.
- Add `.editorconfig` settings for PowerShell scripts.
- Add a integration test for script execution logic. Improve environment
  detection for more reliable test execution.
- Disable application logging during unit/integration tests to keep test
  outputs clean and focused.

tests/unit/infrastructure/CodeRunner/ScriptFileCodeRunner.spec.ts

@@ -2,6 +2,7 @@ import { describe, it, expect } from 'vitest';
 import { ScriptFileCodeRunner } from '@/infrastructure/CodeRunner/ScriptFileCodeRunner';
 import { LoggerStub } from '@tests/unit/shared/Stubs/LoggerStub';
 import { Logger } from '@/application/Common/Log/Logger';
+import { ScriptFileName } from '@/application/CodeRunner/ScriptFileName';
 import { ScriptFileExecutor } from '@/infrastructure/CodeRunner/Execution/ScriptFileExecutor';
 import { ScriptFileExecutorStub } from '@tests/unit/shared/Stubs/ScriptFileExecutorStub';
 import { ScriptFileCreator } from '@/infrastructure/CodeRunner/Creation/ScriptFileCreator';
@@ -11,7 +12,7 @@ import { expectThrowsAsync } from '@tests/shared/Assertions/ExpectThrowsAsync';
 
 describe('ScriptFileCodeRunner', () => {
   describe('runCode', () => {
-    it('executes the script file as expected', async () => {
+    it('executes script file correctly', async () => {
       // arrange
       const expectedFilePath = 'expected script path';
       const fileExecutor = new ScriptFileExecutorStub();
@@ -45,6 +46,41 @@ describe('ScriptFileCodeRunner', () => {
       const [actualCode] = createCalls[0].args;
       expect(actualCode).to.equal(expectedCode);
     });
+    it('creates script file with provided extension', async () => {
+      // arrange
+      const expectedFileExtension = 'expected-file-extension';
+      const fileCreator = new ScriptFileCreatorStub();
+      const context = new CodeRunnerTestSetup()
+        .withFileCreator(fileCreator)
+        .withFileExtension(expectedFileExtension);
+
+      // act
+      await context.runCode();
+
+      // assert
+      const createCalls = fileCreator.callHistory.filter((call) => call.methodName === 'createScriptFile');
+      expect(createCalls.length).to.equal(1);
+      const [,scriptFileNameParts] = createCalls[0].args;
+      expectExists(scriptFileNameParts, JSON.stringify(`Call args: ${JSON.stringify(createCalls[0].args)}`));
+      expect(scriptFileNameParts.scriptFileExtension).to.equal(expectedFileExtension);
+    });
+    it('creates script file with provided name', async () => {
+      // arrange
+      const expectedScriptName = ScriptFileName;
+      const fileCreator = new ScriptFileCreatorStub();
+      const context = new CodeRunnerTestSetup()
+        .withFileCreator(fileCreator);
+
+      // act
+      await context.runCode();
+
+      // assert
+      const createCalls = fileCreator.callHistory.filter((call) => call.methodName === 'createScriptFile');
+      expect(createCalls.length).to.equal(1);
+      const [,scriptFileNameParts] = createCalls[0].args;
+      expectExists(scriptFileNameParts, JSON.stringify(`Call args: ${JSON.stringify(createCalls[0].args)}`));
+      expect(scriptFileNameParts.scriptName).to.equal(expectedScriptName);
+    });
     describe('error handling', () => {
       const testScenarios: ReadonlyArray<{
         readonly description: string;
@@ -52,7 +88,7 @@ describe('ScriptFileCodeRunner', () => {
         readonly faultyContext: CodeRunnerTestSetup;
       }> = [
         (() => {
-          const error = new Error('script file execution failed');
+          const error = new Error('Test Error: Script file execution intentionally failed for testing purposes.');
           const executor = new ScriptFileExecutorStub();
           executor.executeScriptFile = () => {
             throw error;
@@ -64,7 +100,7 @@ describe('ScriptFileCodeRunner', () => {
           };
         })(),
         (() => {
-          const error = new Error('script file creation failed');
+          const error = new Error('Test Error: Script file creation intentionally failed for testing purposes.');
           const creator = new ScriptFileCreatorStub();
           creator.createScriptFile = () => {
             throw error;
@@ -76,7 +112,7 @@ describe('ScriptFileCodeRunner', () => {
           };
         })(),
       ];
-      describe('logs errors correctly', () => {
+      describe('logs errors', () => {
         testScenarios.forEach(({ description, faultyContext }) => {
           it(`logs error when ${description}`, async () => {
             // arrange
@@ -94,7 +130,7 @@ describe('ScriptFileCodeRunner', () => {
           });
         });
       });
-      describe('correctly rethrows errors', () => {
+      describe('rethrows errors', () => {
         testScenarios.forEach(({ description, injectedException, faultyContext }) => {
           it(`rethrows error when ${description}`, async () => {
             // act
@@ -111,6 +147,8 @@ describe('ScriptFileCodeRunner', () => {
 class CodeRunnerTestSetup {
   private code = `[${CodeRunnerTestSetup.name}]code`;
 
+  private fileExtension = `[${CodeRunnerTestSetup.name}]file-extension`;
+
   private fileCreator: ScriptFileCreator = new ScriptFileCreatorStub();
 
   private fileExecutor: ScriptFileExecutor = new ScriptFileExecutorStub();
@@ -123,7 +161,7 @@ class CodeRunnerTestSetup {
       this.fileCreator,
       this.logger,
     );
-    await runner.runCode(this.code);
+    await runner.runCode(this.code, this.fileExtension);
   }
 
   public withFileExecutor(fileExecutor: ScriptFileExecutor): this {
@@ -145,4 +183,9 @@ class CodeRunnerTestSetup {
     this.fileCreator = fileCreator;
     return this;
   }
+
+  public withFileExtension(fileExtension: string): this {
+    this.fileExtension = fileExtension;
+    return this;
+  }
 }