Improve script/category name validation

- Use better error messages with more context.
- Unify their validation logic and share tests.
- Validate also type of the name.
- Refactor node (Script/Category) parser tests for easier future
  changes and cleaner test code (using `TestBuilder` to do dirty work in
  unified way).
- Add more tests. Custom `Error` properties are compared manually due to
  `chai` not supporting deep equality checks (chaijs/chai#1065,
  chaijs/chai#1405).
This commit is contained in:
undergroundwires
2021-12-16 02:40:56 +01:00
parent 65902e5b72
commit b210aaddf2
17 changed files with 857 additions and 196 deletions

View File

@@ -23,9 +23,9 @@ export class EnumParserStub<T> implements IEnumParser<T> {
if (scenario) {
return scenario.outputValue;
}
if (this.defaultValue) {
if (this.defaultValue !== undefined) {
return this.defaultValue;
}
throw new Error('enum parser is not set up');
throw new Error(`Don't know now what to return from ${EnumParserStub.name}, forgot to set-up?`);
}
}