Increase testability through dependency injection

- Remove existing integration tests for hooks as they're redundant after
  this change.
- Document the pattern in relevant documentation.
- Introduce `useEnvironment` to increase testability.
- Update components to inject dependencies rather than importing hooks
  directly.
This commit is contained in:
undergroundwires
2023-08-15 18:11:30 +02:00
parent 39e650cf11
commit ae75059cc1
32 changed files with 209 additions and 201 deletions

View File

@@ -3,8 +3,21 @@ import { expect } from 'chai';
import { useApplication } from '@/presentation/components/Shared/Hooks/UseApplication';
import { ApplicationStub } from '@tests/unit/shared/Stubs/ApplicationStub';
import { ProjectInformationStub } from '@tests/unit/shared/Stubs/ProjectInformationStub';
import { itEachAbsentObjectValue } from '@tests/unit/shared/TestCases/AbsentTests';
describe('UseApplication', () => {
describe('application is absent', () => {
itEachAbsentObjectValue((absentValue) => {
// arrange
const expectedError = 'missing application';
const applicationValue = absentValue;
// act
const act = () => useApplication(applicationValue);
// assert
expect(act).to.throw(expectedError);
});
});
it('should return expected info', () => {
// arrange
const expectedInfo = new ProjectInformationStub()

View File

@@ -9,6 +9,18 @@ import { OperatingSystem } from '@/domain/OperatingSystem';
import { itEachAbsentObjectValue } from '@tests/unit/shared/TestCases/AbsentTests';
describe('UseCollectionState', () => {
describe('context is absent', () => {
itEachAbsentObjectValue((absentValue) => {
// arrange
const expectedError = 'missing context';
const contextValue = absentValue;
// act
const act = () => useCollectionState(contextValue);
// assert
expect(act).to.throw(expectedError);
});
});
describe('currentContext', () => {
it('returns current context', () => {
// arrange

View File

@@ -0,0 +1,28 @@
import 'mocha';
import { expect } from 'chai';
import { useEnvironment } from '@/presentation/components/Shared/Hooks/UseEnvironment';
import { itEachAbsentObjectValue } from '@tests/unit/shared/TestCases/AbsentTests';
import { EnvironmentStub } from '@tests/unit/shared/Stubs/EnvironmentStub';
describe('UseEnvironment', () => {
describe('environment is absent', () => {
itEachAbsentObjectValue((absentValue) => {
// arrange
const expectedError = 'missing environment';
const environmentValue = absentValue;
// act
const act = () => useEnvironment(environmentValue);
// assert
expect(act).to.throw(expectedError);
});
});
it('returns expected environment', () => {
// arrange
const expectedEnvironment = new EnvironmentStub();
// act
const actualEnvironment = useEnvironment(expectedEnvironment);
// assert
expect(actualEnvironment).to.equal(expectedEnvironment);
});
});